Re: [PATCH v2 3/9] util/grub-editenv: add fs_envblk write helper

[Avnish Chouhan <avnish@linux.ibm.com>]

On 2025-10-02 11:23, Michael Chang wrote:
> Hi Avnish,
> 
> Thanks a not for the review, please check my comments below.
> 
> On Wed, Sep 17, 2025 at 04:34:52PM +0530, Avnish Chouhan wrote:
>> On 2025-09-15 14:39, grub-devel-request@gnu.org wrote:
>>  > Message: 4
>> > Date: Mon, 15 Sep 2025 17:08:42 +0800
>> > From: Michael Chang <mchang@suse.com>
>> > To: The development of GNU GRUB <grub-devel@gnu.org>
>> > Cc: Neal Gompa <ngompa13@gmail.com>,	Marta Lewandowska
>> > 	<mlewando@redhat.com>
>> > Subject: [PATCH v2 3/9] util/grub-editenv: add fs_envblk write helper
>> > Message-ID: <20250915090848.131937-4-mchang@suse.com>
>> >
>> > This patch adds the function fs_envblk_write to update the reserved
>> > environment block on disk. The helper takes an in memory envblk buffer
>> > and writes it back to the device at the location defined by the
>> > fs_envblk specification. It performs size checks and uses file sync to
>> > ensure that the updated data is flushed.
>> >
>> > The helper is also added into the fs_envblk ops table, together with the
>> > open helper from the previous patch. With this change the basic input
>> > and output path for an external environment block is complete. The
>> > choice of which variables should be written externally will be handled
>> > by later patches.
>> >
>> > Signed-off-by: Michael Chang <mchang@suse.com>

Reviewed-by: Avnish Chouhan <avnish@linux.ibm.com>

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel