From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Songjun Wu <songjun.wu@microchip.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 5/6] [media] atmel-isi: Improve three size determinations
Date: Mon, 04 Sep 2017 20:11:22 +0000 [thread overview]
Message-ID: <2a5b21a7-91af-238a-0064-e382fb85afe3@users.sourceforge.net> (raw)
In-Reply-To: <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 4 Sep 2017 21:27:45 +0200
Replace the specification of data types by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/atmel/atmel-isi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c
index 154e9c39b64f..ac40defce1e7 100644
--- a/drivers/media/platform/atmel/atmel-isi.c
+++ b/drivers/media/platform/atmel/atmel-isi.c
@@ -1036,13 +1036,13 @@ static int isi_formats_init(struct atmel_isi *isi)
isi->num_user_formats = num_fmts;
isi->user_formats = devm_kcalloc(isi->dev,
- num_fmts, sizeof(struct isi_format *),
+ num_fmts, sizeof(*isi->user_formats),
GFP_KERNEL);
if (!isi->user_formats)
return -ENOMEM;
memcpy(isi->user_formats, isi_fmts,
- num_fmts * sizeof(struct isi_format *));
+ num_fmts * sizeof(*isi->user_formats));
isi->current_fmt = isi->user_formats[0];
return 0;
@@ -1173,5 +1173,5 @@ static int atmel_isi_probe(struct platform_device *pdev)
struct resource *regs;
int ret, i;
- isi = devm_kzalloc(&pdev->dev, sizeof(struct atmel_isi), GFP_KERNEL);
+ isi = devm_kzalloc(&pdev->dev, sizeof(*isi), GFP_KERNEL);
if (!isi)
--
2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Songjun Wu <songjun.wu@microchip.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 5/6] [media] atmel-isi: Improve three size determinations
Date: Mon, 4 Sep 2017 22:11:22 +0200 [thread overview]
Message-ID: <2a5b21a7-91af-238a-0064-e382fb85afe3@users.sourceforge.net> (raw)
In-Reply-To: <88d0739c-fdc1-9d7d-fe53-b7c2eeed1849@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 4 Sep 2017 21:27:45 +0200
Replace the specification of data types by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/platform/atmel/atmel-isi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isi.c b/drivers/media/platform/atmel/atmel-isi.c
index 154e9c39b64f..ac40defce1e7 100644
--- a/drivers/media/platform/atmel/atmel-isi.c
+++ b/drivers/media/platform/atmel/atmel-isi.c
@@ -1036,13 +1036,13 @@ static int isi_formats_init(struct atmel_isi *isi)
isi->num_user_formats = num_fmts;
isi->user_formats = devm_kcalloc(isi->dev,
- num_fmts, sizeof(struct isi_format *),
+ num_fmts, sizeof(*isi->user_formats),
GFP_KERNEL);
if (!isi->user_formats)
return -ENOMEM;
memcpy(isi->user_formats, isi_fmts,
- num_fmts * sizeof(struct isi_format *));
+ num_fmts * sizeof(*isi->user_formats));
isi->current_fmt = isi->user_formats[0];
return 0;
@@ -1173,5 +1173,5 @@ static int atmel_isi_probe(struct platform_device *pdev)
struct resource *regs;
int ret, i;
- isi = devm_kzalloc(&pdev->dev, sizeof(struct atmel_isi), GFP_KERNEL);
+ isi = devm_kzalloc(&pdev->dev, sizeof(*isi), GFP_KERNEL);
if (!isi)
--
2.14.1
next prev parent reply other threads:[~2017-09-04 20:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 20:04 [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations SF Markus Elfring
2017-09-04 20:04 ` SF Markus Elfring
2017-09-04 20:05 ` [PATCH 1/6] [media] atmel-isc: Delete an error message for a failed memory allocation in isc_formats SF Markus Elfring
2017-09-04 20:05 ` [PATCH 1/6] [media] atmel-isc: Delete an error message for a failed memory allocation in isc_formats_init() SF Markus Elfring
2017-09-04 20:07 ` [PATCH 2/6] [media] atmel-isc: Improve a size determination " SF Markus Elfring
2017-09-04 20:07 ` SF Markus Elfring
2017-09-04 20:08 ` [PATCH 3/6] [media] atmel-isc: Adjust three checks for null pointers SF Markus Elfring
2017-09-04 20:08 ` SF Markus Elfring
2017-09-04 20:10 ` [PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functio SF Markus Elfring
2017-09-04 20:10 ` [PATCH 4/6] [media] atmel-isi: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2017-09-04 20:11 ` SF Markus Elfring [this message]
2017-09-04 20:11 ` [PATCH 5/6] [media] atmel-isi: Improve three size determinations SF Markus Elfring
2017-09-04 20:12 ` [PATCH 6/6] [media] atmel-isi: Adjust a null pointer check in three functions SF Markus Elfring
2017-09-04 20:12 ` SF Markus Elfring
2017-09-06 0:58 ` [PATCH 0/6] [media] Atmel: Adjustments for seven function implementations Yang, Wenyou
2017-09-06 0:58 ` Yang, Wenyou
2017-09-06 5:59 ` Ludovic Desroches
2017-09-06 5:59 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a5b21a7-91af-238a-0064-e382fb85afe3@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mchehab@kernel.org \
--cc=songjun.wu@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.