[PATCH 1/2] net/ark: add new device to PCIe allowlist

[PATCH 1/2] net/ark: add new device to PCIe allowlist

[Shepard Siegel]

This patch adds the Arkville FX2 device to the PCIe allowlist.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 drivers/net/ark/ark_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c654a229f7..b2995427c8 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
+	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
 	{.vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.25.1

[PATCH 2/2] doc: update ark guide to include new PCIe device

[Shepard Siegel]

Add descriptions of the new FX2 device to the existing devices.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index edaa02dc96..bbd7419d99 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -306,6 +306,7 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
+* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
 
 Arkville RTL Core Configurations
 -------------------------------------
@@ -318,6 +319,7 @@ interfaces for both AMD/Xilinx and Intel FPGAs.
 
 * ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
 * ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
 
 DPDK and Arkville Firmware Versioning
 -------------------------------------
-- 
2.25.1

Re: [PATCH 1/2] net/ark: add new device to PCIe allowlist

[Ferruh Yigit]

On 2/11/2023 2:14 PM, Shepard Siegel wrote:
> This patch adds the Arkville FX2 device to the PCIe allowlist.
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>

Hi Shepard, Ed,

The patchset looks good, I can squash them into single patch while merging.

I don't know how major this new device is, if it is an important one you
may want to introduce it in the release notes too, what do think?

And if you will send a new version, can you please put previous doc
patch [1] and this to the same patchset since this one depends previous
doc patch to apply cleanly.

Thanks.


[1]
doc: clarify the existing net/ark guide

Re: [PATCH 1/2] net/ark: add new device to PCIe allowlist

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

Thank you Ferruh,

We have rolled all changes, including your suggestion on the Release Note,
into the four distinct patches in this patchset which collectively brings
the
ark PMD up to date for this new capability.

best, Shep


On Mon, Feb 13, 2023 at 8:46 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/11/2023 2:14 PM, Shepard Siegel wrote:
> > This patch adds the Arkville FX2 device to the PCIe allowlist.
> >
> > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
>
> Hi Shepard, Ed,
>
> The patchset looks good, I can squash them into single patch while merging.
>
> I don't know how major this new device is, if it is an important one you
> may want to introduce it in the release notes too, what do think?
>
> And if you will send a new version, can you please put previous doc
> patch [1] and this to the same patchset since this one depends previous
> doc patch to apply cleanly.
>
> Thanks.
>
>
> [1]
> doc: clarify the existing net/ark guide
>

[-- Attachment #2: Type: text/html, Size: 1497 bytes --]

[PATCH 1/4] doc: clarify the existing net/ark guide

[Shepard Siegel]

Add detail for the existing Arkville configurations FX0 and FX1.
Corrected minor errors of omission.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index ba00f14e80..edaa02dc96 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
 hardware queue-pairs are negotiated; the driver is designed to
 remain constant over a broad and extendable feature set.
 
+* FPGA Vendors Supported: AMD/Xilinx and Intel
+* Number of RX/TX Queue-Pairs: up to 128
+* PCIe Endpoint Technology: Gen3, Gen4, Gen5
+
 Intentionally, Arkville by itself DOES NOT provide common NIC
 capabilities such as offload or receive-side scaling (RSS).
 These capabilities would be viewed as a gate-level "tax" on
@@ -303,6 +307,18 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
 
+Arkville RTL Core Configurations
+-------------------------------------
+
+Arkville's RTL core may be configured by the user with different
+datapath widths to balance throughput against FPGA logic area. The ARK PMD
+has introspection on the RTL core configuration and acts accordingly.
+All Arkville configurations present identical RTL user-facing AXI stream
+interfaces for both AMD/Xilinx and Intel FPGAs.
+
+* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
+* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+
 DPDK and Arkville Firmware Versioning
 -------------------------------------
 
@@ -334,6 +350,8 @@ Supported Features
 ------------------
 
 * Dynamic ARK PMD extensions
+* Dynamic per-queue MBUF (re)sizing up to 32KB
+* SR-IOV, VF-based queue-segregation
 * Multiple receive and transmit queues
 * Jumbo frames up to 9K
 * Hardware Statistics
-- 
2.25.1

[PATCH 2/4] net/ark: add new device to PCIe allowlist

[Shepard Siegel]

This patch adds the Arkville FX2 device to the PCIe allowlist.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 drivers/net/ark/ark_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c654a229f7..b2995427c8 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
+	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
 	{.vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.25.1

Re: [PATCH 2/4] net/ark: add new device to PCIe allowlist

[Ferruh Yigit]

On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> This patch adds the Arkville FX2 device to the PCIe allowlist.
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>  drivers/net/ark/ark_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> index c654a229f7..b2995427c8 100644
> --- a/drivers/net/ark/ark_ethdev.c
> +++ b/drivers/net/ark/ark_ethdev.c
> @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
>  	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> +	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
>  	{.vendor_id = 0, /* sentinel */ },
>  };
>  

It is possible to squash 2/4, 3/4 & 4/4 into single patch, I can do it
while merging.

In the patch title it mentions 'PCIe allowlist', this is not a kind of
allow list, this is list of PCI ids supported by driver, so I can update
patch title as following while merging if there won't be a new version:
"net/ark: support Arkville FX2 device"

Re: [PATCH 2/4] net/ark: add new device to PCIe allowlist

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]

Hi Ferruh,

If you dont mind squashing 2/4 3/4 4/4 together, that would be great.

Thank you for correcting on the allowlist, s..b "supported PCIe ids list"
instead.

best, Shep


On Mon, Feb 13, 2023 at 10:51 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> > This patch adds the Arkville FX2 device to the PCIe allowlist.
> >
> > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> > ---
> >  drivers/net/ark/ark_ethdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
> > index c654a229f7..b2995427c8 100644
> > --- a/drivers/net/ark/ark_ethdev.c
> > +++ b/drivers/net/ark/ark_ethdev.c
> > @@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
> >       {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
> > +     {RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
> >       {.vendor_id = 0, /* sentinel */ },
> >  };
> >
>
> It is possible to squash 2/4, 3/4 & 4/4 into single patch, I can do it
> while merging.
>
> In the patch title it mentions 'PCIe allowlist', this is not a kind of
> allow list, this is list of PCI ids supported by driver, so I can update
> patch title as following while merging if there won't be a new version:
> "net/ark: support Arkville FX2 device"
>

[-- Attachment #2: Type: text/html, Size: 2058 bytes --]

[PATCH 3/4] doc: update ark guide to include new PCIe device

[Shepard Siegel]

Add descriptions of the new FX2 device to the existing devices.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index edaa02dc96..bbd7419d99 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -306,6 +306,7 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
+* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
 
 Arkville RTL Core Configurations
 -------------------------------------
@@ -318,6 +319,7 @@ interfaces for both AMD/Xilinx and Intel FPGAs.
 
 * ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
 * ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
 
 DPDK and Arkville Firmware Versioning
 -------------------------------------
-- 
2.25.1

[PATCH 4/4] doc: update Release Notes

[Shepard Siegel]

New Arkville FX2 device for PCIe Gen5x16 supported with net/ark

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/rel_notes/release_23_03.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst
index 7527c6d57f..7941b22c8a 100644
--- a/doc/guides/rel_notes/release_23_03.rst
+++ b/doc/guides/rel_notes/release_23_03.rst
@@ -72,6 +72,10 @@ New Features
 
   * Added multi-process support.
 
+* **Updated Atomic Rules ark driver.**
+
+  * Added Arkville FX2 device supporting PCIe Gen5x16
+
 * **Updated Corigine nfp driver.**
 
   * Added support for meter options.
-- 
2.25.1

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

[Ferruh Yigit]

On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> Add detail for the existing Arkville configurations FX0 and FX1.
> Corrected minor errors of omission.
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>  doc/guides/nics/ark.rst | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> index ba00f14e80..edaa02dc96 100644
> --- a/doc/guides/nics/ark.rst
> +++ b/doc/guides/nics/ark.rst
> @@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
>  hardware queue-pairs are negotiated; the driver is designed to
>  remain constant over a broad and extendable feature set.
>  
> +* FPGA Vendors Supported: AMD/Xilinx and Intel
> +* Number of RX/TX Queue-Pairs: up to 128
> +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> +
>  Intentionally, Arkville by itself DOES NOT provide common NIC
>  capabilities such as offload or receive-side scaling (RSS).
>  These capabilities would be viewed as a gate-level "tax" on
> @@ -303,6 +307,18 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
>  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
>  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
>  
> +Arkville RTL Core Configurations
> +-------------------------------------
> +

The title marker length (-) should be same as title length, can you
please fix if there will be next version, if not I can fix while merging.


> +Arkville's RTL core may be configured by the user with different
> +datapath widths to balance throughput against FPGA logic area. The ARK PMD
> +has introspection on the RTL core configuration and acts accordingly.
> +All Arkville configurations present identical RTL user-facing AXI stream
> +interfaces for both AMD/Xilinx and Intel FPGAs.
> +
> +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> +
>  DPDK and Arkville Firmware Versioning
>  -------------------------------------
>  
> @@ -334,6 +350,8 @@ Supported Features
>  ------------------
>  
>  * Dynamic ARK PMD extensions
> +* Dynamic per-queue MBUF (re)sizing up to 32KB

What is this feature? What does it mean to size/resize mbuf dynamically?

> +* SR-IOV, VF-based queue-segregation
>  * Multiple receive and transmit queues
>  * Jumbo frames up to 9K
>  * Hardware Statistics

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 3079 bytes --]

Hi Ferruh,

Yes, there will probably be next versions in the future. If you don't mind
making the marker length adjustment, that would be great.

Regarding MBUF (re)sizing  - Arkville supports the ability to configure or
reconfigure the MBUF size used on a per-queue basis. This feature is useful
when the are conflicting motivations for using smaller/larger MBUF sizes.
For example, user can switch a queue to use a size best for that
queue's application workload.

-Shep


On Mon, Feb 13, 2023 at 10:46 AM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> > Add detail for the existing Arkville configurations FX0 and FX1.
> > Corrected minor errors of omission.
> >
> > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> > ---
> >  doc/guides/nics/ark.rst | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> > index ba00f14e80..edaa02dc96 100644
> > --- a/doc/guides/nics/ark.rst
> > +++ b/doc/guides/nics/ark.rst
> > @@ -52,6 +52,10 @@ board. While specific capabilities such as number of
> physical
> >  hardware queue-pairs are negotiated; the driver is designed to
> >  remain constant over a broad and extendable feature set.
> >
> > +* FPGA Vendors Supported: AMD/Xilinx and Intel
> > +* Number of RX/TX Queue-Pairs: up to 128
> > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> > +
> >  Intentionally, Arkville by itself DOES NOT provide common NIC
> >  capabilities such as offload or receive-side scaling (RSS).
> >  These capabilities would be viewed as a gate-level "tax" on
> > @@ -303,6 +307,18 @@ ARK PMD supports the following Arkville RTL PCIe
> instances including:
> >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex
> R-Tile]
> >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> >
> > +Arkville RTL Core Configurations
> > +-------------------------------------
> > +
>
> The title marker length (-) should be same as title length, can you
> please fix if there will be next version, if not I can fix while merging.
>
>
> > +Arkville's RTL core may be configured by the user with different
> > +datapath widths to balance throughput against FPGA logic area. The ARK
> PMD
> > +has introspection on the RTL core configuration and acts accordingly.
> > +All Arkville configurations present identical RTL user-facing AXI stream
> > +interfaces for both AMD/Xilinx and Intel FPGAs.
> > +
> > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> > +
> >  DPDK and Arkville Firmware Versioning
> >  -------------------------------------
> >
> > @@ -334,6 +350,8 @@ Supported Features
> >  ------------------
> >
> >  * Dynamic ARK PMD extensions
> > +* Dynamic per-queue MBUF (re)sizing up to 32KB
>
> What is this feature? What does it mean to size/resize mbuf dynamically?
>
> > +* SR-IOV, VF-based queue-segregation
> >  * Multiple receive and transmit queues
> >  * Jumbo frames up to 9K
> >  * Hardware Statistics
>
>

[-- Attachment #2: Type: text/html, Size: 3907 bytes --]

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

[Ferruh Yigit]

On 2/13/2023 5:09 PM, Shepard Siegel wrote:
> Hi Ferruh,
> 
> Yes, there will probably be next versions in the future. If you don't
> mind making the marker length adjustment, that would be great.
> 
> Regarding MBUF (re)sizing  - Arkville supports the ability to configure
> or reconfigure the MBUF size used on a per-queue basis. This feature is
> useful when the are conflicting motivations for using smaller/larger
> MBUF sizes. For example, user can switch a queue to use a size best for
> that queue's application workload.
> 

Application can allocate multiple mempool with different sizes and set
these to specific queues, this is same for all PMDs, is ark PMD doing
something specific here? Or are you referring to something else?

And what does 'dynamic' emphasis means here?


> -Shep
> 
> 
> On Mon, Feb 13, 2023 at 10:46 AM Ferruh Yigit <ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>> wrote:
> 
>     On 2/13/2023 2:58 PM, Shepard Siegel wrote:
>     > Add detail for the existing Arkville configurations FX0 and FX1.
>     > Corrected minor errors of omission.
>     >
>     > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com
>     <mailto:shepard.siegel@atomicrules.com>>
>     > ---
>     >  doc/guides/nics/ark.rst | 18 ++++++++++++++++++
>     >  1 file changed, 18 insertions(+)
>     >
>     > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
>     > index ba00f14e80..edaa02dc96 100644
>     > --- a/doc/guides/nics/ark.rst
>     > +++ b/doc/guides/nics/ark.rst
>     > @@ -52,6 +52,10 @@ board. While specific capabilities such as
>     number of physical
>     >  hardware queue-pairs are negotiated; the driver is designed to
>     >  remain constant over a broad and extendable feature set.
>     > 
>     > +* FPGA Vendors Supported: AMD/Xilinx and Intel
>     > +* Number of RX/TX Queue-Pairs: up to 128
>     > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
>     > +
>     >  Intentionally, Arkville by itself DOES NOT provide common NIC
>     >  capabilities such as offload or receive-side scaling (RSS).
>     >  These capabilities would be viewed as a gate-level "tax" on
>     > @@ -303,6 +307,18 @@ ARK PMD supports the following Arkville RTL
>     PCIe instances including:
>     >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for
>     Agilex R-Tile]
>     >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
>     > 
>     > +Arkville RTL Core Configurations
>     > +-------------------------------------
>     > +
> 
>     The title marker length (-) should be same as title length, can you
>     please fix if there will be next version, if not I can fix while
>     merging.
> 
> 
>     > +Arkville's RTL core may be configured by the user with different
>     > +datapath widths to balance throughput against FPGA logic area.
>     The ARK PMD
>     > +has introspection on the RTL core configuration and acts accordingly.
>     > +All Arkville configurations present identical RTL user-facing AXI
>     stream
>     > +interfaces for both AMD/Xilinx and Intel FPGAs.
>     > +
>     > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
>     > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
>     > +
>     >  DPDK and Arkville Firmware Versioning
>     >  -------------------------------------
>     > 
>     > @@ -334,6 +350,8 @@ Supported Features
>     >  ------------------
>     > 
>     >  * Dynamic ARK PMD extensions
>     > +* Dynamic per-queue MBUF (re)sizing up to 32KB
> 
>     What is this feature? What does it mean to size/resize mbuf dynamically?
> 
>     > +* SR-IOV, VF-based queue-segregation
>     >  * Multiple receive and transmit queues
>     >  * Jumbo frames up to 9K
>     >  * Hardware Statistics
> 

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

[Shepard Siegel]

[-- Attachment #1: Type: text/plain, Size: 4655 bytes --]

Yes, what is different here is that the MBUF size is communicated from the
PMD to the hardware which *changes its behavior* of data motion to
optimize throughput and latency as a function of that setting. And it does
that per-queue. And can be done at runtime (that's the dynamic part). ...
To the best our knowledge, other PMDs use this as a host-software setting
only - and their DPDK naive DMA engines just use the same fixed settings
(respecting PCIe, of course).

Hope that helps. If it is contentious in any way, we are fine with
removing that line. We added it as users have remarked it is a unique
capability they think we should point out.

-Shep


On Mon, Feb 13, 2023 at 12:23 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 2/13/2023 5:09 PM, Shepard Siegel wrote:
> > Hi Ferruh,
> >
> > Yes, there will probably be next versions in the future. If you don't
> > mind making the marker length adjustment, that would be great.
> >
> > Regarding MBUF (re)sizing  - Arkville supports the ability to configure
> > or reconfigure the MBUF size used on a per-queue basis. This feature is
> > useful when the are conflicting motivations for using smaller/larger
> > MBUF sizes. For example, user can switch a queue to use a size best for
> > that queue's application workload.
> >
>
> Application can allocate multiple mempool with different sizes and set
> these to specific queues, this is same for all PMDs, is ark PMD doing
> something specific here? Or are you referring to something else?
>
> And what does 'dynamic' emphasis means here?
>
>
> > -Shep
> >
> >
> > On Mon, Feb 13, 2023 at 10:46 AM Ferruh Yigit <ferruh.yigit@amd.com
> > <mailto:ferruh.yigit@amd.com>> wrote:
> >
> >     On 2/13/2023 2:58 PM, Shepard Siegel wrote:
> >     > Add detail for the existing Arkville configurations FX0 and FX1.
> >     > Corrected minor errors of omission.
> >     >
> >     > Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com
> >     <mailto:shepard.siegel@atomicrules.com>>
> >     > ---
> >     >  doc/guides/nics/ark.rst | 18 ++++++++++++++++++
> >     >  1 file changed, 18 insertions(+)
> >     >
> >     > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> >     > index ba00f14e80..edaa02dc96 100644
> >     > --- a/doc/guides/nics/ark.rst
> >     > +++ b/doc/guides/nics/ark.rst
> >     > @@ -52,6 +52,10 @@ board. While specific capabilities such as
> >     number of physical
> >     >  hardware queue-pairs are negotiated; the driver is designed to
> >     >  remain constant over a broad and extendable feature set.
> >     >
> >     > +* FPGA Vendors Supported: AMD/Xilinx and Intel
> >     > +* Number of RX/TX Queue-Pairs: up to 128
> >     > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> >     > +
> >     >  Intentionally, Arkville by itself DOES NOT provide common NIC
> >     >  capabilities such as offload or receive-side scaling (RSS).
> >     >  These capabilities would be viewed as a gate-level "tax" on
> >     > @@ -303,6 +307,18 @@ ARK PMD supports the following Arkville RTL
> >     PCIe instances including:
> >     >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for
> >     Agilex R-Tile]
> >     >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> >     >
> >     > +Arkville RTL Core Configurations
> >     > +-------------------------------------
> >     > +
> >
> >     The title marker length (-) should be same as title length, can you
> >     please fix if there will be next version, if not I can fix while
> >     merging.
> >
> >
> >     > +Arkville's RTL core may be configured by the user with different
> >     > +datapath widths to balance throughput against FPGA logic area.
> >     The ARK PMD
> >     > +has introspection on the RTL core configuration and acts
> accordingly.
> >     > +All Arkville configurations present identical RTL user-facing AXI
> >     stream
> >     > +interfaces for both AMD/Xilinx and Intel FPGAs.
> >     > +
> >     > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> >     > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> >     > +
> >     >  DPDK and Arkville Firmware Versioning
> >     >  -------------------------------------
> >     >
> >     > @@ -334,6 +350,8 @@ Supported Features
> >     >  ------------------
> >     >
> >     >  * Dynamic ARK PMD extensions
> >     > +* Dynamic per-queue MBUF (re)sizing up to 32KB
> >
> >     What is this feature? What does it mean to size/resize mbuf
> dynamically?
> >
> >     > +* SR-IOV, VF-based queue-segregation
> >     >  * Multiple receive and transmit queues
> >     >  * Jumbo frames up to 9K
> >     >  * Hardware Statistics
> >
>
>

[-- Attachment #2: Type: text/html, Size: 6231 bytes --]

Re: [PATCH 1/4] doc: clarify the existing net/ark guide

[Ferruh Yigit]

On 2/13/2023 5:31 PM, Shepard Siegel wrote:
> Yes, what is different here is that the MBUF size is communicated
> from the PMD to the hardware which *changes its behavior* of data motion
> to optimize throughput and latency as a function of that setting. And it
> does that per-queue. And can be done at runtime (that's the
> dynamic part). ... To the best our knowledge, other PMDs use this as a
> host-software setting only - and their DPDK naive DMA engines just use
> the same fixed settings (respecting PCIe, of course).
> 
> Hope that helps. If it is contentious in any way, we are fine with
> removing that line. We added it as users have remarked it is a unique
> capability they think we should point out.
> 

Just trying to clarify the feature you are referring, this helps to your
users too.

I was thinking this feature is already granted and if there is more
details in the documented feature, but it is not granted and OK to keep
as it is.


> -Shep
> 
> 
> On Mon, Feb 13, 2023 at 12:23 PM Ferruh Yigit <ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>> wrote:
> 
>     On 2/13/2023 5:09 PM, Shepard Siegel wrote:
>     > Hi Ferruh,
>     >
>     > Yes, there will probably be next versions in the future. If you don't
>     > mind making the marker length adjustment, that would be great.
>     >
>     > Regarding MBUF (re)sizing  - Arkville supports the ability to
>     configure
>     > or reconfigure the MBUF size used on a per-queue basis. This
>     feature is
>     > useful when the are conflicting motivations for using smaller/larger
>     > MBUF sizes. For example, user can switch a queue to use a size
>     best for
>     > that queue's application workload.
>     >
> 
>     Application can allocate multiple mempool with different sizes and set
>     these to specific queues, this is same for all PMDs, is ark PMD doing
>     something specific here? Or are you referring to something else?
> 
>     And what does 'dynamic' emphasis means here?
> 
> 
>     > -Shep
>     >
>     >
>     > On Mon, Feb 13, 2023 at 10:46 AM Ferruh Yigit
>     <ferruh.yigit@amd.com <mailto:ferruh.yigit@amd.com>
>     > <mailto:ferruh.yigit@amd.com <mailto:ferruh.yigit@amd.com>>> wrote:
>     >
>     >     On 2/13/2023 2:58 PM, Shepard Siegel wrote:
>     >     > Add detail for the existing Arkville configurations FX0 and FX1.
>     >     > Corrected minor errors of omission.
>     >     >
>     >     > Signed-off-by: Shepard Siegel
>     <shepard.siegel@atomicrules.com <mailto:shepard.siegel@atomicrules.com>
>     >     <mailto:shepard.siegel@atomicrules.com
>     <mailto:shepard.siegel@atomicrules.com>>>
>     >     > ---
>     >     >  doc/guides/nics/ark.rst | 18 ++++++++++++++++++
>     >     >  1 file changed, 18 insertions(+)
>     >     >
>     >     > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
>     >     > index ba00f14e80..edaa02dc96 100644
>     >     > --- a/doc/guides/nics/ark.rst
>     >     > +++ b/doc/guides/nics/ark.rst
>     >     > @@ -52,6 +52,10 @@ board. While specific capabilities such as
>     >     number of physical
>     >     >  hardware queue-pairs are negotiated; the driver is designed to
>     >     >  remain constant over a broad and extendable feature set.
>     >     > 
>     >     > +* FPGA Vendors Supported: AMD/Xilinx and Intel
>     >     > +* Number of RX/TX Queue-Pairs: up to 128
>     >     > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
>     >     > +
>     >     >  Intentionally, Arkville by itself DOES NOT provide common NIC
>     >     >  capabilities such as offload or receive-side scaling (RSS).
>     >     >  These capabilities would be viewed as a gate-level "tax" on
>     >     > @@ -303,6 +307,18 @@ ARK PMD supports the following Arkville RTL
>     >     PCIe instances including:
>     >     >  * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for
>     >     Agilex R-Tile]
>     >     >  * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
>     >     > 
>     >     > +Arkville RTL Core Configurations
>     >     > +-------------------------------------
>     >     > +
>     >
>     >     The title marker length (-) should be same as title length,
>     can you
>     >     please fix if there will be next version, if not I can fix while
>     >     merging.
>     >
>     >
>     >     > +Arkville's RTL core may be configured by the user with
>     different
>     >     > +datapath widths to balance throughput against FPGA logic area.
>     >     The ARK PMD
>     >     > +has introspection on the RTL core configuration and acts
>     accordingly.
>     >     > +All Arkville configurations present identical RTL
>     user-facing AXI
>     >     stream
>     >     > +interfaces for both AMD/Xilinx and Intel FPGAs.
>     >     > +
>     >     > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
>     >     > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
>     >     > +
>     >     >  DPDK and Arkville Firmware Versioning
>     >     >  -------------------------------------
>     >     > 
>     >     > @@ -334,6 +350,8 @@ Supported Features
>     >     >  ------------------
>     >     > 
>     >     >  * Dynamic ARK PMD extensions
>     >     > +* Dynamic per-queue MBUF (re)sizing up to 32KB
>     >
>     >     What is this feature? What does it mean to size/resize mbuf
>     dynamically?
>     >
>     >     > +* SR-IOV, VF-based queue-segregation
>     >     >  * Multiple receive and transmit queues
>     >     >  * Jumbo frames up to 9K
>     >     >  * Hardware Statistics
>     >
> 

[PATCH 1/2] doc: clarify the existing net/ark guide

[Shepard Siegel]

Add detail for the existing Arkville configurations FX0 and FX1.
Corrected minor errors of omission.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index ba00f14e80..14fedbf252 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -52,6 +52,10 @@ board. While specific capabilities such as number of physical
 hardware queue-pairs are negotiated; the driver is designed to
 remain constant over a broad and extendable feature set.
 
+* FPGA Vendors Supported: AMD/Xilinx and Intel
+* Number of RX/TX Queue-Pairs: up to 128
+* PCIe Endpoint Technology: Gen3, Gen4, Gen5
+
 Intentionally, Arkville by itself DOES NOT provide common NIC
 capabilities such as offload or receive-side scaling (RSS).
 These capabilities would be viewed as a gate-level "tax" on
@@ -73,7 +77,7 @@ between the user's FPGA application and the existing DPDK features via
 the PMD.
 
 Device Parameters
--------------------
+-----------------
 
 The ARK PMD supports device parameters that are used for packet
 routing and for internal packet generation and packet checking.  This
@@ -303,6 +307,18 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
 
+Arkville RTL Core Configurations
+--------------------------------
+
+Arkville's RTL core may be configured by the user with different
+datapath widths to balance throughput against FPGA logic area. The ARK PMD
+has introspection on the RTL core configuration and acts accordingly.
+All Arkville configurations present identical RTL user-facing AXI stream
+interfaces for both AMD/Xilinx and Intel FPGAs.
+
+* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
+* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+
 DPDK and Arkville Firmware Versioning
 -------------------------------------
 
@@ -334,6 +350,8 @@ Supported Features
 ------------------
 
 * Dynamic ARK PMD extensions
+* Dynamic per-queue MBUF (re)sizing up to 32KB
+* SR-IOV, VF-based queue-segregation
 * Multiple receive and transmit queues
 * Jumbo frames up to 9K
 * Hardware Statistics
-- 
2.25.1

[PATCH 2/2] net/ark: add new ark PCIe device

[Shepard Siegel]

This patch adds the Arkville FX2 to known PCIe device list
Update documentation and release notes.

Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
---
 doc/guides/nics/ark.rst                | 3 ++-
 doc/guides/rel_notes/release_23_03.rst | 4 ++++
 drivers/net/ark/ark_ethdev.c           | 1 +
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
index 14fedbf252..81a37c161f 100644
--- a/doc/guides/nics/ark.rst
+++ b/doc/guides/nics/ark.rst
@@ -306,6 +306,7 @@ ARK PMD supports the following Arkville RTL PCIe instances including:
 * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function]
 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex R-Tile]
 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
+* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex]
 
 Arkville RTL Core Configurations
 --------------------------------
@@ -318,6 +319,7 @@ interfaces for both AMD/Xilinx and Intel FPGAs.
 
 * ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
 * ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
+* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
 
 DPDK and Arkville Firmware Versioning
 -------------------------------------
@@ -350,7 +352,6 @@ Supported Features
 ------------------
 
 * Dynamic ARK PMD extensions
-* Dynamic per-queue MBUF (re)sizing up to 32KB
 * SR-IOV, VF-based queue-segregation
 * Multiple receive and transmit queues
 * Jumbo frames up to 9K
diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst
index 7527c6d57f..7941b22c8a 100644
--- a/doc/guides/rel_notes/release_23_03.rst
+++ b/doc/guides/rel_notes/release_23_03.rst
@@ -72,6 +72,10 @@ New Features
 
   * Added multi-process support.
 
+* **Updated Atomic Rules ark driver.**
+
+  * Added Arkville FX2 device supporting PCIe Gen5x16
+
 * **Updated Corigine nfp driver.**
 
   * Added support for meter options.
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c654a229f7..b2995427c8 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -99,6 +99,7 @@ static const struct rte_pci_id pci_id_ark_map[] = {
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101c)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101e)},
 	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x101f)},
+	{RTE_PCI_DEVICE(AR_VENDOR_ID, 0x1022)},
 	{.vendor_id = 0, /* sentinel */ },
 };
 
-- 
2.25.1

Re: [PATCH 2/2] net/ark: add new ark PCIe device

[Ferruh Yigit]

On 2/13/2023 7:58 PM, Shepard Siegel wrote:
> @@ -350,7 +352,6 @@ Supported Features
>  ------------------
>  
>  * Dynamic ARK PMD extensions
> -* Dynamic per-queue MBUF (re)sizing up to 32KB

Keeping feature based on discussion in previous version.

Re: [PATCH 1/2] doc: clarify the existing net/ark guide

[Ferruh Yigit]

On 2/13/2023 7:58 PM, Shepard Siegel wrote:
> Add detail for the existing Arkville configurations FX0 and FX1.
> Corrected minor errors of omission.
> 
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>


Series applied to dpdk-next-net/main, thanks.