* [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled
@ 2023-11-16 17:16 Mayuresh Chitale
2023-11-16 18:33 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mayuresh Chitale @ 2023-11-16 17:16 UTC (permalink / raw)
To: Ilias Apalodimas, Leo Yu-Chi Liang, Marek Vasut, Shengyu Qu,
Sean Anderson
Cc: Mayuresh Chitale, Simon Glass, u-boot, Tom Rini
If FS_LOADER is enabled for the SPL then the build fails with the error:
fs/fs.o:(.data.rel.fstypes+0x128):
undefined reference to `smh_fs_set_blk_dev'
fs/fs.o:(.data.rel.fstypes+0x140):
undefined reference to `smh_fs_size'
fs/fs.o:(.data.rel.fstypes+0x148):
undefined reference to `smh_fs_read'
fs/fs.o:(.data.rel.fstypes+0x150):
undefined reference to `smh_fs_write'
Fix the error by populating the semihosting entry in the fs_types array
only for non-SPL builds.
Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
---
Changes in v2:
- Use CONFIG_IS_ENABLED instead of CONFIG_SPL_BUILD
fs/fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs.c b/fs/fs.c
index 4cb4310c9c..5c27ae2fe1 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -256,7 +256,7 @@ static struct fstype_info fstypes[] = {
.ln = fs_ln_unsupported,
},
#endif
-#ifdef CONFIG_SEMIHOSTING
+#if CONFIG_IS_ENABLED(SEMIHOSTING)
{
.fstype = FS_TYPE_SEMIHOSTING,
.name = "semihosting",
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled
2023-11-16 17:16 [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled Mayuresh Chitale
@ 2023-11-16 18:33 ` Tom Rini
2023-11-16 18:39 ` Sean Anderson
2023-12-21 21:06 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-11-16 18:33 UTC (permalink / raw)
To: Mayuresh Chitale
Cc: Ilias Apalodimas, Leo Yu-Chi Liang, Marek Vasut, Shengyu Qu,
Sean Anderson, Simon Glass, u-boot
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
On Thu, Nov 16, 2023 at 10:46:12PM +0530, Mayuresh Chitale wrote:
> If FS_LOADER is enabled for the SPL then the build fails with the error:
>
> fs/fs.o:(.data.rel.fstypes+0x128):
> undefined reference to `smh_fs_set_blk_dev'
> fs/fs.o:(.data.rel.fstypes+0x140):
> undefined reference to `smh_fs_size'
> fs/fs.o:(.data.rel.fstypes+0x148):
> undefined reference to `smh_fs_read'
> fs/fs.o:(.data.rel.fstypes+0x150):
> undefined reference to `smh_fs_write'
>
> Fix the error by populating the semihosting entry in the fs_types array
> only for non-SPL builds.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled
2023-11-16 17:16 [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled Mayuresh Chitale
2023-11-16 18:33 ` Tom Rini
@ 2023-11-16 18:39 ` Sean Anderson
2023-12-21 21:06 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Sean Anderson @ 2023-11-16 18:39 UTC (permalink / raw)
To: Mayuresh Chitale, Ilias Apalodimas, Leo Yu-Chi Liang, Marek Vasut,
Shengyu Qu
Cc: Simon Glass, u-boot, Tom Rini
On 11/16/23 12:16, Mayuresh Chitale wrote:
> If FS_LOADER is enabled for the SPL then the build fails with the error:
>
> fs/fs.o:(.data.rel.fstypes+0x128):
> undefined reference to `smh_fs_set_blk_dev'
> fs/fs.o:(.data.rel.fstypes+0x140):
> undefined reference to `smh_fs_size'
> fs/fs.o:(.data.rel.fstypes+0x148):
> undefined reference to `smh_fs_read'
> fs/fs.o:(.data.rel.fstypes+0x150):
> undefined reference to `smh_fs_write'
>
> Fix the error by populating the semihosting entry in the fs_types array
> only for non-SPL builds.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> ---
> Changes in v2:
> - Use CONFIG_IS_ENABLED instead of CONFIG_SPL_BUILD
>
> fs/fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fs.c b/fs/fs.c
> index 4cb4310c9c..5c27ae2fe1 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -256,7 +256,7 @@ static struct fstype_info fstypes[] = {
> .ln = fs_ln_unsupported,
> },
> #endif
> -#ifdef CONFIG_SEMIHOSTING
> +#if CONFIG_IS_ENABLED(SEMIHOSTING)
> {
> .fstype = FS_TYPE_SEMIHOSTING,
> .name = "semihosting",
Reviewed-by: Sean Anderson <seanga2@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled
2023-11-16 17:16 [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled Mayuresh Chitale
2023-11-16 18:33 ` Tom Rini
2023-11-16 18:39 ` Sean Anderson
@ 2023-12-21 21:06 ` Tom Rini
2 siblings, 0 replies; 4+ messages in thread
From: Tom Rini @ 2023-12-21 21:06 UTC (permalink / raw)
To: Mayuresh Chitale
Cc: Ilias Apalodimas, Leo Yu-Chi Liang, Marek Vasut, Shengyu Qu,
Sean Anderson, Simon Glass, u-boot
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Thu, Nov 16, 2023 at 10:46:12PM +0530, Mayuresh Chitale wrote:
> If FS_LOADER is enabled for the SPL then the build fails with the error:
>
> fs/fs.o:(.data.rel.fstypes+0x128):
> undefined reference to `smh_fs_set_blk_dev'
> fs/fs.o:(.data.rel.fstypes+0x140):
> undefined reference to `smh_fs_size'
> fs/fs.o:(.data.rel.fstypes+0x148):
> undefined reference to `smh_fs_read'
> fs/fs.o:(.data.rel.fstypes+0x150):
> undefined reference to `smh_fs_write'
>
> Fix the error by populating the semihosting entry in the fs_types array
> only for non-SPL builds.
>
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-21 21:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-16 17:16 [PATCH v2] fs: Fix SPL build if FS_LOADER is enabled Mayuresh Chitale
2023-11-16 18:33 ` Tom Rini
2023-11-16 18:39 ` Sean Anderson
2023-12-21 21:06 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.