From: Phillip Wood <phillip.wood123@gmail.com>
To: redoste <redoste@redoste.xyz>, Phillip Wood <phillip.wood@dunelm.org.uk>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Fabian Stelzer <fs@gigacodes.de>,
Junio C Hamano <gitster@pobox.com>,
Elijah Newren <newren@gmail.com>, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] ssh signing: don't detach the filename strbuf from key_file tempfile
Date: Mon, 7 Jul 2025 17:42:00 +0100 [thread overview]
Message-ID: <2ae656ee-cf3e-42a7-815a-016df23ac051@gmail.com> (raw)
In-Reply-To: <DB5YM57RVQTT.35ZS2BA5SHY@redoste.xyz>
On 07/07/2025 17:22, redoste wrote:
> On Mon Jul 7, 2025 at 17:26 CEST, Phillip Wood wrote:
>> test_file_is_empty will print a diagnostic message if it fails so it
>> should be clear what has caused the test failure
> Uh, okay, this makes sense and I think it will be clear enough.
> However there is only `test_file_not_empty`, `test_file_is_empty`
> doesn't exist. I will implement it in an other commit.
Sorry I'd misremembered the name, it is "test_must_be_empty"
Phillip
>> The way I see it is that the changes that are being tested are related
>> to commit signing as the invariant that we want to assert is that
>> temporary files are cleaned up after signing commits.
> I see.
>
> I will update this for a v3.
> Thanks for the feedback!
>
next prev parent reply other threads:[~2025-07-07 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 23:08 [PATCH] ssh signing: don't detach the filename strbuf from key_file tempfile redoste
2025-07-05 19:21 ` Jeff King
2025-07-05 20:07 ` brian m. carlson
2025-07-05 22:50 ` redoste
2025-07-05 23:04 ` redoste
2025-07-06 0:28 ` brian m. carlson
2025-07-06 3:13 ` Jeff King
2025-07-06 17:20 ` redoste
2025-07-06 17:14 ` redoste
2025-07-06 17:34 ` [PATCH v2] " redoste
2025-07-06 21:21 ` brian m. carlson
2025-07-07 9:02 ` Patrick Steinhardt
2025-07-07 9:35 ` Phillip Wood
2025-07-07 14:25 ` redoste
2025-07-07 15:26 ` Phillip Wood
2025-07-07 16:22 ` redoste
2025-07-07 16:42 ` Phillip Wood [this message]
2025-07-07 18:48 ` [PATCH v3] " redoste
2025-07-07 20:57 ` Junio C Hamano
2025-07-08 6:47 ` Patrick Steinhardt
2025-07-08 13:59 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ae656ee-cf3e-42a7-815a-016df23ac051@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=redoste@redoste.xyz \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.