From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: redoste <redoste@redoste.xyz>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Fabian Stelzer <fs@gigacodes.de>,
Junio C Hamano <gitster@pobox.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH v2] ssh signing: don't detach the filename strbuf from key_file tempfile
Date: Sun, 6 Jul 2025 21:21:30 +0000 [thread overview]
Message-ID: <aGro2h1VsSEYYCmp@fruit.crustytoothpaste.net> (raw)
In-Reply-To: <20250706173450.12995-1-redoste@redoste.xyz>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On 2025-07-06 at 17:34:49, redoste wrote:
> Detaching the filename string from the tempfile structure used to cause
> delete_tempfile() to fail and the temporary file was not cleaned up.
>
> While it's possible to get rid of the allocation and copy from
> xstrdup(), it keeps the code symetric with the other branch since
> interpolate_path() also allocates and ssh_signing_key_file is freed
> in both cases.
>
> Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
> Signed-off-by: redoste <redoste@redoste.xyz>
Yup, this looks good to me. Thanks so much for the patch; I always
appreciate keeping the temporary directory tidy.
--
brian m. carlson (they/them)
Toronto, Ontario, CA
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2025-07-06 21:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 23:08 [PATCH] ssh signing: don't detach the filename strbuf from key_file tempfile redoste
2025-07-05 19:21 ` Jeff King
2025-07-05 20:07 ` brian m. carlson
2025-07-05 22:50 ` redoste
2025-07-05 23:04 ` redoste
2025-07-06 0:28 ` brian m. carlson
2025-07-06 3:13 ` Jeff King
2025-07-06 17:20 ` redoste
2025-07-06 17:14 ` redoste
2025-07-06 17:34 ` [PATCH v2] " redoste
2025-07-06 21:21 ` brian m. carlson [this message]
2025-07-07 9:02 ` Patrick Steinhardt
2025-07-07 9:35 ` Phillip Wood
2025-07-07 14:25 ` redoste
2025-07-07 15:26 ` Phillip Wood
2025-07-07 16:22 ` redoste
2025-07-07 16:42 ` Phillip Wood
2025-07-07 18:48 ` [PATCH v3] " redoste
2025-07-07 20:57 ` Junio C Hamano
2025-07-08 6:47 ` Patrick Steinhardt
2025-07-08 13:59 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGro2h1VsSEYYCmp@fruit.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=redoste@redoste.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.