All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Pascal Paillet <p.paillet@foss.st.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 1/3] dt-bindings: regulator: st,stm32mp1-pwr-reg: add correct compatible
Date: Thu, 25 Apr 2024 10:52:08 +0200	[thread overview]
Message-ID: <2b78be92-08a5-4bf8-a1e1-477ecbbe73da@kernel.org> (raw)
In-Reply-To: <20240425094829.1.Ia0a99d90acb512aa020a6e7a8cca8cc1b71f1759@changeid>

On 25/04/2024 09:48, Patrick Delaunay wrote:
> Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg"
> and define the new compatible "st,stm32mp1-pwr-reg".
> The old compatible is only keep for compatibility with old device trees.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml  | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
> index c9586d277f41..2a52f9e769c2 100644
> --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
> +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
> @@ -11,7 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: st,stm32mp1,pwr-reg
> +    enum:
> +      - st,stm32mp1-pwr-reg
> +      - st,stm32mp1,pwr-reg

Please make it oneOf:
 - const: new one
 - const: old one
   deprecated: true

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Patrick Delaunay <patrick.delaunay@foss.st.com>,
	Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Pascal Paillet <p.paillet@foss.st.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 1/3] dt-bindings: regulator: st,stm32mp1-pwr-reg: add correct compatible
Date: Thu, 25 Apr 2024 10:52:08 +0200	[thread overview]
Message-ID: <2b78be92-08a5-4bf8-a1e1-477ecbbe73da@kernel.org> (raw)
In-Reply-To: <20240425094829.1.Ia0a99d90acb512aa020a6e7a8cca8cc1b71f1759@changeid>

On 25/04/2024 09:48, Patrick Delaunay wrote:
> Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg"
> and define the new compatible "st,stm32mp1-pwr-reg".
> The old compatible is only keep for compatibility with old device trees.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> ---
> 
>  .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml  | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
> index c9586d277f41..2a52f9e769c2 100644
> --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
> +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml
> @@ -11,7 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: st,stm32mp1,pwr-reg
> +    enum:
> +      - st,stm32mp1-pwr-reg
> +      - st,stm32mp1,pwr-reg

Please make it oneOf:
 - const: new one
 - const: old one
   deprecated: true

Best regards,
Krzysztof


  reply	other threads:[~2024-04-25  8:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-25  7:48 [PATCH 0/3] ARM: st: use a correct pwr compatible for stm32mp15 Patrick Delaunay
2024-04-25  7:48 ` Patrick Delaunay
2024-04-25  7:48 ` [PATCH 1/3] dt-bindings: regulator: st,stm32mp1-pwr-reg: add correct compatible Patrick Delaunay
2024-04-25  7:48   ` Patrick Delaunay
2024-04-25  8:52   ` Krzysztof Kozlowski [this message]
2024-04-25  8:52     ` Krzysztof Kozlowski
2024-04-25 13:55     ` Patrick DELAUNAY
2024-04-25 13:55       ` Patrick DELAUNAY
2024-04-25  7:48 ` [PATCH 2/3] regulator: stm32-pwr: add support of " Patrick Delaunay
2024-04-25  7:48   ` Patrick Delaunay
2024-04-25  7:48 ` [PATCH 3/3] ARM: dts: st: update the pwr compatible for stm32mp15 Patrick Delaunay
2024-04-25  7:48   ` Patrick Delaunay
2024-04-25  8:57   ` Krzysztof Kozlowski
2024-04-25  8:57     ` Krzysztof Kozlowski
2024-04-25 13:54     ` Patrick DELAUNAY
2024-04-25 13:54       ` Patrick DELAUNAY
2024-04-25 16:30 ` [PATCH 0/3] ARM: st: use a correct " Rob Herring
2024-04-25 16:30   ` Rob Herring
2024-04-26 11:41   ` Patrick DELAUNAY
2024-04-26 11:41     ` Patrick DELAUNAY
2024-04-26 12:51     ` Rob Herring
2024-04-26 12:51       ` Rob Herring
2024-04-26 14:28       ` Patrick DELAUNAY
2024-04-26 14:28         ` Patrick DELAUNAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b78be92-08a5-4bf8-a1e1-477ecbbe73da@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=p.paillet@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.