From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>,
Yong Liang <yong.liang@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
linux-watchdog@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux@roeck-us.net, wim@linux-watchdog.org,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
Date: Fri, 10 Jan 2020 11:09:56 +0100 [thread overview]
Message-ID: <2bbd8f47-fe68-574c-cbe9-bcc680dd4c84@gmail.com> (raw)
In-Reply-To: <CANMq1KB4PzAUdp03go0Ur_khi2bM3+oNUhHtMK=--V6DmGXiDA@mail.gmail.com>
On 08/01/2020 10:14, Nicolas Boichat wrote:
> On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>>
>> minor nit, s/amr64/arm64/ in the commit title.
>>
>> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
>>>
>>> From: "yong.liang" <yong.liang@mediatek.com>
>>>
>>> 1. Include mt8183-reset.h and add reset-cells in infracfg
>>> in dtsi file
>
> Err, wait, doesn't this depend on
> http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> ?
>
That's all a bit confusing, I thought we are fine to add the reset cells to
infracfg as we have the resets defined in
64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
That's why I took this part from:
https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
Please let me know if I'm wrong and I'll drop it.
Regards,
Matthias
>>> 2. Add watchdog device node
>
> Can we have a patch with just this change instead, since you're
> sending the binding with it.
>
>>>
>>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>>
>> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>> [snip]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>,
Yong Liang <yong.liang@mediatek.com>
Cc: linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
wim@linux-watchdog.org, linux@roeck-us.net,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
Date: Fri, 10 Jan 2020 11:09:56 +0100 [thread overview]
Message-ID: <2bbd8f47-fe68-574c-cbe9-bcc680dd4c84@gmail.com> (raw)
In-Reply-To: <CANMq1KB4PzAUdp03go0Ur_khi2bM3+oNUhHtMK=--V6DmGXiDA@mail.gmail.com>
On 08/01/2020 10:14, Nicolas Boichat wrote:
> On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>>
>> minor nit, s/amr64/arm64/ in the commit title.
>>
>> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
>>>
>>> From: "yong.liang" <yong.liang@mediatek.com>
>>>
>>> 1. Include mt8183-reset.h and add reset-cells in infracfg
>>> in dtsi file
>
> Err, wait, doesn't this depend on
> http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> ?
>
That's all a bit confusing, I thought we are fine to add the reset cells to
infracfg as we have the resets defined in
64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
That's why I took this part from:
https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
Please let me know if I'm wrong and I'll drop it.
Regards,
Matthias
>>> 2. Add watchdog device node
>
> Can we have a patch with just this change instead, since you're
> sending the binding with it.
>
>>>
>>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>>
>> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>> [snip]
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Nicolas Boichat <drinkcat@chromium.org>,
Yong Liang <yong.liang@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Devicetree List <devicetree@vger.kernel.org>,
linux-watchdog@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux@roeck-us.net, wim@linux-watchdog.org,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi
Date: Fri, 10 Jan 2020 11:09:56 +0100 [thread overview]
Message-ID: <2bbd8f47-fe68-574c-cbe9-bcc680dd4c84@gmail.com> (raw)
In-Reply-To: <CANMq1KB4PzAUdp03go0Ur_khi2bM3+oNUhHtMK=--V6DmGXiDA@mail.gmail.com>
On 08/01/2020 10:14, Nicolas Boichat wrote:
> On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>>
>> minor nit, s/amr64/arm64/ in the commit title.
>>
>> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@mediatek.com> wrote:
>>>
>>> From: "yong.liang" <yong.liang@mediatek.com>
>>>
>>> 1. Include mt8183-reset.h and add reset-cells in infracfg
>>> in dtsi file
>
> Err, wait, doesn't this depend on
> http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> ?
>
That's all a bit confusing, I thought we are fine to add the reset cells to
infracfg as we have the resets defined in
64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
That's why I took this part from:
https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
Please let me know if I'm wrong and I'll drop it.
Regards,
Matthias
>>> 2. Add watchdog device node
>
> Can we have a patch with just this change instead, since you're
> sending the binding with it.
>
>>>
>>> Signed-off-by: yong.liang <yong.liang@mediatek.com>
>>
>> Tested-by: Nicolas Boichat <drinkcat@chromium.org>
>>
>>> ---
>>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>> [snip]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-10 10:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 14:14 [PATCH v3 0/2] Add watchdog node and dt-binding Yong Liang
2019-12-27 14:14 ` Yong Liang
2019-12-27 14:14 ` [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi Yong Liang
2019-12-27 14:14 ` Yong Liang
2020-01-08 8:56 ` Nicolas Boichat
2020-01-08 8:56 ` Nicolas Boichat
2020-01-08 8:56 ` Nicolas Boichat
2020-01-08 9:14 ` Nicolas Boichat
2020-01-08 9:14 ` Nicolas Boichat
2020-01-08 9:14 ` Nicolas Boichat
2020-01-09 3:59 ` Yong Liang
2020-01-09 3:59 ` Yong Liang
2020-01-09 3:59 ` Yong Liang
2020-01-10 10:09 ` Matthias Brugger [this message]
2020-01-10 10:09 ` Matthias Brugger
2020-01-10 10:09 ` Matthias Brugger
2020-01-13 4:44 ` Nicolas Boichat
2020-01-13 4:44 ` Nicolas Boichat
2020-01-13 4:44 ` Nicolas Boichat
2020-01-13 6:27 ` Nicolas Boichat
2020-01-13 6:27 ` Nicolas Boichat
2020-01-13 6:27 ` Nicolas Boichat
2020-01-13 9:41 ` Yong Liang
2020-01-13 9:41 ` Yong Liang
2020-01-13 9:41 ` Yong Liang
2019-12-27 14:14 ` [PATCH v3 2/2] dt-bindings: mt8183: Add watchdog dt-binding Yong Liang
2019-12-27 14:14 ` Yong Liang
2020-01-08 8:57 ` Nicolas Boichat
2020-01-08 8:57 ` Nicolas Boichat
2020-01-08 8:57 ` Nicolas Boichat
2020-01-08 10:59 ` Matthias Brugger
2020-01-08 10:59 ` Matthias Brugger
2020-01-08 10:59 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bbd8f47-fe68-574c-cbe9-bcc680dd4c84@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yong.liang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.