From: Stefano Stabellini <sstabellini@kernel.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Stefano Stabellini" <stefano.stabellini@amd.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger@xenproject.org>,
"Teddy Astie" <teddy.astie@vates.tech>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] x86/vlapic: accept a logical destination of all ones as a broadcast
Date: Thu, 19 Nov 2026 13:26:01 -0800 (PST) [thread overview]
Message-ID: <2bc00e72-edca-29b1-1dcb-229fd618bcfd@kernel.org> (raw)
In-Reply-To: <8dade36e-0051-4ecb-8f49-07a156dd8b90@suse.com>
[-- Attachment #1: Type: text/plain, Size: 2939 bytes --]
On Thu, 19 Nov 2026, Jan Beulich wrote:
> On 18.11.2026 00:36, Stefano Stabellini wrote:
> > In logical destination mode, a destination of all ones is a broadcast
> > accepted by every local APIC: 0xff in xAPIC mode, in both the flat and
> > the cluster model (AMD APM vol. 2, "Receiving System and IPI
> > Interrupts"), and 0xffffffff in x2APIC mode (AMD APM vol. 2, "x2APIC
> > Interrupt Command Register (ICR) Operations").
> >
> > vlapic_match_logical_addr() treated these as ordinary logical
> > destinations, so a broadcast reached only the vLAPICs whose logical ID
> > happened to match it. In particular, a vLAPIC whose logical ID is 0
> > received no logical broadcast at all.
> >
> > Check for the broadcast in vlapic_match_dest() before telling the two
> > destination modes apart, as was already done for physical destinations.
> > A vLAPIC whose destination format register names neither model now
> > also accepts the broadcast.
> >
> > Fixes: f9e0cccf7b35 ("x86/HVM: fix ID handling of x2APIC emulation")
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
> > ---
> > CC: Jan Beulich <jbeulich@suse.com>,
> > CC: Andrew Cooper <andrew.cooper3@citrix.com>,
> > CC: Roger Pau Monné <roger@xenproject.org>,
> > CC: Teddy Astie <teddy.astie@vates.tech>
> >
> > v2:
> > - Check for the broadcast once in vlapic_match_dest(), before the two
> > destination modes are told apart, rather than in each model of
> > vlapic_match_logical_addr() (Jan). As a result, a logical broadcast
> > now also matches a vLAPIC whose DFR names neither model.
> > - Cite the AMD APM by section title (Jan).
> > - Add Fixes: tags.
> >
> > xen/arch/x86/hvm/vlapic.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
> > index 6698779e22..50b515d254 100644
> > --- a/xen/arch/x86/hvm/vlapic.c
> > +++ b/xen/arch/x86/hvm/vlapic.c
> > @@ -247,10 +247,12 @@ bool vlapic_match_dest(
> > switch ( short_hand )
> > {
> > case APIC_DEST_NOSHORT:
> > + /* All ones is a broadcast in either destination mode. */
> > + if ( dest == _VLAPIC_ID(target, 0xffffffffU) )
>
> Turns out a very similar patch (referencing the SDM rather than the APM)
> was sent before, and Andrew pointed out an issue there [1]: This needs to
> use the sender, not the receiver, to determine whether broadcast is meant.
>
> Jan
>
> [1] https://lore.kernel.org/xen-devel/95e0e0fb-2978-4c87-b723-fb7c30f36883@citrix.com/
I'll send out a new patch to address this
> > + return true;
> > if ( dest_mode )
> > return vlapic_match_logical_addr(target, dest);
> > - return (dest == _VLAPIC_ID(target, 0xffffffffU)) ||
> > - (dest == VLAPIC_ID(target));
> > + return dest == VLAPIC_ID(target);
> >
> > case APIC_DEST_SELF:
> > return (target == source);
>
prev parent reply other threads:[~2026-11-19 21:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 23:36 [PATCH v2] x86/vlapic: accept a logical destination of all ones as a broadcast Stefano Stabellini
2026-11-18 8:46 ` Jan Beulich
2026-11-18 9:31 ` Teddy Astie
2026-11-19 9:52 ` Jan Beulich
2026-11-19 21:26 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bc00e72-edca-29b1-1dcb-229fd618bcfd@kernel.org \
--to=sstabellini@kernel.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger@xenproject.org \
--cc=stefano.stabellini@amd.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.