All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] x86/vlapic: accept a logical destination of all ones as a broadcast
@ 2026-11-17 23:36 Stefano Stabellini
  2026-11-18  8:46 ` Jan Beulich
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Stefano Stabellini @ 2026-11-17 23:36 UTC (permalink / raw)
  To: xen-devel
  Cc: stefano.stabellini, Jan Beulich, Andrew Cooper,
	Roger Pau Monné, Teddy Astie

In logical destination mode, a destination of all ones is a broadcast
accepted by every local APIC: 0xff in xAPIC mode, in both the flat and
the cluster model (AMD APM vol. 2, "Receiving System and IPI
Interrupts"), and 0xffffffff in x2APIC mode (AMD APM vol. 2, "x2APIC
Interrupt Command Register (ICR) Operations").

vlapic_match_logical_addr() treated these as ordinary logical
destinations, so a broadcast reached only the vLAPICs whose logical ID
happened to match it. In particular, a vLAPIC whose logical ID is 0
received no logical broadcast at all.

Check for the broadcast in vlapic_match_dest() before telling the two
destination modes apart, as was already done for physical destinations.
A vLAPIC whose destination format register names neither model now
also accepts the broadcast.

Fixes: f9e0cccf7b35 ("x86/HVM: fix ID handling of x2APIC emulation")
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
CC: Jan Beulich <jbeulich@suse.com>,
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
CC: Roger Pau Monné <roger@xenproject.org>,
CC: Teddy Astie <teddy.astie@vates.tech>

v2:
 - Check for the broadcast once in vlapic_match_dest(), before the two
   destination modes are told apart, rather than in each model of
   vlapic_match_logical_addr() (Jan). As a result, a logical broadcast
   now also matches a vLAPIC whose DFR names neither model.
 - Cite the AMD APM by section title (Jan).
 - Add Fixes: tags.

 xen/arch/x86/hvm/vlapic.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index 6698779e22..50b515d254 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -247,10 +247,12 @@ bool vlapic_match_dest(
     switch ( short_hand )
     {
     case APIC_DEST_NOSHORT:
+        /* All ones is a broadcast in either destination mode. */
+        if ( dest == _VLAPIC_ID(target, 0xffffffffU) )
+            return true;
         if ( dest_mode )
             return vlapic_match_logical_addr(target, dest);
-        return (dest == _VLAPIC_ID(target, 0xffffffffU)) ||
-               (dest == VLAPIC_ID(target));
+        return dest == VLAPIC_ID(target);
 
     case APIC_DEST_SELF:
         return (target == source);
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-19 21:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 23:36 [PATCH v2] x86/vlapic: accept a logical destination of all ones as a broadcast Stefano Stabellini
2026-11-18  8:46 ` Jan Beulich
2026-11-18  9:31 ` Teddy Astie
2026-11-19  9:52 ` Jan Beulich
2026-11-19 21:26   ` Stefano Stabellini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.