All of lore.kernel.org
 help / color / mirror / Atom feed
* [master][PATCH] meta-toolchain: inherit nopackages
@ 2024-09-29 18:55 Atharva Nandanwar
  2024-09-29 21:57 ` [OE-core] " Richard Purdie
  0 siblings, 1 reply; 3+ messages in thread
From: Atharva Nandanwar @ 2024-09-29 18:55 UTC (permalink / raw)
  To: openembedded-core

From: Atharva Nandanwar <atharvanandanwar@outlook.com>

- buildhistory emits hard error when no files are present in
  package-split.
- meta-toolchain doesn't install/package any files, hence inheriting
  nopackages should allow building this recipe again

Signed-off-by: Atharva Nandanwar <atharvanandanwar@outlook.com>
---
 meta/recipes-core/meta/meta-toolchain.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes-core/meta/meta-toolchain.bb
index 260e03934e..c97cc68ad4 100644
--- a/meta/recipes-core/meta/meta-toolchain.bb
+++ b/meta/recipes-core/meta/meta-toolchain.bb
@@ -2,4 +2,4 @@ SUMMARY = "Meta package for building a installable toolchain"
 LICENSE = "MIT"
 
 
-inherit populate_sdk
+inherit nopackages populate_sdk
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [OE-core] [master][PATCH] meta-toolchain: inherit nopackages
  2024-09-29 18:55 [master][PATCH] meta-toolchain: inherit nopackages Atharva Nandanwar
@ 2024-09-29 21:57 ` Richard Purdie
  2024-09-29 22:46   ` Atharva Nandanwar
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2024-09-29 21:57 UTC (permalink / raw)
  To: atharvanandanwar, openembedded-core

On Sun, 2024-09-29 at 13:55 -0500, Atharva Nandanwar via
lists.openembedded.org wrote:
> From: Atharva Nandanwar <atharvanandanwar@outlook.com>
> 
> - buildhistory emits hard error when no files are present in
>   package-split.
> - meta-toolchain doesn't install/package any files, hence inheriting
>   nopackages should allow building this recipe again
> 
> Signed-off-by: Atharva Nandanwar <atharvanandanwar@outlook.com>
> ---
>  meta/recipes-core/meta/meta-toolchain.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes-
> core/meta/meta-toolchain.bb
> index 260e03934e..c97cc68ad4 100644
> --- a/meta/recipes-core/meta/meta-toolchain.bb
> +++ b/meta/recipes-core/meta/meta-toolchain.bb
> @@ -2,4 +2,4 @@ SUMMARY = "Meta package for building a installable
> toolchain"
>  LICENSE = "MIT"
>  
>  
> -inherit populate_sdk
> +inherit nopackages populate_sdk

This shouldn't be needed on master since:

meta/classes-recipe/populate_sdk_base.bbclass

has:

inherit image-postinst-intercepts image-artifact-names nopackages

Cheers,

Richard


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OE-core] [master][PATCH] meta-toolchain: inherit nopackages
  2024-09-29 21:57 ` [OE-core] " Richard Purdie
@ 2024-09-29 22:46   ` Atharva Nandanwar
  0 siblings, 0 replies; 3+ messages in thread
From: Atharva Nandanwar @ 2024-09-29 22:46 UTC (permalink / raw)
  To: Richard Purdie, openembedded-core

On 9/29/24 16:57, Richard Purdie wrote:
> On Sun, 2024-09-29 at 13:55 -0500, Atharva Nandanwar via
> lists.openembedded.org wrote:
>> From: Atharva Nandanwar <atharvanandanwar@outlook.com>
>>
>> - buildhistory emits hard error when no files are present in
>>   package-split.
>> - meta-toolchain doesn't install/package any files, hence inheriting
>>   nopackages should allow building this recipe again
>>
>> Signed-off-by: Atharva Nandanwar <atharvanandanwar@outlook.com>
>> ---
>>  meta/recipes-core/meta/meta-toolchain.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes-
>> core/meta/meta-toolchain.bb
>> index 260e03934e..c97cc68ad4 100644
>> --- a/meta/recipes-core/meta/meta-toolchain.bb
>> +++ b/meta/recipes-core/meta/meta-toolchain.bb
>> @@ -2,4 +2,4 @@ SUMMARY = "Meta package for building a installable
>> toolchain"
>>  LICENSE = "MIT"
>>  
>>  
>> -inherit populate_sdk
>> +inherit nopackages populate_sdk
> This shouldn't be needed on master since:
> 
> meta/classes-recipe/populate_sdk_base.bbclass
> 
> has:
> 
> inherit image-postinst-intercepts image-artifact-names nopackages
> 
> Cheers,
> 
> Richard

That makes sense.

Looks like we need [1] on scarthgap and kirkstone. As the buildhistory patch made it's way onto those branches.

1 - 29ac598c4f754ce5cee59d3360612f661ad02191

Thanks,
--Atharva


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-29 22:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-29 18:55 [master][PATCH] meta-toolchain: inherit nopackages Atharva Nandanwar
2024-09-29 21:57 ` [OE-core] " Richard Purdie
2024-09-29 22:46   ` Atharva Nandanwar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.