All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Drew Fustini <dfustini@tenstorrent.com>,
	linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
	Fu Wei <wefu@redhat.com>, Guo Ren <guoren@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Drew Fustini <drew@pdp7.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: th1520: Fix return value for unknown pin error
Date: Sun, 6 Oct 2024 08:09:34 +0200	[thread overview]
Message-ID: <2be4c920-b4c7-4b7a-ae63-258f2d86df92@web.de> (raw)
In-Reply-To: <20241005-th1520-pinctrl-fixes-v1-2-5c65dffa0d00@tenstorrent.com>

> Fix th1520_pinctrl_dt_node_to_map() to a return value upon an unknown

                                      to return an error code?


> pin error before jumping to free_configs.

…
> +++ b/drivers/pinctrl/pinctrl-th1520.c
> @@ -499,6 +499,7 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
>  				nmaps = rollback;
>  				dev_err(thp->pctl->dev, "%pOFn.%pOFn: unknown pin '%s'\n",
>  					np, child, pinname);
> +				ret = -EINVAL;
>  				goto free_configs;
>  			}
…

Would you dare to support another jump target for this assignment statement?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Drew Fustini <dfustini@tenstorrent.com>,
	linux-gpio@vger.kernel.org, linux-riscv@lists.infradead.org,
	Fu Wei <wefu@redhat.com>, Guo Ren <guoren@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Drew Fustini <drew@pdp7.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] pinctrl: th1520: Fix return value for unknown pin error
Date: Sun, 6 Oct 2024 08:09:34 +0200	[thread overview]
Message-ID: <2be4c920-b4c7-4b7a-ae63-258f2d86df92@web.de> (raw)
In-Reply-To: <20241005-th1520-pinctrl-fixes-v1-2-5c65dffa0d00@tenstorrent.com>

> Fix th1520_pinctrl_dt_node_to_map() to a return value upon an unknown

                                      to return an error code?


> pin error before jumping to free_configs.

…
> +++ b/drivers/pinctrl/pinctrl-th1520.c
> @@ -499,6 +499,7 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
>  				nmaps = rollback;
>  				dev_err(thp->pctl->dev, "%pOFn.%pOFn: unknown pin '%s'\n",
>  					np, child, pinname);
> +				ret = -EINVAL;
>  				goto free_configs;
>  			}
…

Would you dare to support another jump target for this assignment statement?

Regards,
Markus

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2024-10-06  6:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-05 19:35 [PATCH 0/2] pinctrl: th1520: Improve code quality Drew Fustini
2024-10-05 19:35 ` Drew Fustini
2024-10-05 19:35 ` [PATCH 1/2] pinctrl: th1520: Convert to thp->mutex to guarded mutex Drew Fustini
2024-10-05 19:35   ` Drew Fustini
2024-10-05 19:43   ` Christophe JAILLET
2024-10-05 19:43     ` Christophe JAILLET
2024-10-06  0:16     ` Drew Fustini
2024-10-06  0:16       ` Drew Fustini
2024-10-05 19:54   ` Markus Elfring
2024-10-05 19:54     ` Markus Elfring
2024-10-06 20:04   ` kernel test robot
2024-10-06 20:04     ` kernel test robot
2024-10-07 15:41   ` Dan Carpenter
2024-10-07 15:41     ` Dan Carpenter
2024-10-07 16:33     ` Drew Fustini
2024-10-07 16:33       ` Drew Fustini
2024-10-05 19:35 ` [PATCH 2/2] pinctrl: th1520: Fix return value for unknown pin error Drew Fustini
2024-10-05 19:35   ` Drew Fustini
2024-10-06  6:09   ` Markus Elfring [this message]
2024-10-06  6:09     ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2be4c920-b4c7-4b7a-ae63-258f2d86df92@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@linaro.org \
    --cc=dfustini@tenstorrent.com \
    --cc=drew@pdp7.com \
    --cc=guoren@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.