All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <hwentlan-5C7GfCeVMHo@public.gmane.org>
To: Wambui Karuga <wambui-bg2bBxPYEmlRKH5a5HGb4w@public.gmane.org>,
	"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: "airlied-cv59FeDIM0c@public.gmane.org"
	<airlied-cv59FeDIM0c@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	"outreachy-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
	<outreachy-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
	"Deucher,
	Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
	"Koenig,
	Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/radeon: remove assignment for return value
Date: Wed, 23 Oct 2019 15:09:40 +0000	[thread overview]
Message-ID: <2bed3fab-e84d-226d-b552-1ac088fc5d9c@amd.com> (raw)
In-Reply-To: <20191019073242.21652-1-wambui-bg2bBxPYEmlRKH5a5HGb4w@public.gmane.org>

On 2019-10-19 3:32 a.m., Wambui Karuga wrote:
> Remove unnecessary assignment for return value and have the
> function return the required value directly.
> Issue found by coccinelle:
> @@
> local idexpression ret;
> expression e;
> @@
> 
> -ret =
> +return
>      e;
> -return ret;
> 
> Signed-off-by: Wambui Karuga <wambui@karuga.xyz>

Thanks for your patch.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry


> ---
>  drivers/gpu/drm/radeon/cik.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 62eab82a64f9..daff9a2af3be 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -221,9 +221,7 @@ int ci_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = temp & 0x1ff;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /* get temperature in millidegrees */
> @@ -239,9 +237,7 @@ int kv_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = 0;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /*
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <hwentlan@amd.com>
To: Wambui Karuga <wambui@karuga.xyz>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"outreachy-kernel@googlegroups.com"
	<outreachy-kernel@googlegroups.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] drm/radeon: remove assignment for return value
Date: Wed, 23 Oct 2019 15:09:40 +0000	[thread overview]
Message-ID: <2bed3fab-e84d-226d-b552-1ac088fc5d9c@amd.com> (raw)
Message-ID: <20191023150940.v6vFaW-pLFxf34NQKGQdsqnh4o3JqOHQ8wBrH45CGJ0@z> (raw)
In-Reply-To: <20191019073242.21652-1-wambui@karuga.xyz>

On 2019-10-19 3:32 a.m., Wambui Karuga wrote:
> Remove unnecessary assignment for return value and have the
> function return the required value directly.
> Issue found by coccinelle:
> @@
> local idexpression ret;
> expression e;
> @@
> 
> -ret =
> +return
>      e;
> -return ret;
> 
> Signed-off-by: Wambui Karuga <wambui@karuga.xyz>

Thanks for your patch.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry


> ---
>  drivers/gpu/drm/radeon/cik.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 62eab82a64f9..daff9a2af3be 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -221,9 +221,7 @@ int ci_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = temp & 0x1ff;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /* get temperature in millidegrees */
> @@ -239,9 +237,7 @@ int kv_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = 0;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /*
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <hwentlan@amd.com>
To: Wambui Karuga <wambui@karuga.xyz>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"outreachy-kernel@googlegroups.com"
	<outreachy-kernel@googlegroups.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] drm/radeon: remove assignment for return value
Date: Wed, 23 Oct 2019 15:09:40 +0000	[thread overview]
Message-ID: <2bed3fab-e84d-226d-b552-1ac088fc5d9c@amd.com> (raw)
In-Reply-To: <20191019073242.21652-1-wambui@karuga.xyz>

On 2019-10-19 3:32 a.m., Wambui Karuga wrote:
> Remove unnecessary assignment for return value and have the
> function return the required value directly.
> Issue found by coccinelle:
> @@
> local idexpression ret;
> expression e;
> @@
> 
> -ret =
> +return
>      e;
> -return ret;
> 
> Signed-off-by: Wambui Karuga <wambui@karuga.xyz>

Thanks for your patch.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry


> ---
>  drivers/gpu/drm/radeon/cik.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 62eab82a64f9..daff9a2af3be 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -221,9 +221,7 @@ int ci_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = temp & 0x1ff;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /* get temperature in millidegrees */
> @@ -239,9 +237,7 @@ int kv_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = 0;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /*
> 

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <hwentlan@amd.com>
To: Wambui Karuga <wambui@karuga.xyz>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"outreachy-kernel@googlegroups.com"
	<outreachy-kernel@googlegroups.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] drm/radeon: remove assignment for return value
Date: Wed, 23 Oct 2019 15:09:40 +0000	[thread overview]
Message-ID: <2bed3fab-e84d-226d-b552-1ac088fc5d9c@amd.com> (raw)
Message-ID: <20191023150940.Z9W1-crRvf4UiOkfWqdJowaGtTwC_cQKeOaYNO7VwzU@z> (raw)
In-Reply-To: <20191019073242.21652-1-wambui@karuga.xyz>

On 2019-10-19 3:32 a.m., Wambui Karuga wrote:
> Remove unnecessary assignment for return value and have the
> function return the required value directly.
> Issue found by coccinelle:
> @@
> local idexpression ret;
> expression e;
> @@
> 
> -ret =
> +return
>      e;
> -return ret;
> 
> Signed-off-by: Wambui Karuga <wambui@karuga.xyz>

Thanks for your patch.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry


> ---
>  drivers/gpu/drm/radeon/cik.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c
> index 62eab82a64f9..daff9a2af3be 100644
> --- a/drivers/gpu/drm/radeon/cik.c
> +++ b/drivers/gpu/drm/radeon/cik.c
> @@ -221,9 +221,7 @@ int ci_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = temp & 0x1ff;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /* get temperature in millidegrees */
> @@ -239,9 +237,7 @@ int kv_get_temp(struct radeon_device *rdev)
>  	else
>  		actual_temp = 0;
>  
> -	actual_temp = actual_temp * 1000;
> -
> -	return actual_temp;
> +	return actual_temp * 1000;
>  }
>  
>  /*
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-10-23 15:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19  7:32 [PATCH] drm/radeon: remove assignment for return value Wambui Karuga
     [not found] ` <20191019073242.21652-1-wambui-bg2bBxPYEmlRKH5a5HGb4w@public.gmane.org>
2019-10-23 15:09   ` Harry Wentland [this message]
2019-10-23 15:09     ` Harry Wentland
2019-10-23 15:09     ` Harry Wentland
2019-10-23 15:09     ` Harry Wentland
     [not found]     ` <2bed3fab-e84d-226d-b552-1ac088fc5d9c-5C7GfCeVMHo@public.gmane.org>
2019-10-25 19:36       ` Alex Deucher
2019-10-25 19:36         ` Alex Deucher
2019-10-25 19:36         ` Alex Deucher
2019-10-25 19:36         ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bed3fab-e84d-226d-b552-1ac088fc5d9c@amd.com \
    --to=hwentlan-5c7gfcevmho@public.gmane.org \
    --cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
    --cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=airlied-cv59FeDIM0c@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=outreachy-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=wambui-bg2bBxPYEmlRKH5a5HGb4w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.