From: Krzysztof Kozlowski <krzk@kernel.org>
To: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linuxppc-dev@lists.ozlabs.org,
Philip-Dylan <philip-dylan.gleonec@savoirfairelinux.com>
Subject: Re: [PATCHv5 8/9] arm64: dts: imx8m: update spdif sound card node properties
Date: Sun, 23 Jun 2024 13:10:48 +0200 [thread overview]
Message-ID: <2c32e077-48ef-4d08-99ce-9072a339740c@kernel.org> (raw)
In-Reply-To: <20240620132511.4291-9-elinor.montmasson@savoirfairelinux.com>
On 20/06/2024 15:25, Elinor Montmasson wrote:
> Following merge of imx-spdif driver into fsl-asoc-card:
> * update properties to match those used by fsl-asoc-card.
> * S/PDIF in/out dummy codecs must now be declared explicitly, add and
> use them.
>
> These modifications were tested only on an imx8mn-evk board.
So new DTS will not work on old kernel... Can you at least explain why
this is needed and what benefits this make? You change hardware
description, so whatever you merged in drivers is not really relevant, I
would say.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
imx@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org,
Philip-Dylan <philip-dylan.gleonec@savoirfairelinux.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5 8/9] arm64: dts: imx8m: update spdif sound card node properties
Date: Sun, 23 Jun 2024 13:10:48 +0200 [thread overview]
Message-ID: <2c32e077-48ef-4d08-99ce-9072a339740c@kernel.org> (raw)
In-Reply-To: <20240620132511.4291-9-elinor.montmasson@savoirfairelinux.com>
On 20/06/2024 15:25, Elinor Montmasson wrote:
> Following merge of imx-spdif driver into fsl-asoc-card:
> * update properties to match those used by fsl-asoc-card.
> * S/PDIF in/out dummy codecs must now be declared explicitly, add and
> use them.
>
> These modifications were tested only on an imx8mn-evk board.
So new DTS will not work on old kernel... Can you at least explain why
this is needed and what benefits this make? You change hardware
description, so whatever you merged in drivers is not really relevant, I
would say.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-23 11:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 13:25 [PATCHv5 0/9] ASoC: fsl-asoc-card: add S/PDIF controller Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 1/9] ASoC: fsl-asoc-card: set priv->pdev before using it Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 2/9] ASoC: fsl-asoc-card: add support for dai links with multiple codecs Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 3/9] ASoC: fsl-asoc-card: add second dai link component for codecs Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 4/9] ASoC: fsl-asoc-card: add compatibility to use 2 codecs in dai-links Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 5/9] ASoC: fsl-asoc-card: merge spdif support from imx-spdif.c Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 6/9] ASoC: dt-bindings: fsl-asoc-card: add compatible string for spdif Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-23 11:07 ` Krzysztof Kozlowski
2024-06-23 11:07 ` Krzysztof Kozlowski
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:56 ` Krzysztof Kozlowski
2024-06-24 8:56 ` Krzysztof Kozlowski
2024-06-20 13:25 ` [PATCHv5 7/9] ASoC: dt-bindings: imx-audio-spdif: remove binding Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-23 11:09 ` Krzysztof Kozlowski
2024-06-23 11:09 ` Krzysztof Kozlowski
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:55 ` Krzysztof Kozlowski
2024-06-24 8:55 ` Krzysztof Kozlowski
2024-06-24 9:18 ` Elinor Montmasson
2024-06-24 9:18 ` Elinor Montmasson
2024-06-24 9:24 ` Krzysztof Kozlowski
2024-06-24 9:24 ` Krzysztof Kozlowski
2024-06-20 13:25 ` [PATCHv5 8/9] arm64: dts: imx8m: update spdif sound card node properties Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-23 11:10 ` Krzysztof Kozlowski [this message]
2024-06-23 11:10 ` Krzysztof Kozlowski
2024-06-24 8:51 ` Elinor Montmasson
2024-06-24 8:51 ` Elinor Montmasson
2024-06-20 13:25 ` [PATCHv5 9/9] ARM: dts: imx6: " Elinor Montmasson
2024-06-20 13:25 ` Elinor Montmasson
2024-06-21 0:06 ` (subset) [PATCHv5 0/9] ASoC: fsl-asoc-card: add S/PDIF controller Mark Brown
2024-06-21 0:06 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c32e077-48ef-4d08-99ce-9072a339740c@kernel.org \
--to=krzk@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elinor.montmasson@savoirfairelinux.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=philip-dylan.gleonec@savoirfairelinux.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.