From: Marc Zyngier <maz@kernel.org>
To: David Brazdil <dbrazdil@google.com>
Cc: kernel-team@android.com, kvm@vger.kernel.org,
Will Deacon <will@kernel.org>,
ndesaulniers@google.com, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v2 3/5] KVM: arm64: Patch kimage_voffset instead of loading the EL1 value
Date: Fri, 20 Nov 2020 11:26:37 +0000 [thread overview]
Message-ID: <2c47608f4326c8251ebd940f8ecb99a9@kernel.org> (raw)
In-Reply-To: <20201119111454.vrbogriragp7zukk@google.com>
On 2020-11-19 11:14, David Brazdil wrote:
> Hey Marc,
>
> Just noticed in kvmarm/queue that the whitespacing in this patch is
> off.
>
>> +.macro kimg_pa reg, tmp
>> +alternative_cb kvm_get_kimage_voffset
>> + movz \tmp, #0
>> + movk \tmp, #0, lsl #16
>> + movk \tmp, #0, lsl #32
>> + movk \tmp, #0, lsl #48
>> +alternative_cb_end
>> +
>> + /* reg = __pa(reg) */
>> + sub \reg, \reg, \tmp
>> +.endm
> This uses spaces instead of tabs.
>
>> +
>> #else
> This added empty line actually has a tab in it.
Well spotted. Now fixed.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Brazdil <dbrazdil@google.com>
Cc: kernel-team@android.com, kvm@vger.kernel.org,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Quentin Perret <qperret@google.com>,
ndesaulniers@google.com, James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Alexandru Elisei <alexandru.elisei@arm.com>,
kvmarm@lists.cs.columbia.edu,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Andrew Scull <ascull@google.com>
Subject: Re: [PATCH v2 3/5] KVM: arm64: Patch kimage_voffset instead of loading the EL1 value
Date: Fri, 20 Nov 2020 11:26:37 +0000 [thread overview]
Message-ID: <2c47608f4326c8251ebd940f8ecb99a9@kernel.org> (raw)
In-Reply-To: <20201119111454.vrbogriragp7zukk@google.com>
On 2020-11-19 11:14, David Brazdil wrote:
> Hey Marc,
>
> Just noticed in kvmarm/queue that the whitespacing in this patch is
> off.
>
>> +.macro kimg_pa reg, tmp
>> +alternative_cb kvm_get_kimage_voffset
>> + movz \tmp, #0
>> + movk \tmp, #0, lsl #16
>> + movk \tmp, #0, lsl #32
>> + movk \tmp, #0, lsl #48
>> +alternative_cb_end
>> +
>> + /* reg = __pa(reg) */
>> + sub \reg, \reg, \tmp
>> +.endm
> This uses spaces instead of tabs.
>
>> +
>> #else
> This added empty line actually has a tab in it.
Well spotted. Now fixed.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: David Brazdil <dbrazdil@google.com>
Cc: linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Andrew Scull <ascull@google.com>, Will Deacon <will@kernel.org>,
Quentin Perret <qperret@google.com>,
ndesaulniers@google.com, kernel-team@android.com
Subject: Re: [PATCH v2 3/5] KVM: arm64: Patch kimage_voffset instead of loading the EL1 value
Date: Fri, 20 Nov 2020 11:26:37 +0000 [thread overview]
Message-ID: <2c47608f4326c8251ebd940f8ecb99a9@kernel.org> (raw)
In-Reply-To: <20201119111454.vrbogriragp7zukk@google.com>
On 2020-11-19 11:14, David Brazdil wrote:
> Hey Marc,
>
> Just noticed in kvmarm/queue that the whitespacing in this patch is
> off.
>
>> +.macro kimg_pa reg, tmp
>> +alternative_cb kvm_get_kimage_voffset
>> + movz \tmp, #0
>> + movk \tmp, #0, lsl #16
>> + movk \tmp, #0, lsl #32
>> + movk \tmp, #0, lsl #48
>> +alternative_cb_end
>> +
>> + /* reg = __pa(reg) */
>> + sub \reg, \reg, \tmp
>> +.endm
> This uses spaces instead of tabs.
>
>> +
>> #else
> This added empty line actually has a tab in it.
Well spotted. Now fixed.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-11-20 11:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 17:59 [PATCH v2 0/5] KVM: arm64: Host EL2 entry improvements Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` [PATCH v2 1/5] KVM: arm64: Add kimg_hyp_va() helper Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` [PATCH v2 2/5] KVM: arm64: Turn host HVC handling into a dispatch table Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` [PATCH v2 3/5] KVM: arm64: Patch kimage_voffset instead of loading the EL1 value Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-19 11:14 ` David Brazdil
2020-11-19 11:14 ` David Brazdil
2020-11-19 11:14 ` David Brazdil
2020-11-20 11:26 ` Marc Zyngier [this message]
2020-11-20 11:26 ` Marc Zyngier
2020-11-20 11:26 ` Marc Zyngier
2020-11-09 17:59 ` [PATCH v2 4/5] KVM: arm64: Simplify __kvm_enable_ssbs() Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` [PATCH v2 5/5] KVM: arm64: Avoid repetitive stack access on host EL1 to EL2 exception Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
2020-11-09 17:59 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c47608f4326c8251ebd940f8ecb99a9@kernel.org \
--to=maz@kernel.org \
--cc=dbrazdil@google.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ndesaulniers@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.