* [PATCH 1/4] dt-bindings: power: supply: max17042: add share-irq node
2024-11-09 12:44 [PATCH 0/4] power: supply: max17042: cleanup and more features Dzmitry Sankouski
@ 2024-11-09 12:44 ` Dzmitry Sankouski
2024-11-09 13:49 ` Krzysztof Kozlowski
2024-11-09 14:42 ` Rob Herring (Arm)
2024-11-09 12:44 ` [PATCH 2/4] power: supply: max17042: implement dts shared-irq Dzmitry Sankouski
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Dzmitry Sankouski @ 2024-11-09 12:44 UTC (permalink / raw)
To: Hans de Goede, Krzysztof Kozlowski, Marek Szyprowski,
Sebastian Krzyszkowiak, Purism Kernel Team, Sebastian Reichel,
Rob Herring, Conor Dooley, Alim Akhtar, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, imx, linux-arm-msm, Dzmitry Sankouski
If specified, driver should request irq as shared.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
index 085e2504d0dc..e98ffdad1ec3 100644
--- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
+++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
@@ -59,6 +59,11 @@ properties:
Voltage threshold to report battery as over voltage (in mV).
Default is not to report over-voltage events.
+ shared-irq:
+ description: |
+ Request interrupt as shared.
+ Set in case of other devices using same interrupt pin.
+
power-supplies: true
required:
@@ -79,5 +84,6 @@ examples:
maxim,rsns-microohm = <10000>;
maxim,over-heat-temp = <600>;
maxim,over-volt = <4300>;
+ shared-irq;
};
};
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/4] dt-bindings: power: supply: max17042: add share-irq node
2024-11-09 12:44 ` [PATCH 1/4] dt-bindings: power: supply: max17042: add share-irq node Dzmitry Sankouski
@ 2024-11-09 13:49 ` Krzysztof Kozlowski
2024-11-09 14:42 ` Rob Herring (Arm)
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-09 13:49 UTC (permalink / raw)
To: Dzmitry Sankouski, Hans de Goede, Marek Szyprowski,
Sebastian Krzyszkowiak, Purism Kernel Team, Sebastian Reichel,
Rob Herring, Conor Dooley, Alim Akhtar, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, imx, linux-arm-msm
On 09/11/2024 13:44, Dzmitry Sankouski wrote:
> If specified, driver should request irq as shared.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
> index 085e2504d0dc..e98ffdad1ec3 100644
> --- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
> @@ -59,6 +59,11 @@ properties:
> Voltage threshold to report battery as over voltage (in mV).
> Default is not to report over-voltage events.
>
> + shared-irq:
> + description: |
> + Request interrupt as shared.
> + Set in case of other devices using same interrupt pin.
Why you cannot request shared interrupt always? It's not the property of
this device to know whether its interrupt is shared or not. What if we
add overlay sharing the interrupt? Nope, that's just describing OS behavior.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] dt-bindings: power: supply: max17042: add share-irq node
2024-11-09 12:44 ` [PATCH 1/4] dt-bindings: power: supply: max17042: add share-irq node Dzmitry Sankouski
2024-11-09 13:49 ` Krzysztof Kozlowski
@ 2024-11-09 14:42 ` Rob Herring (Arm)
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring (Arm) @ 2024-11-09 14:42 UTC (permalink / raw)
To: Dzmitry Sankouski
Cc: devicetree, linux-arm-msm, Purism Kernel Team, Sebastian Reichel,
Shawn Guo, linux-pm, linux-arm-kernel, linux-samsung-soc,
linux-kernel, Krzysztof Kozlowski, Sascha Hauer, Bjorn Andersson,
Fabio Estevam, Konrad Dybcio, Conor Dooley, imx, Marek Szyprowski,
Hans de Goede, Sebastian Krzyszkowiak, Alim Akhtar,
Pengutronix Kernel Team
On Sat, 09 Nov 2024 15:44:33 +0300, Dzmitry Sankouski wrote:
> If specified, driver should request irq as shared.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml: shared-irq: missing type definition
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241109-b4-max17042-v1-1-9e2b07e54e76@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/4] power: supply: max17042: implement dts shared-irq
2024-11-09 12:44 [PATCH 0/4] power: supply: max17042: cleanup and more features Dzmitry Sankouski
2024-11-09 12:44 ` [PATCH 1/4] dt-bindings: power: supply: max17042: add share-irq node Dzmitry Sankouski
@ 2024-11-09 12:44 ` Dzmitry Sankouski
2024-11-09 12:44 ` [PATCH 3/4] power: supply: max17042: use microvolts for voltage comparison Dzmitry Sankouski
2024-11-09 12:44 ` [PATCH 4/4] power: supply: max17042: rename maxim,rsns-microohm property Dzmitry Sankouski
3 siblings, 0 replies; 10+ messages in thread
From: Dzmitry Sankouski @ 2024-11-09 12:44 UTC (permalink / raw)
To: Hans de Goede, Krzysztof Kozlowski, Marek Szyprowski,
Sebastian Krzyszkowiak, Purism Kernel Team, Sebastian Reichel,
Rob Herring, Conor Dooley, Alim Akhtar, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, imx, linux-arm-msm, Dzmitry Sankouski
If shared-irq specified in device tree, request irq as shared.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
drivers/power/supply/max17042_battery.c | 3 ++-
include/linux/power/max17042_battery.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
index 496c3e1f2ee6..f3d89d4d5c42 100644
--- a/drivers/power/supply/max17042_battery.c
+++ b/drivers/power/supply/max17042_battery.c
@@ -933,6 +933,7 @@ max17042_get_of_pdata(struct max17042_chip *chip)
pdata->vmin = INT_MIN;
if (of_property_read_s32(np, "maxim,over-volt", &pdata->vmax))
pdata->vmax = INT_MAX;
+ pdata->is_irq_shared = of_property_read_bool(np, "shared-irq");
return pdata;
}
@@ -1109,7 +1110,7 @@ static int max17042_probe(struct i2c_client *client)
* On ACPI systems the IRQ may be handled by ACPI-event code,
* so we need to share (if the ACPI code is willing to share).
*/
- if (acpi_id)
+ if (acpi_id || chip->pdata->is_irq_shared)
flags |= IRQF_SHARED | IRQF_PROBE_SHARED;
ret = devm_request_threaded_irq(&client->dev, client->irq,
diff --git a/include/linux/power/max17042_battery.h b/include/linux/power/max17042_battery.h
index c417abd2ab70..1261dbaa5e8f 100644
--- a/include/linux/power/max17042_battery.h
+++ b/include/linux/power/max17042_battery.h
@@ -250,6 +250,7 @@ struct max17042_platform_data {
int num_init_data; /* Number of enties in init_data array */
bool enable_current_sense;
bool enable_por_init; /* Use POR init from Maxim appnote */
+ bool is_irq_shared;
/*
* R_sns in micro-ohms.
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/4] power: supply: max17042: use microvolts for voltage comparison
2024-11-09 12:44 [PATCH 0/4] power: supply: max17042: cleanup and more features Dzmitry Sankouski
2024-11-09 12:44 ` [PATCH 1/4] dt-bindings: power: supply: max17042: add share-irq node Dzmitry Sankouski
2024-11-09 12:44 ` [PATCH 2/4] power: supply: max17042: implement dts shared-irq Dzmitry Sankouski
@ 2024-11-09 12:44 ` Dzmitry Sankouski
2024-11-09 13:48 ` Krzysztof Kozlowski
2024-11-09 12:44 ` [PATCH 4/4] power: supply: max17042: rename maxim,rsns-microohm property Dzmitry Sankouski
3 siblings, 1 reply; 10+ messages in thread
From: Dzmitry Sankouski @ 2024-11-09 12:44 UTC (permalink / raw)
To: Hans de Goede, Krzysztof Kozlowski, Marek Szyprowski,
Sebastian Krzyszkowiak, Purism Kernel Team, Sebastian Reichel,
Rob Herring, Conor Dooley, Alim Akhtar, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, imx, linux-arm-msm, Dzmitry Sankouski
Do not convert VCELL register value from uV to mV to compare
with vmin/vmax. Rather use uV for vim/vmax, since that's a
standard measure unit in power supply drivers.
Convert "maxim,dead-volt" and "maxim,over-volt" to uV.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 2 +-
arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 2 +-
arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 2 +-
arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 2 +-
arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts | 4 ++--
arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts | 4 ++--
arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts | 4 ++--
arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 2 +-
drivers/power/supply/max17042_battery.c | 4 ----
11 files changed, 13 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
index e98ffdad1ec3..d1ad597e0837 100644
--- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
+++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
@@ -83,7 +83,7 @@ examples:
reg = <0x36>;
maxim,rsns-microohm = <10000>;
maxim,over-heat-temp = <600>;
- maxim,over-volt = <4300>;
+ maxim,over-volt = <4300000>;
shared-irq;
};
};
diff --git a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
index 0d8495792a70..0ca755160bef 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-i9100.dts
@@ -150,7 +150,7 @@ battery@36 {
reg = <0x36>;
maxim,over-heat-temp = <700>;
- maxim,over-volt = <4500>;
+ maxim,over-volt = <4500000>;
};
};
diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
index 9bc05961577d..758bfc10826f 100644
--- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi
@@ -186,7 +186,7 @@ fuel-gauge@36 {
pinctrl-0 = <&max77693_fuel_irq>;
maxim,over-heat-temp = <500>;
- maxim,over-volt = <4500>;
+ maxim,over-volt = <450000>;
};
};
diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
index 3d5aace668dc..c744907b7c42 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi
@@ -263,7 +263,7 @@ fuel-gauge@36 {
reg = <0x36>;
maxim,over-heat-temp = <700>;
- maxim,over-volt = <4500>;
+ maxim,over-volt = <4500000>;
};
};
diff --git a/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi b/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
index 28a605802733..3d52aa25c83c 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
@@ -175,7 +175,7 @@ fuel-gauge@36 {
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
maxim,rsns-microohm = <10000>;
maxim,over-heat-temp = <600>;
- maxim,over-volt = <4300>;
+ maxim,over-volt = <4300000>;
};
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 1b39514d5c12..90beefaa644f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1141,7 +1141,7 @@ bat: fuel-gauge@36 {
pinctrl-0 = <&pinctrl_gauge>;
power-supplies = <&bq25895>;
maxim,over-heat-temp = <700>;
- maxim,over-volt = <4500>;
+ maxim,over-volt = <4500000>;
maxim,rsns-microohm = <5000>;
};
diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts b/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts
index 8380451ebbf6..a02ece82ff5b 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts
@@ -25,8 +25,8 @@ battery@36 {
maxim,rsns-microohm = <10000>;
maxim,over-heat-temp = <600>;
maxim,cold-temp = <(-200)>;
- maxim,dead-volt = <3200>;
- maxim,over-volt = <4500>;
+ maxim,dead-volt = <3200000>;
+ maxim,over-volt = <4500000>;
};
/* charger@6b */
diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts b/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts
index ec5589fc69bd..f567b7ffb613 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts
@@ -36,8 +36,8 @@ battery@36 {
maxim,rsns-microohm = <10000>;
maxim,over-heat-temp = <600>;
maxim,cold-temp = <(-200)>;
- maxim,dead-volt = <3200>;
- maxim,over-volt = <4500>;
+ maxim,dead-volt = <3200000>;
+ maxim,over-volt = <4500000>;
};
};
diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts b/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts
index eecf78ba45bb..45ddd17243e7 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts
@@ -25,8 +25,8 @@ battery@36 {
maxim,rsns-microohm = <10000>;
maxim,over-heat-temp = <600>;
maxim,cold-temp = <(-200)>;
- maxim,dead-volt = <3200>;
- maxim,over-volt = <4500>;
+ maxim,dead-volt = <3200000>;
+ maxim,over-volt = <4500000>;
};
};
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
index fbd2caf405d5..2c387c8b6344 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
@@ -105,7 +105,7 @@ fuelgauge@36 {
maxim,rsns-microohm = <10000>;
maxim,over-heat-temp = <600>;
- maxim,over-volt = <4400>;
+ maxim,over-volt = <4400000>;
interrupt-parent = <&tlmm>;
interrupts = <121 IRQ_TYPE_EDGE_FALLING>;
diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
index f3d89d4d5c42..ea212cb10360 100644
--- a/drivers/power/supply/max17042_battery.c
+++ b/drivers/power/supply/max17042_battery.c
@@ -182,8 +182,6 @@ static int max17042_get_battery_health(struct max17042_chip *chip, int *health)
/* bits [0-3] unused */
vavg = val * 625 / 8;
- /* Convert to millivolts */
- vavg /= 1000;
ret = regmap_read(chip->regmap, MAX17042_VCELL, &val);
if (ret < 0)
@@ -191,8 +189,6 @@ static int max17042_get_battery_health(struct max17042_chip *chip, int *health)
/* bits [0-3] unused */
vbatt = val * 625 / 8;
- /* Convert to millivolts */
- vbatt /= 1000;
if (vavg < chip->pdata->vmin) {
*health = POWER_SUPPLY_HEALTH_DEAD;
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/4] power: supply: max17042: use microvolts for voltage comparison
2024-11-09 12:44 ` [PATCH 3/4] power: supply: max17042: use microvolts for voltage comparison Dzmitry Sankouski
@ 2024-11-09 13:48 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-09 13:48 UTC (permalink / raw)
To: Dzmitry Sankouski, Hans de Goede, Marek Szyprowski,
Sebastian Krzyszkowiak, Purism Kernel Team, Sebastian Reichel,
Rob Herring, Conor Dooley, Alim Akhtar, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, imx, linux-arm-msm
On 09/11/2024 13:44, Dzmitry Sankouski wrote:
> Do not convert VCELL register value from uV to mV to compare
> with vmin/vmax. Rather use uV for vim/vmax, since that's a
> standard measure unit in power supply drivers.
>
> Convert "maxim,dead-volt" and "maxim,over-volt" to uV.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 2 +-
> arch/arm/boot/dts/samsung/exynos4210-i9100.dts | 2 +-
> arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 2 +-
> arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 2 +-
> arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts | 4 ++--
> arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts | 4 ++--
> arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts | 4 ++--
> arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 2 +-
> drivers/power/supply/max17042_battery.c | 4 ----
> 11 files changed, 13 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
> index e98ffdad1ec3..d1ad597e0837 100644
> --- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
> @@ -83,7 +83,7 @@ examples:
> reg = <0x36>;
> maxim,rsns-microohm = <10000>;
> maxim,over-heat-temp = <600>;
> - maxim,over-volt = <4300>;
> + maxim,over-volt = <4300000>;
> shared-irq;
Property says this is mV so 4300 V? That's just wrong.
Entire commit touching bindings, drivers and DTS in one patch is an ABI
break and just clear NAK.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 4/4] power: supply: max17042: rename maxim,rsns-microohm property
2024-11-09 12:44 [PATCH 0/4] power: supply: max17042: cleanup and more features Dzmitry Sankouski
` (2 preceding siblings ...)
2024-11-09 12:44 ` [PATCH 3/4] power: supply: max17042: use microvolts for voltage comparison Dzmitry Sankouski
@ 2024-11-09 12:44 ` Dzmitry Sankouski
2024-11-09 13:48 ` Krzysztof Kozlowski
3 siblings, 1 reply; 10+ messages in thread
From: Dzmitry Sankouski @ 2024-11-09 12:44 UTC (permalink / raw)
To: Hans de Goede, Krzysztof Kozlowski, Marek Szyprowski,
Sebastian Krzyszkowiak, Purism Kernel Team, Sebastian Reichel,
Rob Herring, Conor Dooley, Alim Akhtar, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, imx, linux-arm-msm, Dzmitry Sankouski
Rename maxim,rsns-microohm to common shunt-resistor-micro-ohms.
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
---
Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 5 ++---
arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi | 2 +-
arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts | 2 +-
arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 2 +-
drivers/power/supply/max17042_battery.c | 2 +-
9 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
index d1ad597e0837..754d9ad3d94b 100644
--- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
+++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml
@@ -29,8 +29,7 @@ properties:
description: |
The ALRT pin, an open-drain interrupt.
- maxim,rsns-microohm:
- $ref: /schemas/types.yaml#/definitions/uint32
+ shunt-resistor-micro-ohms:
description: |
Resistance of rsns resistor in micro Ohms (datasheet-recommended value is 10000).
Defining this property enables current-sense functionality.
@@ -81,7 +80,7 @@ examples:
battery@36 {
compatible = "maxim,max17042";
reg = <0x36>;
- maxim,rsns-microohm = <10000>;
+ shunt-resistor-micro-ohms = <10000>;
maxim,over-heat-temp = <600>;
maxim,over-volt = <4300000>;
shared-irq;
diff --git a/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi b/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
index 3d52aa25c83c..0b08d23366d6 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi
@@ -173,7 +173,7 @@ fuel-gauge@36 {
pinctrl-names = "default";
interrupt-parent = <&gpx2>;
interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
- maxim,rsns-microohm = <10000>;
+ shunt-resistor-micro-ohms = <10000>;
maxim,over-heat-temp = <600>;
maxim,over-volt = <4300000>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts
index 33f398b48119..99023f302a05 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts
@@ -11,7 +11,7 @@ / {
};
&bat {
- maxim,rsns-microohm = <1667>;
+ shunt-resistor-micro-ohms = <1667>;
};
&led_backlight {
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index 90beefaa644f..6f6ce14afbdc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -1142,7 +1142,7 @@ bat: fuel-gauge@36 {
power-supplies = <&bq25895>;
maxim,over-heat-temp = <700>;
maxim,over-volt = <4500000>;
- maxim,rsns-microohm = <5000>;
+ shunt-resistor-micro-ohms = <5000>;
};
bq25895: charger@6a {
diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts b/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts
index a02ece82ff5b..f5d636db33c8 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts
@@ -22,7 +22,7 @@ battery@36 {
pinctrl-0 = <&battery_alert_default>;
pinctrl-names = "default";
- maxim,rsns-microohm = <10000>;
+ shunt-resistor-micro-ohms = <10000>;
maxim,over-heat-temp = <600>;
maxim,cold-temp = <(-200)>;
maxim,dead-volt = <3200000>;
diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts b/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts
index f567b7ffb613..35343b1fd737 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts
@@ -33,7 +33,7 @@ battery@36 {
pinctrl-0 = <&battery_alert_default>;
pinctrl-names = "default";
- maxim,rsns-microohm = <10000>;
+ shunt-resistor-micro-ohms = <10000>;
maxim,over-heat-temp = <600>;
maxim,cold-temp = <(-200)>;
maxim,dead-volt = <3200000>;
diff --git a/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts b/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts
index 45ddd17243e7..855f8a554a9b 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts
@@ -22,7 +22,7 @@ battery@36 {
pinctrl-0 = <&battery_alert_default>;
pinctrl-names = "default";
- maxim,rsns-microohm = <10000>;
+ shunt-resistor-micro-ohms = <10000>;
maxim,over-heat-temp = <600>;
maxim,cold-temp = <(-200)>;
maxim,dead-volt = <3200000>;
diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
index 2c387c8b6344..0ab64154dc77 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi
@@ -103,7 +103,7 @@ fuelgauge@36 {
compatible = "maxim,max77849-battery";
reg = <0x36>;
- maxim,rsns-microohm = <10000>;
+ shunt-resistor-micro-ohms = <10000>;
maxim,over-heat-temp = <600>;
maxim,over-volt = <4400000>;
diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
index ea212cb10360..497cb6f14bd9 100644
--- a/drivers/power/supply/max17042_battery.c
+++ b/drivers/power/supply/max17042_battery.c
@@ -916,7 +916,7 @@ max17042_get_of_pdata(struct max17042_chip *chip)
* Require current sense resistor value to be specified for
* current-sense functionality to be enabled at all.
*/
- if (of_property_read_u32(np, "maxim,rsns-microohm", &prop) == 0) {
+ if (of_property_read_u32(np, "shunt-resistor-micro-ohms", &prop) == 0) {
pdata->r_sns = prop;
pdata->enable_current_sense = true;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 4/4] power: supply: max17042: rename maxim,rsns-microohm property
2024-11-09 12:44 ` [PATCH 4/4] power: supply: max17042: rename maxim,rsns-microohm property Dzmitry Sankouski
@ 2024-11-09 13:48 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2024-11-09 13:48 UTC (permalink / raw)
To: Dzmitry Sankouski, Hans de Goede, Marek Szyprowski,
Sebastian Krzyszkowiak, Purism Kernel Team, Sebastian Reichel,
Rob Herring, Conor Dooley, Alim Akhtar, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-kernel,
linux-samsung-soc, imx, linux-arm-msm
On 09/11/2024 13:44, Dzmitry Sankouski wrote:
> Rename maxim,rsns-microohm to common shunt-resistor-micro-ohms.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 5 ++---
> arch/arm/boot/dts/samsung/exynos4412-p4note.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r4.dts | 2 +-
> arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-motorola-harpia.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-motorola-osprey.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-motorola-surnia.dts | 2 +-
> arch/arm64/boot/dts/qcom/msm8916-samsung-gt5-common.dtsi | 2 +-
> drivers/power/supply/max17042_battery.c | 2 +-
NAK, ABI break.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread