From: Matthieu Baerts <matttbe@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>
Subject: Re: [PATCH v2] mptcp: pm: Return local variable instead of freed pointer
Date: Wed, 26 Mar 2025 11:25:27 +0100 [thread overview]
Message-ID: <2cab9891-31fa-4585-b7fb-639334a6cf63@kernel.org> (raw)
In-Reply-To: <20250325163251.135510-2-thorsten.blum@linux.dev>
Hi Thorsten,
On 25/03/2025 17:32, Thorsten Blum wrote:
> Commit e4c28e3d5c090 ("mptcp: pm: move generic PM helpers to pm.c")
> removed an unnecessary if-check, which resulted in returning a freed
> pointer.
>
> This still works due to the implicit boolean conversion when returning
> the freed pointer from mptcp_remove_anno_list_by_saddr(), but it can be
> confusing and potentially error-prone. To improve clarity, add a local
> variable to explicitly return a boolean value instead.
Thank you for your patch! Now in our tree (feat. for net-next):
New patches for t/upstream:
- 5172fc837d0c: mptcp: pm: Return local variable instead of freed pointer
- Results: c0c93d7a6bc6..7723f461d379 (export)
Tests are now in progress:
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/5bdccde61635c4e5d2ce60205a3d7356f2b917ea/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-03-26 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 16:32 [PATCH v2] mptcp: pm: Return local variable instead of freed pointer Thorsten Blum
2025-03-25 18:28 ` Matthieu Baerts
2025-03-25 18:45 ` Thorsten Blum
2025-03-25 19:12 ` Matthieu Baerts
2025-03-25 19:20 ` MPTCP CI
2025-03-26 10:25 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cab9891-31fa-4585-b7fb-639334a6cf63@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.