From: Matthieu Baerts <matttbe@kernel.org>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>
Subject: Re: [PATCH v2] mptcp: pm: Return local variable instead of freed pointer
Date: Tue, 25 Mar 2025 20:12:25 +0100 [thread overview]
Message-ID: <ac9a7633-ced5-4e0d-bf3b-abca2f06d7e2@kernel.org> (raw)
In-Reply-To: <8C6930CC-2B90-4331-9086-CF02BE86780B@linux.dev>
On 25/03/2025 19:45, Thorsten Blum wrote:
> On 25. Mar 2025, at 19:28, Matthieu Baerts wrote:
>>
>> It looks like the CI had some issues to apply your patch [1]. Strange,
>> it was fine for me to apply it with 'b4 shazam'. I manually sent it to
>> the CI, I will wait for it to validate it before applying it.
>>
>> https://patchew.org/MPTCP/20250325163251.135510-2-thorsten.blum@linux.dev/logs/git/
>
> I get a 404 Not Found when opening the link.
Better with this one, then click on "apply log"?
https://patchew.org/MPTCP/20250325163251.135510-2-thorsten.blum@linux.dev/
Here is the log:
> Switched to a new branch '20250325163251.135510-2-thorsten.blum@linux.dev'
> Applying: mptcp: pm: Return local variable instead of freed pointer
> error: corrupt patch at line 27
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> Patch failed at 0001 mptcp: pm: Return local variable instead of freed pointer
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
I didn't have that on my side.
> Weird, I made sure the patch applies to mptcp/export.
Yes, strange. There was an issue with the v1 as well apparently:
https://patchew.org/MPTCP/20250325110639.49399-2-thorsten.blum@linux.dev/
I will check later if it was not an issue with Patchew.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-03-25 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 16:32 [PATCH v2] mptcp: pm: Return local variable instead of freed pointer Thorsten Blum
2025-03-25 18:28 ` Matthieu Baerts
2025-03-25 18:45 ` Thorsten Blum
2025-03-25 19:12 ` Matthieu Baerts [this message]
2025-03-25 19:20 ` MPTCP CI
2025-03-26 10:25 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac9a7633-ced5-4e0d-bf3b-abca2f06d7e2@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.