All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: stable@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid
Date: Wed, 19 Jun 2024 09:09:18 +0800	[thread overview]
Message-ID: <2cb67503-d974-4db2-942d-b68b69de9447@kernel.org> (raw)
In-Reply-To: <20240618022334.1576056-1-jaegeuk@kernel.org>

On 2024/6/18 10:23, Jaegeuk Kim wrote:
> mkdir /mnt/test/comp
> f2fs_io setflags compression /mnt/test/comp
> dd if=/dev/zero of=/mnt/test/comp/testfile bs=16k count=1
> truncate --size 13 /mnt/test/comp/testfile
> 
> In the above scenario, we can get a BUG_ON.
>   kernel BUG at fs/f2fs/segment.c:3589!
>   Call Trace:
>    do_write_page+0x78/0x390 [f2fs]
>    f2fs_outplace_write_data+0x62/0xb0 [f2fs]
>    f2fs_do_write_data_page+0x275/0x740 [f2fs]
>    f2fs_write_single_data_page+0x1dc/0x8f0 [f2fs]
>    f2fs_write_multi_pages+0x1e5/0xae0 [f2fs]
>    f2fs_write_cache_pages+0xab1/0xc60 [f2fs]
>    f2fs_write_data_pages+0x2d8/0x330 [f2fs]
>    do_writepages+0xcf/0x270
>    __writeback_single_inode+0x44/0x350
>    writeback_sb_inodes+0x242/0x530
>    __writeback_inodes_wb+0x54/0xf0
>    wb_writeback+0x192/0x310
>    wb_workfn+0x30d/0x400
> 
> The reason is we gave CURSEG_ALL_DATA_ATGC to COMPR_ADDR where the
> page was set the gcing flag by set_cluster_dirty().
> 
> Cc: stable@vger.kernel.org
> Fixes: 4961acdd65c9 ("f2fs: fix to tag gcing flag on page during block migration")
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Cc: stable@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid
Date: Wed, 19 Jun 2024 09:09:18 +0800	[thread overview]
Message-ID: <2cb67503-d974-4db2-942d-b68b69de9447@kernel.org> (raw)
In-Reply-To: <20240618022334.1576056-1-jaegeuk@kernel.org>

On 2024/6/18 10:23, Jaegeuk Kim wrote:
> mkdir /mnt/test/comp
> f2fs_io setflags compression /mnt/test/comp
> dd if=/dev/zero of=/mnt/test/comp/testfile bs=16k count=1
> truncate --size 13 /mnt/test/comp/testfile
> 
> In the above scenario, we can get a BUG_ON.
>   kernel BUG at fs/f2fs/segment.c:3589!
>   Call Trace:
>    do_write_page+0x78/0x390 [f2fs]
>    f2fs_outplace_write_data+0x62/0xb0 [f2fs]
>    f2fs_do_write_data_page+0x275/0x740 [f2fs]
>    f2fs_write_single_data_page+0x1dc/0x8f0 [f2fs]
>    f2fs_write_multi_pages+0x1e5/0xae0 [f2fs]
>    f2fs_write_cache_pages+0xab1/0xc60 [f2fs]
>    f2fs_write_data_pages+0x2d8/0x330 [f2fs]
>    do_writepages+0xcf/0x270
>    __writeback_single_inode+0x44/0x350
>    writeback_sb_inodes+0x242/0x530
>    __writeback_inodes_wb+0x54/0xf0
>    wb_writeback+0x192/0x310
>    wb_workfn+0x30d/0x400
> 
> The reason is we gave CURSEG_ALL_DATA_ATGC to COMPR_ADDR where the
> page was set the gcing flag by set_cluster_dirty().
> 
> Cc: stable@vger.kernel.org
> Fixes: 4961acdd65c9 ("f2fs: fix to tag gcing flag on page during block migration")
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

  reply	other threads:[~2024-06-19  1:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18  2:23 [f2fs-dev] [PATCH] f2fs: assign CURSEG_ALL_DATA_ATGC if blkaddr is valid Jaegeuk Kim
2024-06-18  2:23 ` Jaegeuk Kim
2024-06-19  1:09 ` Chao Yu [this message]
2024-06-19  1:09   ` [f2fs-dev] " Chao Yu
2024-06-21 21:36   ` William McVicker via Linux-f2fs-devel
2024-06-21 21:36     ` William McVicker
2024-06-24 17:40 ` patchwork-bot+f2fs
2024-06-24 17:40   ` patchwork-bot+f2fs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cb67503-d974-4db2-942d-b68b69de9447@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.