* [PATCH 1/2] multipath-tools: replace static and define default values for config options
@ 2016-10-26 2:33 zhou.guichun
2016-10-26 19:17 ` Xose Vazquez Perez
0 siblings, 1 reply; 3+ messages in thread
From: zhou.guichun @ 2016-10-26 2:33 UTC (permalink / raw)
To: 10184522, 10072500, 10074136
Cc: Xose Vazquez Perez, device-mapper development
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
Replace "const" by PRIO_CONST.
Replace static force_sync and partition_delim values, and define
DEFAULT_FORCE_SYNC and DEFAULT_PARTITION_DELIM
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/config.c | 4 ++--
libmultipath/defaults.h | 4 +++-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/libmultipath/config.c b/libmultipath/config.c
index 92e4deb..ed51afb 100644
--- a/libmultipath/config.c
+++ b/libmultipath/config.c
@@ -606,8 +606,8 @@ load_config (char * file)
conf->fast_io_fail = DEFAULT_FAST_IO_FAIL;
conf->retain_hwhandler = DEFAULT_RETAIN_HWHANDLER;
conf->detect_prio = DEFAULT_DETECT_PRIO;
- conf->force_sync = 0;
- conf->partition_delim = NULL;
+ conf->force_sync = DEFAULT_FORCE_SYNC;
+ conf->partition_delim = DEFAULT_PARTITION_DELIM;
conf->processed_main_config = 0;
conf->find_multipaths = DEFAULT_FIND_MULTIPATHS;
conf->uxsock_timeout = DEFAULT_REPLY_TIMEOUT;
diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h
index e9581a6..9af9a9a 100644
--- a/libmultipath/defaults.h
+++ b/libmultipath/defaults.h
@@ -28,11 +28,13 @@
#define DEFAULT_RETRIGGER_DELAY 10
#define DEFAULT_RETRIGGER_TRIES 3
#define DEFAULT_UEV_WAIT_TIMEOUT 30
-#define DEFAULT_PRIO "const"
+#define DEFAULT_PRIO PRIO_CONST
#define DEFAULT_PRIO_ARGS ""
#define DEFAULT_CHECKER TUR
#define DEFAULT_FLUSH FLUSH_DISABLED
#define DEFAULT_USER_FRIENDLY_NAMES USER_FRIENDLY_NAMES_OFF
+#define DEFAULT_FORCE_SYNC 0
+#define DEFAULT_PARTITION_DELIM NULL
#define DEFAULT_CHECKINT 5
#define MAX_CHECKINT(a) (a << 2)
--
2.8.1.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] multipath-tools: replace static and define default values for config options
2016-10-26 2:33 [PATCH 1/2] multipath-tools: replace static and define default values for config options zhou.guichun
@ 2016-10-26 19:17 ` Xose Vazquez Perez
2016-10-27 1:58 ` 答复: " zhou.guichun
0 siblings, 1 reply; 3+ messages in thread
From: Xose Vazquez Perez @ 2016-10-26 19:17 UTC (permalink / raw)
To: zhou.guichun, 10184522, 10072500, 10074136; +Cc: device-mapper development
On 10/26/2016 04:33 AM, zhou.guichun@zte.com.cn wrote:
> From: Xose Vazquez Perez <xose.vazquez@gmail.com>
This patch already was applied: http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=906c098284afc9573d710ba25580b6919352a3ff
This looks like an internal e-mail, please fix your mailer.
> Replace "const" by PRIO_CONST.
> Replace static force_sync and partition_delim values, and define
> DEFAULT_FORCE_SYNC and DEFAULT_PARTITION_DELIM
>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/config.c | 4 ++--
> libmultipath/defaults.h | 4 +++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/libmultipath/config.c b/libmultipath/config.c
> index 92e4deb..ed51afb 100644
> --- a/libmultipath/config.c
> +++ b/libmultipath/config.c
> @@ -606,8 +606,8 @@ load_config (char * file)
> conf->fast_io_fail = DEFAULT_FAST_IO_FAIL;
> conf->retain_hwhandler = DEFAULT_RETAIN_HWHANDLER;
> conf->detect_prio = DEFAULT_DETECT_PRIO;
> - conf->force_sync = 0;
> - conf->partition_delim = NULL;
> + conf->force_sync = DEFAULT_FORCE_SYNC;
> + conf->partition_delim = DEFAULT_PARTITION_DELIM;
> conf->processed_main_config = 0;
> conf->find_multipaths = DEFAULT_FIND_MULTIPATHS;
> conf->uxsock_timeout = DEFAULT_REPLY_TIMEOUT;
> diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h
> index e9581a6..9af9a9a 100644
> --- a/libmultipath/defaults.h
> +++ b/libmultipath/defaults.h
> @@ -28,11 +28,13 @@
> #define DEFAULT_RETRIGGER_DELAY 10
> #define DEFAULT_RETRIGGER_TRIES 3
> #define DEFAULT_UEV_WAIT_TIMEOUT 30
> -#define DEFAULT_PRIO "const"
> +#define DEFAULT_PRIO PRIO_CONST
> #define DEFAULT_PRIO_ARGS ""
> #define DEFAULT_CHECKER TUR
> #define DEFAULT_FLUSH FLUSH_DISABLED
> #define DEFAULT_USER_FRIENDLY_NAMES USER_FRIENDLY_NAMES_OFF
> +#define DEFAULT_FORCE_SYNC 0
> +#define DEFAULT_PARTITION_DELIM NULL
>
> #define DEFAULT_CHECKINT 5
> #define MAX_CHECKINT(a) (a << 2)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* 答复: Re: [PATCH 1/2] multipath-tools: replace static and define default values for config options
2016-10-26 19:17 ` Xose Vazquez Perez
@ 2016-10-27 1:58 ` zhou.guichun
0 siblings, 0 replies; 3+ messages in thread
From: zhou.guichun @ 2016-10-27 1:58 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: 10184522, 10074136, 10072500, device-mapper development
[-- Attachment #1.1.1: Type: text/plain, Size: 3488 bytes --]
I am terrible sorry for brought inconvenience for you because of my wrong
operition.I
have fix this wrong. Excuse me for my unintentional fault!
周桂春 Zhou GuiChun
软件开发 SoftWare Development
虚拟化长沙开发部 NIV Changsha Development Dept
湖南省长沙市岳麓区尖山路39号中电软件园八楼
T: +86 731-82057106 M: +86 13657402573
E: zhou.guichun@zte.com.cn
www.zte.com.cn
发件人: Xose Vazquez Perez <xose.vazquez@gmail.com>
收件人: zhou.guichun@zte.com.cn, 10184522@zte.com.cn,
10072500@zte.com.cn, 10074136@zte.com.cn,
抄送: Benjamin Marzinski <bmarzins@redhat.com>, Hannes Reinecke
<hare@suse.de>, Christophe Varoqui <christophe.varoqui@opensvc.com>,
device-mapper development <dm-devel@redhat.com>
日期: 2016/10/27 03:17
主题: Re: [PATCH 1/2] multipath-tools: replace static and define default
values for config options
On 10/26/2016 04:33 AM, zhou.guichun@zte.com.cn wrote:
> From: Xose Vazquez Perez <xose.vazquez@gmail.com>
This patch already was applied:
http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=906c098284afc9573d710ba25580b6919352a3ff
This looks like an internal e-mail, please fix your mailer.
> Replace "const" by PRIO_CONST.
> Replace static force_sync and partition_delim values, and define
> DEFAULT_FORCE_SYNC and DEFAULT_PARTITION_DELIM
>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/config.c | 4 ++--
> libmultipath/defaults.h | 4 +++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/libmultipath/config.c b/libmultipath/config.c
> index 92e4deb..ed51afb 100644
> --- a/libmultipath/config.c
> +++ b/libmultipath/config.c
> @@ -606,8 +606,8 @@ load_config (char * file)
> conf->fast_io_fail = DEFAULT_FAST_IO_FAIL;
> conf->retain_hwhandler = DEFAULT_RETAIN_HWHANDLER;
> conf->detect_prio = DEFAULT_DETECT_PRIO;
> - conf->force_sync = 0;
> - conf->partition_delim = NULL;
> + conf->force_sync = DEFAULT_FORCE_SYNC;
> + conf->partition_delim = DEFAULT_PARTITION_DELIM;
> conf->processed_main_config = 0;
> conf->find_multipaths = DEFAULT_FIND_MULTIPATHS;
> conf->uxsock_timeout = DEFAULT_REPLY_TIMEOUT;
> diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h
> index e9581a6..9af9a9a 100644
> --- a/libmultipath/defaults.h
> +++ b/libmultipath/defaults.h
> @@ -28,11 +28,13 @@
> #define DEFAULT_RETRIGGER_DELAY 10
> #define DEFAULT_RETRIGGER_TRIES 3
> #define DEFAULT_UEV_WAIT_TIMEOUT 30
> -#define DEFAULT_PRIO "const"
> +#define DEFAULT_PRIO PRIO_CONST
> #define DEFAULT_PRIO_ARGS ""
> #define DEFAULT_CHECKER TUR
> #define DEFAULT_FLUSH FLUSH_DISABLED
> #define DEFAULT_USER_FRIENDLY_NAMES USER_FRIENDLY_NAMES_OFF
> +#define DEFAULT_FORCE_SYNC 0
> +#define DEFAULT_PARTITION_DELIM NULL
>
> #define DEFAULT_CHECKINT 5
> #define MAX_CHECKINT(a) (a << 2)
>
[-- Attachment #1.1.2: Type: text/html, Size: 7238 bytes --]
[-- Attachment #1.2: Type: image/gif, Size: 6015 bytes --]
[-- Attachment #1.3: Type: image/gif, Size: 2054 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-27 1:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 2:33 [PATCH 1/2] multipath-tools: replace static and define default values for config options zhou.guichun
2016-10-26 19:17 ` Xose Vazquez Perez
2016-10-27 1:58 ` 答复: " zhou.guichun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.