From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Konrad Weihmann <kweihmann@outlook.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
Date: Mon, 4 Oct 2021 15:08:54 +0000 [thread overview]
Message-ID: <2d32793c8dbc47a0afced79d07377812@axis.com> (raw)
In-Reply-To: <AM9PR09MB46421376B722A7A7A315BC8CA8AE9@AM9PR09MB4642.eurprd09.prod.outlook.com>
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Konrad Weihmann
> Sent: den 4 oktober 2021 15:29
> To: openembedded-core@lists.openembedded.org
> Cc: Konrad Weihmann <kweihmann@outlook.com>
> Subject: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
>
> fix the append with a leading blank, otherwise this messes up
> DEPENDS when globally inherited classes add dependecies of their own
>
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
> meta/recipes-core/glib-2.0/glib.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-
> 2.0/glib.inc
> index a34776b083..3436645f15 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -30,7 +30,7 @@ LEAD_SONAME = "libglib-2.0.*"
>
> inherit meson gettext gtk-doc pkgconfig ptest-gnome upstream-version-is-
> even bash-completion gio-module-cache manpages
>
> -DEPENDS:append:class-target = "${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
> +DEPENDS:append:class-target = " ${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
This change is not needed as there already is a space inside
the if statement (in ' gtk-doc').
>
> GTKDOC_MESON_OPTION = "gtk_doc"
>
> --
> 2.25.1
//Peter
next prev parent reply other threads:[~2021-10-04 15:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211004132853.30543-1-kweihmann@outlook.com>
2021-10-04 13:28 ` [PATCH 2/3] glibc: fix append in DEPENDS Konrad Weihmann
2021-10-04 15:08 ` Peter Kjellerstedt [this message]
2021-10-04 15:13 ` [OE-core] " Konrad Weihmann
2021-10-04 15:29 ` Martin Jansa
2021-10-04 15:34 ` Konrad Weihmann
2021-10-04 13:28 ` [PATCH 3/3] update-rc.d: " Konrad Weihmann
2021-10-04 15:09 ` [OE-core] " Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d32793c8dbc47a0afced79d07377812@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=kweihmann@outlook.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.