* [PATCH 2/3] glibc: fix append in DEPENDS
[not found] <20211004132853.30543-1-kweihmann@outlook.com>
@ 2021-10-04 13:28 ` Konrad Weihmann
2021-10-04 15:08 ` [OE-core] " Peter Kjellerstedt
2021-10-04 13:28 ` [PATCH 3/3] update-rc.d: " Konrad Weihmann
1 sibling, 1 reply; 7+ messages in thread
From: Konrad Weihmann @ 2021-10-04 13:28 UTC (permalink / raw)
To: openembedded-core; +Cc: Konrad Weihmann
fix the append with a leading blank, otherwise this messes up
DEPENDS when globally inherited classes add dependecies of their own
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
---
meta/recipes-core/glib-2.0/glib.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index a34776b083..3436645f15 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -30,7 +30,7 @@ LEAD_SONAME = "libglib-2.0.*"
inherit meson gettext gtk-doc pkgconfig ptest-gnome upstream-version-is-even bash-completion gio-module-cache manpages
-DEPENDS:append:class-target = "${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
+DEPENDS:append:class-target = " ${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
GTKDOC_MESON_OPTION = "gtk_doc"
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] update-rc.d: fix append in DEPENDS
[not found] <20211004132853.30543-1-kweihmann@outlook.com>
2021-10-04 13:28 ` [PATCH 2/3] glibc: fix append in DEPENDS Konrad Weihmann
@ 2021-10-04 13:28 ` Konrad Weihmann
2021-10-04 15:09 ` [OE-core] " Peter Kjellerstedt
1 sibling, 1 reply; 7+ messages in thread
From: Konrad Weihmann @ 2021-10-04 13:28 UTC (permalink / raw)
To: openembedded-core; +Cc: Konrad Weihmann
fix the append with a leading blank, otherwise this messes up
DEPENDS when globally inherited classes add dependecies of their own
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
---
meta/classes/update-rc.d.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update-rc.d.bbclass
index 0a3a608662..921df98584 100644
--- a/meta/classes/update-rc.d.bbclass
+++ b/meta/classes/update-rc.d.bbclass
@@ -1,6 +1,6 @@
UPDATERCPN ?= "${PN}"
-DEPENDS:append:class-target = "${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', ' update-rc.d initscripts', '', d)}"
+DEPENDS:append:class-target = " ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', ' update-rc.d initscripts', '', d)}"
UPDATERCD = "update-rc.d"
UPDATERCD:class-cross = ""
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
2021-10-04 13:28 ` [PATCH 2/3] glibc: fix append in DEPENDS Konrad Weihmann
@ 2021-10-04 15:08 ` Peter Kjellerstedt
2021-10-04 15:13 ` Konrad Weihmann
0 siblings, 1 reply; 7+ messages in thread
From: Peter Kjellerstedt @ 2021-10-04 15:08 UTC (permalink / raw)
To: Konrad Weihmann, openembedded-core@lists.openembedded.org
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Konrad Weihmann
> Sent: den 4 oktober 2021 15:29
> To: openembedded-core@lists.openembedded.org
> Cc: Konrad Weihmann <kweihmann@outlook.com>
> Subject: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
>
> fix the append with a leading blank, otherwise this messes up
> DEPENDS when globally inherited classes add dependecies of their own
>
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
> meta/recipes-core/glib-2.0/glib.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-
> 2.0/glib.inc
> index a34776b083..3436645f15 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -30,7 +30,7 @@ LEAD_SONAME = "libglib-2.0.*"
>
> inherit meson gettext gtk-doc pkgconfig ptest-gnome upstream-version-is-
> even bash-completion gio-module-cache manpages
>
> -DEPENDS:append:class-target = "${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
> +DEPENDS:append:class-target = " ${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
This change is not needed as there already is a space inside
the if statement (in ' gtk-doc').
>
> GTKDOC_MESON_OPTION = "gtk_doc"
>
> --
> 2.25.1
//Peter
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [OE-core] [PATCH 3/3] update-rc.d: fix append in DEPENDS
2021-10-04 13:28 ` [PATCH 3/3] update-rc.d: " Konrad Weihmann
@ 2021-10-04 15:09 ` Peter Kjellerstedt
0 siblings, 0 replies; 7+ messages in thread
From: Peter Kjellerstedt @ 2021-10-04 15:09 UTC (permalink / raw)
To: Konrad Weihmann, openembedded-core@lists.openembedded.org
> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Konrad Weihmann
> Sent: den 4 oktober 2021 15:29
> To: openembedded-core@lists.openembedded.org
> Cc: Konrad Weihmann <kweihmann@outlook.com>
> Subject: [OE-core] [PATCH 3/3] update-rc.d: fix append in DEPENDS
>
> fix the append with a leading blank, otherwise this messes up
> DEPENDS when globally inherited classes add dependecies of their own
>
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
> meta/classes/update-rc.d.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update-
> rc.d.bbclass
> index 0a3a608662..921df98584 100644
> --- a/meta/classes/update-rc.d.bbclass
> +++ b/meta/classes/update-rc.d.bbclass
> @@ -1,6 +1,6 @@
> UPDATERCPN ?= "${PN}"
>
> -DEPENDS:append:class-target = "${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', ' update-rc.d initscripts', '', d)}"
> +DEPENDS:append:class-target = " ${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit', ' update-rc.d initscripts', '', d)}"
This change is not needed as there already is a space inside
the if statement (in ' update-rc.d initscripts').
>
> UPDATERCD = "update-rc.d"
> UPDATERCD:class-cross = ""
> --
> 2.25.1
//Peter
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
2021-10-04 15:08 ` [OE-core] " Peter Kjellerstedt
@ 2021-10-04 15:13 ` Konrad Weihmann
2021-10-04 15:29 ` Martin Jansa
0 siblings, 1 reply; 7+ messages in thread
From: Konrad Weihmann @ 2021-10-04 15:13 UTC (permalink / raw)
To: Peter Kjellerstedt, openembedded-core@lists.openembedded.org
On 04.10.21 17:08, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-core@lists.openembedded.org <openembedded-
>> core@lists.openembedded.org> On Behalf Of Konrad Weihmann
>> Sent: den 4 oktober 2021 15:29
>> To: openembedded-core@lists.openembedded.org
>> Cc: Konrad Weihmann <kweihmann@outlook.com>
>> Subject: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
>>
>> fix the append with a leading blank, otherwise this messes up
>> DEPENDS when globally inherited classes add dependecies of their own
>>
>> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
>> ---
>> meta/recipes-core/glib-2.0/glib.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-
>> 2.0/glib.inc
>> index a34776b083..3436645f15 100644
>> --- a/meta/recipes-core/glib-2.0/glib.inc
>> +++ b/meta/recipes-core/glib-2.0/glib.inc
>> @@ -30,7 +30,7 @@ LEAD_SONAME = "libglib-2.0.*"
>>
>> inherit meson gettext gtk-doc pkgconfig ptest-gnome upstream-version-is-
>> even bash-completion gio-module-cache manpages
>>
>> -DEPENDS:append:class-target = "${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
>> +DEPENDS:append:class-target = " ${@' gtk-doc' if d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
>
> This change is not needed as there already is a space inside
> the if statement (in ' gtk-doc').
Still this is very prone to errors, so I personally rather have a space
too much than to few (esp. as the else clause doesn't add a space).
IHMO it should be for readability purpose rather " ${@'gtk-doc' if
d.getVar('GTKDOC_ENABLED') == 'True' else ''}" than like it is now - but
that's just cosmetics and I'm sure one could discuss about that a lot
>
>>
>> GTKDOC_MESON_OPTION = "gtk_doc"
>>
>> --
>> 2.25.1
>
> //Peter
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
2021-10-04 15:13 ` Konrad Weihmann
@ 2021-10-04 15:29 ` Martin Jansa
2021-10-04 15:34 ` Konrad Weihmann
0 siblings, 1 reply; 7+ messages in thread
From: Martin Jansa @ 2021-10-04 15:29 UTC (permalink / raw)
To: Konrad Weihmann
Cc: Peter Kjellerstedt, openembedded-core@lists.openembedded.org
[-- Attachment #1: Type: text/plain, Size: 2913 bytes --]
> Still this is very prone to errors, so I personally rather have a
space too much than to few (esp. as the else clause doesn't add a space).
The missing space in else clause is often intentional in cases like this,
so that the append has no impact on value when not enabled
with GTKDOC_ENABLED. Why should it add useless space when not enabled? Just
for the possibility of someone adding something to else clause without
leading space there?
On Mon, Oct 4, 2021 at 5:14 PM Konrad Weihmann <kweihmann@outlook.com>
wrote:
>
>
> On 04.10.21 17:08, Peter Kjellerstedt wrote:
> >> -----Original Message-----
> >> From: openembedded-core@lists.openembedded.org <openembedded-
> >> core@lists.openembedded.org> On Behalf Of Konrad Weihmann
> >> Sent: den 4 oktober 2021 15:29
> >> To: openembedded-core@lists.openembedded.org
> >> Cc: Konrad Weihmann <kweihmann@outlook.com>
> >> Subject: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
> >>
> >> fix the append with a leading blank, otherwise this messes up
> >> DEPENDS when globally inherited classes add dependecies of their own
> >>
> >> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> >> ---
> >> meta/recipes-core/glib-2.0/glib.inc | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/glib-2.0/glib.inc
> b/meta/recipes-core/glib-
> >> 2.0/glib.inc
> >> index a34776b083..3436645f15 100644
> >> --- a/meta/recipes-core/glib-2.0/glib.inc
> >> +++ b/meta/recipes-core/glib-2.0/glib.inc
> >> @@ -30,7 +30,7 @@ LEAD_SONAME = "libglib-2.0.*"
> >>
> >> inherit meson gettext gtk-doc pkgconfig ptest-gnome
> upstream-version-is-
> >> even bash-completion gio-module-cache manpages
> >>
> >> -DEPENDS:append:class-target = "${@' gtk-doc' if
> d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
> >> +DEPENDS:append:class-target = " ${@' gtk-doc' if
> d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
> >
> > This change is not needed as there already is a space inside
> > the if statement (in ' gtk-doc').
>
> Still this is very prone to errors, so I personally rather have a space
> too much than to few (esp. as the else clause doesn't add a space).
>
> IHMO it should be for readability purpose rather " ${@'gtk-doc' if
> d.getVar('GTKDOC_ENABLED') == 'True' else ''}" than like it is now - but
> that's just cosmetics and I'm sure one could discuss about that a lot
>
> >
> >>
> >> GTKDOC_MESON_OPTION = "gtk_doc"
> >>
> >> --
> >> 2.25.1
> >
> > //Peter
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156611):
> https://lists.openembedded.org/g/openembedded-core/message/156611
> Mute This Topic: https://lists.openembedded.org/mt/86066304/3617156
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> Martin.Jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 4617 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
2021-10-04 15:29 ` Martin Jansa
@ 2021-10-04 15:34 ` Konrad Weihmann
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Weihmann @ 2021-10-04 15:34 UTC (permalink / raw)
To: Martin Jansa; +Cc: Peter Kjellerstedt, openembedded-core@lists.openembedded.org
On 04.10.21 17:29, Martin Jansa wrote:
> > Still this is very prone to errors, so I personally rather have a
> space too much than to few (esp. as the else clause doesn't add a space).
>
> The missing space in else clause is often intentional in cases like
> this, so that the append has no impact on value when not enabled
> with GTKDOC_ENABLED. Why should it add useless space when not enabled?
> Just for the possibility of someone adding something to else clause
> without leading space there?
Partly yes, I found those conditionals rather hard to review, esp. for
more complex scenarios, so I kind of would suggest to add the mandatory
space for the append operation all the time and add no additional space
in the stuff that is popping out of the conditional computation.
But I'm also fine with dropping the last 2 patches of the series.
Only the first patch solves a real world issue... the remaining two were
just a result of a linter scan
>
> On Mon, Oct 4, 2021 at 5:14 PM Konrad Weihmann <kweihmann@outlook.com
> <mailto:kweihmann@outlook.com>> wrote:
>
>
>
> On 04.10.21 17:08, Peter Kjellerstedt wrote:
> >> -----Original Message-----
> >> From: openembedded-core@lists.openembedded.org
> <mailto:openembedded-core@lists.openembedded.org> <openembedded-
> >> core@lists.openembedded.org
> <mailto:core@lists.openembedded.org>> On Behalf Of Konrad Weihmann
> >> Sent: den 4 oktober 2021 15:29
> >> To: openembedded-core@lists.openembedded.org
> <mailto:openembedded-core@lists.openembedded.org>
> >> Cc: Konrad Weihmann <kweihmann@outlook.com
> <mailto:kweihmann@outlook.com>>
> >> Subject: [OE-core] [PATCH 2/3] glibc: fix append in DEPENDS
> >>
> >> fix the append with a leading blank, otherwise this messes up
> >> DEPENDS when globally inherited classes add dependecies of their own
> >>
> >> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com
> <mailto:kweihmann@outlook.com>>
> >> ---
> >> meta/recipes-core/glib-2.0/glib.inc | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-core/glib-2.0/glib.inc
> b/meta/recipes-core/glib-
> >> 2.0/glib.inc
> >> index a34776b083..3436645f15 100644
> >> --- a/meta/recipes-core/glib-2.0/glib.inc
> >> +++ b/meta/recipes-core/glib-2.0/glib.inc
> >> @@ -30,7 +30,7 @@ LEAD_SONAME = "libglib-2.0.*"
> >>
> >> inherit meson gettext gtk-doc pkgconfig ptest-gnome
> upstream-version-is-
> >> even bash-completion gio-module-cache manpages
> >>
> >> -DEPENDS:append:class-target = "${@' gtk-doc' if
> d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
> >> +DEPENDS:append:class-target = " ${@' gtk-doc' if
> d.getVar('GTKDOC_ENABLED') == 'True' else ''}"
> >
> > This change is not needed as there already is a space inside
> > the if statement (in ' gtk-doc').
>
> Still this is very prone to errors, so I personally rather have a space
> too much than to few (esp. as the else clause doesn't add a space).
>
> IHMO it should be for readability purpose rather " ${@'gtk-doc' if
> d.getVar('GTKDOC_ENABLED') == 'True' else ''}" than like it is now -
> but
> that's just cosmetics and I'm sure one could discuss about that a lot
>
> >
> >>
> >> GTKDOC_MESON_OPTION = "gtk_doc"
> >>
> >> --
> >> 2.25.1
> >
> > //Peter
> >
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156611):
> https://lists.openembedded.org/g/openembedded-core/message/156611
> <https://lists.openembedded.org/g/openembedded-core/message/156611>
> Mute This Topic: https://lists.openembedded.org/mt/86066304/3617156
> <https://lists.openembedded.org/mt/86066304/3617156>
> Group Owner: openembedded-core+owner@lists.openembedded.org
> <mailto:openembedded-core%2Bowner@lists.openembedded.org>
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub
> <https://lists.openembedded.org/g/openembedded-core/unsub>
> [Martin.Jansa@gmail.com <mailto:Martin.Jansa@gmail.com>]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-10-04 15:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211004132853.30543-1-kweihmann@outlook.com>
2021-10-04 13:28 ` [PATCH 2/3] glibc: fix append in DEPENDS Konrad Weihmann
2021-10-04 15:08 ` [OE-core] " Peter Kjellerstedt
2021-10-04 15:13 ` Konrad Weihmann
2021-10-04 15:29 ` Martin Jansa
2021-10-04 15:34 ` Konrad Weihmann
2021-10-04 13:28 ` [PATCH 3/3] update-rc.d: " Konrad Weihmann
2021-10-04 15:09 ` [OE-core] " Peter Kjellerstedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.