Re: [PATCH v2 3/3] sparc64: bitops: Change __fls to return unsigned long

From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Vineet Gupta <vgupta@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	"David S . Miller" <davem@davemloft.net>
Cc: Guenter Roeck <linux@roeck-us.net>,
	linux-snps-arc@lists.infradead.org,
	linux-m68k@lists.linux-m68k.org, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Cezary Rojewski <cezary.rojewski@intel.com>
Subject: Re: [PATCH v2 3/3] sparc64: bitops: Change __fls to return unsigned long
Date: Wed, 3 Aug 2022 10:48:01 +0200	[thread overview]
Message-ID: <2d4fac14-eaf8-c899-dba2-b2ffb484358d@linux.intel.com> (raw)
In-Reply-To: <20220527115345.2588775-4-amadeuszx.slawinski@linux.intel.com>

On 5/27/2022 1:53 PM, Amadeusz Sławiński wrote:
> As per asm-generic definition and other architectures __fls should
> return unsigned long.
> 
> No functional change is expected as return value should fit in unsigned
> long.
> 
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
> ---
>   arch/sparc/include/asm/bitops_64.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sparc/include/asm/bitops_64.h b/arch/sparc/include/asm/bitops_64.h
> index 005a8ae858f1..cdac39bd7b32 100644
> --- a/arch/sparc/include/asm/bitops_64.h
> +++ b/arch/sparc/include/asm/bitops_64.h
> @@ -24,7 +24,7 @@ void clear_bit(unsigned long nr, volatile unsigned long *addr);
>   void change_bit(unsigned long nr, volatile unsigned long *addr);
>   
>   int fls(unsigned int word);
> -int __fls(unsigned long word);
> +unsigned long __fls(unsigned long word);
>   
>   #include <asm-generic/bitops/non-atomic.h>
>   

Hi,

any chance this one could also get merged? Other two patches are already 
in linux-next and I would like to remove it from list of things I have 
to remember ;)

Amadeusz