All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trilok Soni <tsoni@codeaurora.org>
To: Suman Anna <s-anna@ti.com>, Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] samples/rpmsg: Introduce a module parameter for message count
Date: Tue, 11 Sep 2018 11:17:40 -0700	[thread overview]
Message-ID: <2d904881-ec72-dd68-48ff-b8307642bc63@codeaurora.org> (raw)
In-Reply-To: <20180911174643.26199-1-s-anna@ti.com>

Bjorn,

>   
>   #define MSG		"hello world!"
> -#define MSG_LIMIT	100
> +
> +static int count = 100;
> +module_param(count, int, 0644);

I thought Greg KH doesn't want any new code to have module_param call, 
right? Are we Ok here or I am missing something here.

-- 
---Trilok Soni
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: tsoni@codeaurora.org (Trilok Soni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] samples/rpmsg: Introduce a module parameter for message count
Date: Tue, 11 Sep 2018 11:17:40 -0700	[thread overview]
Message-ID: <2d904881-ec72-dd68-48ff-b8307642bc63@codeaurora.org> (raw)
In-Reply-To: <20180911174643.26199-1-s-anna@ti.com>

Bjorn,

>   
>   #define MSG		"hello world!"
> -#define MSG_LIMIT	100
> +
> +static int count = 100;
> +module_param(count, int, 0644);

I thought Greg KH doesn't want any new code to have module_param call, 
right? Are we Ok here or I am missing something here.

-- 
---Trilok Soni
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project

  reply	other threads:[~2018-09-11 18:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 17:46 [PATCH] samples/rpmsg: Introduce a module parameter for message count Suman Anna
2018-09-11 17:46 ` Suman Anna
2018-09-11 17:46 ` Suman Anna
2018-09-11 18:17 ` Trilok Soni [this message]
2018-09-11 18:17   ` Trilok Soni
2018-10-01 21:09   ` Suman Anna
2018-10-01 21:09     ` Suman Anna
2018-10-01 21:09     ` Suman Anna
2018-10-06  6:22 ` Bjorn Andersson
2018-10-06  6:22   ` Bjorn Andersson
2018-10-06  6:22   ` Bjorn Andersson
2018-10-06 16:28   ` Vinod
2018-10-06 16:28     ` Vinod
2018-10-08 16:33   ` Suman Anna
2018-10-08 16:33     ` Suman Anna
2018-10-08 16:33     ` Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d904881-ec72-dd68-48ff-b8307642bc63@codeaurora.org \
    --to=tsoni@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.