From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>, Rosen Penev <rosenp@gmail.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] gpio: ppc44x: tidy up includes and probe
Date: Mon, 9 Nov 2026 12:30:06 +0100 [thread overview]
Message-ID: <2d9d1da9-0d2e-461b-9c9a-eaf3dc512035@kernel.org> (raw)
In-Reply-To: <cw32kfja4uifaotvodb7cfxrpzawt4zqcuzf4k3hvjgxwutxqu@gyaayjuyq3j4>
[-- Attachment #1.1: Type: text/plain, Size: 396 bytes --]
Hello Bart,
On 2026-11-09 10:01, Bartosz Golaszewski wrote:
>> static const struct of_device_id ppc44x_gpio_match[] = {
>> - {
>> - .compatible = "ibm,ppc4xx-gpio",
>> - },
>> + { .compatible = "ibm,ppc4xx-gpio" },
>> {},
>
> Uwe: is this in line with your recent cleanups?
The change is fine, I'd appreciate to also do
- {},
+ { }
at the same time.
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-09 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 21:59 [PATCH 0/5] gpio: ppc44x: assorted cleanups Rosen Penev
2026-11-04 21:59 ` [PATCH 1/5] gpio: ppc44x: drop redundant label and parent assignments Rosen Penev
2026-11-04 21:59 ` [PATCH 2/5] gpio: ppc44x: factor out the OSR/TSR source selection Rosen Penev
2026-11-04 21:59 ` [PATCH 3/5] gpio: ppc44x: fold __ppc44x_gpio_set() into ppc44x_gpio_dir_out() Rosen Penev
2026-11-09 9:02 ` Bartosz Golaszewski
2026-11-04 21:59 ` [PATCH 4/5] gpio: ppc44x: use BIT() and GENMASK() for the pin masks Rosen Penev
2026-11-04 21:59 ` [PATCH 5/5] gpio: ppc44x: tidy up includes and probe Rosen Penev
2026-11-09 9:01 ` Bartosz Golaszewski
2026-11-09 11:30 ` Uwe Kleine-König [this message]
2026-11-09 20:46 ` Rosen Penev
2026-11-10 8:50 ` Uwe Kleine-König
2026-11-10 9:02 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d9d1da9-0d2e-461b-9c9a-eaf3dc512035@kernel.org \
--to=ukleinek@kernel.org \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.