All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH 6/6] ath11k: switch to using ieee80211_tx_status_ext()
Date: Fri, 09 Aug 2019 16:23:16 -0700	[thread overview]
Message-ID: <2dc32161ae3cf25deae0542c72941dc4@codeaurora.org> (raw)
In-Reply-To: <20190714154419.11854-7-john@phrozen.org>


> @@ -431,12 +434,18 @@ static void ath11k_dp_tx_complete_msdu(struct 
> ath11k *ar,
> -	ieee80211_tx_status(ar->hw, msdu);
> +	spin_lock_bh(&ab->data_lock);
> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
> +	arsta = (struct ath11k_sta *)peer->sta->drv_priv;
Hi John,

Accesing sta when peer is deleted is causing null pointer dereference 
issue.

Thanks
Pradeep

_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To: John Crispin <john@phrozen.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH 6/6] ath11k: switch to using ieee80211_tx_status_ext()
Date: Fri, 09 Aug 2019 16:23:16 -0700	[thread overview]
Message-ID: <2dc32161ae3cf25deae0542c72941dc4@codeaurora.org> (raw)
In-Reply-To: <20190714154419.11854-7-john@phrozen.org>


> @@ -431,12 +434,18 @@ static void ath11k_dp_tx_complete_msdu(struct 
> ath11k *ar,
> -	ieee80211_tx_status(ar->hw, msdu);
> +	spin_lock_bh(&ab->data_lock);
> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
> +	arsta = (struct ath11k_sta *)peer->sta->drv_priv;
Hi John,

Accesing sta when peer is deleted is causing null pointer dereference 
issue.

Thanks
Pradeep

  reply	other threads:[~2019-08-09 23:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-14 15:44 [PATCH 0/6] mac80211: add HE TX rate reporting to radiotap John Crispin
2019-07-14 15:44 ` John Crispin
2019-07-14 15:44 ` [PATCH 1/6] mac80211: add xmit rate to struct ieee80211_tx_status John Crispin
2019-07-14 15:44   ` John Crispin
2019-07-14 15:44 ` [PATCH 2/6] mac80211: propagate struct ieee80211_tx_status into ieee80211_tx_monitor() John Crispin
2019-07-14 15:44   ` John Crispin
2019-07-14 15:44 ` [PATCH 3/6] mac80211: add struct ieee80211_tx_status support to ieee80211_add_tx_radiotap_header John Crispin
2019-07-14 15:44   ` John Crispin
2019-07-14 15:44 ` [PATCH 4/6] ath11k: drop tx_info from ath11k_sta John Crispin
2019-07-14 15:44   ` John Crispin
2019-07-14 15:44 ` [PATCH 5/6] ath11k: add HE rate accounting to driver John Crispin
2019-07-14 15:44   ` John Crispin
2019-07-14 15:44 ` [PATCH 6/6] ath11k: switch to using ieee80211_tx_status_ext() John Crispin
2019-07-14 15:44   ` John Crispin
2019-08-09 23:23   ` Pradeep Kumar Chitrapu [this message]
2019-08-09 23:23     ` Pradeep Kumar Chitrapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dc32161ae3cf25deae0542c72941dc4@codeaurora.org \
    --to=pradeepc@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=john@phrozen.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.