[PATCH] usb: host: xhci: use snprintf() in xhci_decode_trb()

[PATCH] usb: host: xhci: use snprintf() in xhci_decode_trb()

[Sergey Shtylyov]

Commit cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
apparently missed one sprintf() call in xhci_decode_trb() -- replace
it with the snprintf() call as well...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Fixes: cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

---
This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.

 drivers/usb/host/xhci.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: usb/drivers/usb/host/xhci.h
===================================================================
--- usb.orig/drivers/usb/host/xhci.h
+++ usb/drivers/usb/host/xhci.h
@@ -2391,7 +2391,7 @@ static inline const char *xhci_decode_tr
 			field3 & TRB_CYCLE ? 'C' : 'c');
 		break;
 	case TRB_STOP_RING:
-		sprintf(str,
+		snprintf(str, size,
 			"%s: slot %d sp %d ep %d flags %c",
 			xhci_trb_type_string(type),
 			TRB_TO_SLOT_ID(field3),

Re: [PATCH] usb: host: xhci: use snprintf() in xhci_decode_trb()

[Sergey Shtylyov]

Hello!

On 3/16/22 11:36 PM, Sergey Shtylyov wrote:

> Commit cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
> apparently missed one sprintf() call in xhci_decode_trb() -- replace
> it with the snprintf() call as well...
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
> analysis tool.
> 
> Fixes: cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> 
> ---
> This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.

   Mathias, Greg, what's going on with this patch? It was posted 2 months ago
and seemingly ignored... :-/

MBR, Sergey

Re: [PATCH] usb: host: xhci: use snprintf() in xhci_decode_trb()

[Mathias Nyman]

On 17.5.2022 22.13, Sergey Shtylyov wrote:
> Hello!
> 
> On 3/16/22 11:36 PM, Sergey Shtylyov wrote:
> 
>> Commit cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
>> apparently missed one sprintf() call in xhci_decode_trb() -- replace
>> it with the snprintf() call as well...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Fixes: cbf286e8ef83 ("xhci: fix unsafe memory usage in xhci tracing")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> ---
>> This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.
> 
>     Mathias, Greg, what's going on with this patch? It was posted 2 months ago
> and seemingly ignored... :-/
> 
> MBR, Sergey

Must have missed it

I'll queue it up for 5.20 unless Greg still picks it up for 5.19.
Not urgent.

-Mathias