From: David Laight <David.Laight@ACULAB.COM>
To: 'Masahiro Yamada' <masahiroy@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h
Date: Thu, 17 Feb 2022 16:49:49 +0000 [thread overview]
Message-ID: <2e38265880db45afa96cfb51223f7418@AcuMS.aculab.com> (raw)
In-Reply-To: <CAK7LNASWTJ-ax9u5yOwHV9vHCBAcQTazV-oXtqVFVFedOA0Eqw@mail.gmail.com>
From: Masahiro Yamada
> Sent: 17 February 2022 16:17
...
> No. Not that one.
>
> The commit you presumably want to revert is:
>
> a771f2b82aa2 ("[PATCH] Add a section about inlining to
> Documentation/CodingStyle")
>
> This is now referred to as "__always_inline disease", though.
That description is largely fine.
Inappropriate 'inline' ought to be removed.
Then 'inline' means - 'really do inline this'.
Anyone remember massive 100+ line #defines being
used to get code inlined 'to make it faster'.
Sometimes being expanded several times in succession.
May have helped a 68020, but likely to be a loss on
modern cpu with large I-cache and slow memory.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
WARNING: multiple messages have this Message-ID (diff)
From: David Laight <David.Laight@ACULAB.COM>
To: 'Masahiro Yamada' <masahiroy@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>,
Nick Desaulniers <ndesaulniers@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h
Date: Thu, 17 Feb 2022 16:49:49 +0000 [thread overview]
Message-ID: <2e38265880db45afa96cfb51223f7418@AcuMS.aculab.com> (raw)
In-Reply-To: <CAK7LNASWTJ-ax9u5yOwHV9vHCBAcQTazV-oXtqVFVFedOA0Eqw@mail.gmail.com>
From: Masahiro Yamada
> Sent: 17 February 2022 16:17
...
> No. Not that one.
>
> The commit you presumably want to revert is:
>
> a771f2b82aa2 ("[PATCH] Add a section about inlining to
> Documentation/CodingStyle")
>
> This is now referred to as "__always_inline disease", though.
That description is largely fine.
Inappropriate 'inline' ought to be removed.
Then 'inline' means - 'really do inline this'.
Anyone remember massive 100+ line #defines being
used to get code inlined 'to make it faster'.
Sometimes being expanded several times in succession.
May have helped a 68020, but likely to be a loss on
modern cpu with large I-cache and slow memory.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-02-17 16:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 12:19 [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h Christophe Leroy
2022-02-17 12:19 ` Christophe Leroy
2022-02-17 13:36 ` David Laight
2022-02-17 14:50 ` Christophe Leroy
2022-02-17 14:55 ` Christophe Leroy
2022-02-17 15:15 ` David Laight
2022-02-17 16:17 ` Masahiro Yamada
2022-02-17 16:17 ` Masahiro Yamada
2022-02-17 16:49 ` David Laight [this message]
2022-02-17 16:49 ` David Laight
2022-02-17 17:27 ` Masahiro Yamada
2022-02-17 17:27 ` Masahiro Yamada
2022-02-17 18:07 ` Segher Boessenkool
2022-02-17 18:07 ` Segher Boessenkool
2022-02-18 1:35 ` Masahiro Yamada
2022-02-18 1:35 ` Masahiro Yamada
2022-02-18 12:12 ` Segher Boessenkool
2022-02-18 12:12 ` Segher Boessenkool
2022-02-18 16:29 ` Stephen Hemminger
2022-02-18 16:29 ` Stephen Hemminger
2022-02-18 16:44 ` Segher Boessenkool
2022-02-18 16:44 ` Segher Boessenkool
2022-02-18 8:41 ` David Laight
2022-02-18 8:41 ` David Laight
2022-02-17 15:42 ` Joe Perches
2022-02-17 15:42 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e38265880db45afa96cfb51223f7418@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.