All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Audra Mitchell <audra@redhat.com>
Cc: jocolema@redhat.com, raquini@redhat.com,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Shuah Khan <shuah@kernel.org>,
	Muhammad Usama Anjum <usama.anjum@arm.com>,
	Andrei Vagin <avagin@google.com>,
	Colin Ian King <colin.i.king@gmail.com>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Correct __pagemap_scan_get_categories return value
Date: Tue, 11 Aug 2026 18:08:18 +0200	[thread overview]
Message-ID: <2e44c28e-6ade-4638-a17b-ce1cc2e8bbe5@kernel.org> (raw)
In-Reply-To: <20260806122714.08ef839853939a22de815db9@linux-foundation.org>

On 8/6/26 21:27, Andrew Morton wrote:
> On Thu,  6 Aug 2026 14:17:03 -0400 Audra Mitchell <audra@redhat.com> wrote:
> 
>> Currently __pagemap_scan_get_categories returns the result from the
>> ioctl call which should be an int, not uint64_t. The ioctl may
>> return -1 on error, which will be interpreted as UINT64_MAX. Adjust
>> the return type to use the correct value.
> 
> I don't know why these were resent.
> 
> It's conventional (and useful) to include a [0/N] cover letter when
> more than a single patch is being sent.  That's the place to tell us
> why a new version has been sent.

Heh, I was CCed on one, apparently Audra messed up the CC/TO list :)

> 
> And please see how people are tracking versioning infomation in the
> email subjects.
> 
> And it's nice to prepare a Subject: which identifies what part of the
> kernel is being altered.  I think the main audience here is those who
> are scanning subjects wondering "am I interested in this".
> 
> So to sum up, a good title for this patch would have been
> 
> Subject: [PATCH v1 1/2] selftests/mm: correct __pagemap_scan_get_categories return value

Yes. With that

Acked-by: David Hildenbrand (Arm) <david@kernel.org>


Audra, I would suggest that you take a look at b4 for patch series management.

(also, don't send new revisions in reply to previous submissions)


-- 
Cheers,

David


  reply	other threads:[~2026-08-11 16:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-18 18:42 [PATCH] selftests/mm: Fix soft-dirty kselftest supported check Audra Mitchell
2026-02-24 16:15 ` David Hildenbrand (Arm)
2026-03-17 15:08   ` Audra Mitchell
2026-03-18  8:17     ` David Hildenbrand (Arm)
2026-03-19 18:59       ` Audra Mitchell
2026-03-20 11:26         ` David Hildenbrand (Arm)
2026-03-20 18:39           ` [PATCH V2] " Audra Mitchell
2026-03-20 18:39             ` [PATCH] " Audra Mitchell
2026-03-20 20:53               ` Andrew Morton
2026-03-23 11:56               ` David Hildenbrand (Arm)
2026-03-24 23:23                 ` Andrew Morton
2026-03-24 23:24                   ` Andrew Morton
2026-03-25 16:23                     ` Audra Mitchell
2026-03-27 10:08                       ` David Hildenbrand (Arm)
     [not found]                         ` <20260806181843.1839943-1-audra@redhat.com>
2026-08-06 18:17                           ` [PATCH 1/2] Correct __pagemap_scan_get_categories return value Audra Mitchell
2026-08-06 19:27                             ` Andrew Morton
2026-08-11 16:08                               ` David Hildenbrand (Arm) [this message]
2026-08-06 18:17                           ` [PATCH 2/2] selftests/mm: Fix soft-dirty kselftest supported check Audra Mitchell
2026-08-06 18:46                             ` Andrew Morton
2026-08-11 16:11                             ` David Hildenbrand (Arm)
2026-03-27 10:52       ` [PATCH] " Lorenzo Stoakes (Oracle)
2026-03-27 10:58         ` Lorenzo Stoakes (Oracle)
2026-03-27 11:15           ` Lorenzo Stoakes (Oracle)
2026-03-27 11:14         ` Lorenzo Stoakes (Oracle)
2026-03-31 16:32           ` Audra Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e44c28e-6ade-4638-a17b-ce1cc2e8bbe5@kernel.org \
    --to=david@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=audra@redhat.com \
    --cc=avagin@google.com \
    --cc=colin.i.king@gmail.com \
    --cc=jocolema@redhat.com \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=raquini@redhat.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=usama.anjum@arm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.