From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
Shuah Khan <shuah@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3
Date: Wed, 26 Jan 2022 13:50:36 -0700 [thread overview]
Message-ID: <2e9162ef-6107-e56c-e713-1f1ac7f83003@linuxfoundation.org> (raw)
In-Reply-To: <YfGrXr1/NGREULnB@sirena.org.uk>
On 1/26/22 1:13 PM, Mark Brown wrote:
> On Wed, Jan 26, 2022 at 01:03:44PM -0700, Shuah Khan wrote:
>> On 1/26/22 12:52 PM, Mark Brown wrote:
>
>>> If the function fails for any reason other than the system not
>>> supporting vgic-v3 it will abort rather than return.
>
>> Hmm. vgic_v3_setup() return gic_fd looks like and the interface says
>> Return: GIC file-descriptor or negative error code upon failure
>
> Yes, but in reality the only return other than a valid file descriptor
> is just -1 rather than a useful error code.
>
The interface document gives the impression that it will return
error - Oh well. In which case, no point in printing that. Agree.
>> I don't follow the abort part.
>
> All the TEST_ASSERTS() in the code (including those in the functions
> called) are calls to test_assert() in assert.c which if the test
> asserted isn't true will print some diagnostics and call exit(), the
> general idiom is to give up immediately on error.
>
Ah right. Makes sense.
thanks,
-- Shuah
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>, Shuah Khan <shuah@kernel.org>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
kvmarm@lists.cs.columbia.edu, linux-kselftest@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3
Date: Wed, 26 Jan 2022 13:50:36 -0700 [thread overview]
Message-ID: <2e9162ef-6107-e56c-e713-1f1ac7f83003@linuxfoundation.org> (raw)
In-Reply-To: <YfGrXr1/NGREULnB@sirena.org.uk>
On 1/26/22 1:13 PM, Mark Brown wrote:
> On Wed, Jan 26, 2022 at 01:03:44PM -0700, Shuah Khan wrote:
>> On 1/26/22 12:52 PM, Mark Brown wrote:
>
>>> If the function fails for any reason other than the system not
>>> supporting vgic-v3 it will abort rather than return.
>
>> Hmm. vgic_v3_setup() return gic_fd looks like and the interface says
>> Return: GIC file-descriptor or negative error code upon failure
>
> Yes, but in reality the only return other than a valid file descriptor
> is just -1 rather than a useful error code.
>
The interface document gives the impression that it will return
error - Oh well. In which case, no point in printing that. Agree.
>> I don't follow the abort part.
>
> All the TEST_ASSERTS() in the code (including those in the functions
> called) are calls to test_assert() in assert.c which if the test
> asserted isn't true will print some diagnostics and call exit(), the
> general idiom is to give up immediately on error.
>
Ah right. Makes sense.
thanks,
-- Shuah
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>, Shuah Khan <shuah@kernel.org>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
kvmarm@lists.cs.columbia.edu, linux-kselftest@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3
Date: Wed, 26 Jan 2022 13:50:36 -0700 [thread overview]
Message-ID: <2e9162ef-6107-e56c-e713-1f1ac7f83003@linuxfoundation.org> (raw)
In-Reply-To: <YfGrXr1/NGREULnB@sirena.org.uk>
On 1/26/22 1:13 PM, Mark Brown wrote:
> On Wed, Jan 26, 2022 at 01:03:44PM -0700, Shuah Khan wrote:
>> On 1/26/22 12:52 PM, Mark Brown wrote:
>
>>> If the function fails for any reason other than the system not
>>> supporting vgic-v3 it will abort rather than return.
>
>> Hmm. vgic_v3_setup() return gic_fd looks like and the interface says
>> Return: GIC file-descriptor or negative error code upon failure
>
> Yes, but in reality the only return other than a valid file descriptor
> is just -1 rather than a useful error code.
>
The interface document gives the impression that it will return
error - Oh well. In which case, no point in printing that. Agree.
>> I don't follow the abort part.
>
> All the TEST_ASSERTS() in the code (including those in the functions
> called) are calls to test_assert() in assert.c which if the test
> asserted isn't true will print some diagnostics and call exit(), the
> general idiom is to give up immediately on error.
>
Ah right. Makes sense.
thanks,
-- Shuah
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-27 15:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 14:52 [PATCH v3] kselftest: kvm/arm64: Skip tests if we can't create a vgic-v3 Mark Brown
2022-01-26 14:52 ` Mark Brown
2022-01-26 14:52 ` Mark Brown
2022-01-26 15:12 ` Andrew Jones
2022-01-26 15:12 ` Andrew Jones
2022-01-26 15:12 ` Andrew Jones
2022-01-26 19:22 ` Shuah Khan
2022-01-26 19:22 ` Shuah Khan
2022-01-26 19:22 ` Shuah Khan
2022-01-26 19:52 ` Mark Brown
2022-01-26 19:52 ` Mark Brown
2022-01-26 19:52 ` Mark Brown
2022-01-26 20:03 ` Shuah Khan
2022-01-26 20:03 ` Shuah Khan
2022-01-26 20:03 ` Shuah Khan
2022-01-26 20:13 ` Mark Brown
2022-01-26 20:13 ` Mark Brown
2022-01-26 20:13 ` Mark Brown
2022-01-26 20:50 ` Shuah Khan [this message]
2022-01-26 20:50 ` Shuah Khan
2022-01-26 20:50 ` Shuah Khan
2022-01-27 4:16 ` Ricardo Koller
2022-01-27 4:16 ` Ricardo Koller
2022-01-27 4:16 ` Ricardo Koller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9162ef-6107-e56c-e713-1f1ac7f83003@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.