Re: [PATCH] PCI: dwc: EXPORT dw_pcie_allocate_domains

[Hans Zhang <18255117159@163.com>]

On 2025/5/26 18:42, Samiksha Garg wrote:
> Hi Mani, Thanks for your response. I can see that pci-keystone driver 
> already calls this function. Does it not mean that there is already an 
> upstream user? Thanks, Samiksha On Mon, May 26, 2025 at 04:50:11PM 
> +0530, Manivannan Sadhasivam wrote:
>> On Mon, May 26, 2025 at 10:42:40AM +0000, Samiksha Garg wrote:
>>> Some vendor drivers need to write their own `msi_init` while
>>> still utilizing `dw_pcie_allocate_domains` method to allocate
>>> IRQ domains. Export the function for this purpose.
>>>
>> NAK. Symbols should have atleast one upstream user to be exported. We do not
>> export symbols for random vendor drivers, sorry.
>>
>> - Mani
>>
>>> Signed-off-by: Samiksha Garg<samikshagarg@google.com>
>>> ---
>>>   drivers/pci/controller/dwc/pcie-designware-host.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
>>> index ecc33f6789e3..5b949547f917 100644
>>> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
>>> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
>>> @@ -249,6 +249,7 @@ int dw_pcie_allocate_domains(struct dw_pcie_rp *pp)
>>>   
>>>   	return 0;
>>>   }
>>> +EXPORT_SYMBOL_GPL(dw_pcie_allocate_domains);
>>>   
>>>   static void dw_pcie_free_msi(struct dw_pcie_rp *pp)
>>>   {
>>> -- 
>>> 2.49.0.1151.ga128411c76-goog