Re: [PATCH] PCI: dwc: EXPORT dw_pcie_allocate_domains

[Hans Zhang <hans.zhang@cixtech.com>]

On 2025/5/27 12:42, Samiksha Garg wrote:
> [You don't often get email from samikshagarg@google.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> EXTERNAL EMAIL
> 
> Hi,
> Yes I understand that `pci-keystone` is currently built in,
> which is why it can use `dw_pcie_allocate_domains` without
> the need for symbol export.
> 
> My intent with the patch was to make this API accessible to
> other out-of-tree drivers that rely on the Designware core
> and might have similar want as `pci-keystone`.
> 
> Since `dw_pcie_allocate_domains` is already non-static,
> exporting it could enable consistent reuse without requiring
> duplication or workarounds.
> 

Hello,

Just as Mani said, you need to upstream your Root Port driver. 
Otherwise, too many APIs need to be exported.

I have also encountered this kind of problem of yours. Actually, I think 
the dwc driver should be compiled as a module so that many SOC 
manufacturers can modify it by themselves. Otherwise, for example, 
Android GKI cannot meet the requirements. My previous approach was to 
copy the entire dwc driver and rename all the functions. Finally, it is 
loaded in the form of ko.

Best regards,
Hans

> Thanks,
> Samiksha
> 
> On Tue, May 27, 2025 at 12:29:18AM +0800, Hans Zhang wrote:
>>
>>
>> On 2025/5/26 18:42, Samiksha Garg wrote:
>>> Hi Mani,
>>> Thanks for your response. I can see that pci-keystone driver already calls this function.
>>> Does it not mean that there is already an upstream user?
>>>
>>
>> Hello,
>>
>> pci-keystone is build-in.
>>
>> Best regards,
>> Hans
>>
>