All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr <olekstysh@gmail.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	sstabellini@kernel.org
Subject: Re: [PATCH V3 4/5] xen/arm: Extend SCIF early prink code to handle other interfaces
Date: Mon, 15 Apr 2019 14:38:36 +0300	[thread overview]
Message-ID: <2ff19660-21e6-d2a6-6752-4c8a59433f72@gmail.com> (raw)
In-Reply-To: <69c402ec-3a78-edf4-354d-1413b3c9c603@arm.com>


On 14.04.19 20:48, Julien Grall wrote:
> Hi,

Hi Julien


>
> On 4/8/19 11:14 AM, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Extend early prink code to be able to handle other SCIF(X)
>> compatible interfaces as well. These interfaces have lot in common,
>> but mostly differ in offsets and bits for some registers.
>>
>> Introduce "EARLY_PRINTK_VERSION" config option to choose which
>> interface version should be used (to properly apply register offsets).
>>
>> Please note, nothing has been technically changed for Renesas "Lager"
>> and other supported boards (SCIF).
>>
>> The "EARLY_PRINTK_VERSION" option for that board should be empty:
>> CONFIG_EARLY_PRINTK=scif,0xe6e60000
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> CC: Julien Grall <julien.grall@arm.com>
>>
>> ---
>>      Changes in v3:
>>          - It was decided not to introduce new debug-scifa.inc
>>            for handling SCIFA interface, but to extend existing
>>            debug-scif.inc for handling both interfaces.
>>            This patch is a result of splitting an initial patch
>>            "xen/arm: Add SCIFA UART support for early printk"
>>            and only reworks a code
>> ---
>>   xen/arch/arm/Rules.mk             |  7 +++++++
>>   xen/arch/arm/arm32/debug-scif.inc | 13 +++++++++----
>
> You want to update docs/misc/arm/early-printk.txt with the new option.

Sure, will update.


>
> Otherwise, the code looks good to me.
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr <olekstysh@gmail.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	sstabellini@kernel.org
Subject: Re: [Xen-devel] [PATCH V3 4/5] xen/arm: Extend SCIF early prink code to handle other interfaces
Date: Mon, 15 Apr 2019 14:38:36 +0300	[thread overview]
Message-ID: <2ff19660-21e6-d2a6-6752-4c8a59433f72@gmail.com> (raw)
Message-ID: <20190415113836.GCG-JXCXjWnhTMIMYLloIDmFyPhs2zrzfC_wifHmVn8@z> (raw)
In-Reply-To: <69c402ec-3a78-edf4-354d-1413b3c9c603@arm.com>


On 14.04.19 20:48, Julien Grall wrote:
> Hi,

Hi Julien


>
> On 4/8/19 11:14 AM, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>>
>> Extend early prink code to be able to handle other SCIF(X)
>> compatible interfaces as well. These interfaces have lot in common,
>> but mostly differ in offsets and bits for some registers.
>>
>> Introduce "EARLY_PRINTK_VERSION" config option to choose which
>> interface version should be used (to properly apply register offsets).
>>
>> Please note, nothing has been technically changed for Renesas "Lager"
>> and other supported boards (SCIF).
>>
>> The "EARLY_PRINTK_VERSION" option for that board should be empty:
>> CONFIG_EARLY_PRINTK=scif,0xe6e60000
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
>> CC: Julien Grall <julien.grall@arm.com>
>>
>> ---
>>      Changes in v3:
>>          - It was decided not to introduce new debug-scifa.inc
>>            for handling SCIFA interface, but to extend existing
>>            debug-scif.inc for handling both interfaces.
>>            This patch is a result of splitting an initial patch
>>            "xen/arm: Add SCIFA UART support for early printk"
>>            and only reworks a code
>> ---
>>   xen/arch/arm/Rules.mk             |  7 +++++++
>>   xen/arch/arm/arm32/debug-scif.inc | 13 +++++++++----
>
> You want to update docs/misc/arm/early-printk.txt with the new option.

Sure, will update.


>
> Otherwise, the code looks good to me.
>
> Cheers,
>
-- 
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-04-15 11:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 10:14 [PATCH V3 0/5] Renesas Stout board support (R-Car Gen2) Oleksandr Tyshchenko
2019-04-08 10:14 ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-08 10:14 ` [PATCH V3 1/5] xen/arm: Clarify usage of earlyprintk for Lager board Oleksandr Tyshchenko
2019-04-08 10:14   ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-08 10:14 ` [PATCH V3 2/5] xen/arm: drivers: scif: Extend driver to handle other interfaces Oleksandr Tyshchenko
2019-04-08 10:14   ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-14 16:55   ` Julien Grall
2019-04-14 16:55     ` [Xen-devel] " Julien Grall
2019-04-15 11:30     ` Oleksandr
2019-04-15 11:30       ` [Xen-devel] " Oleksandr
2019-04-16  9:11       ` Julien Grall
2019-04-16  9:11         ` [Xen-devel] " Julien Grall
2019-04-16 13:26         ` Oleksandr
2019-04-16 13:26           ` [Xen-devel] " Oleksandr
2019-04-08 10:14 ` [PATCH V3 3/5] xen/arm: drivers: scif: Add support for SCIFA compatible UARTs Oleksandr Tyshchenko
2019-04-08 10:14   ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-14 16:57   ` Julien Grall
2019-04-14 16:57     ` [Xen-devel] " Julien Grall
2019-04-08 10:14 ` [PATCH V3 4/5] xen/arm: Extend SCIF early prink code to handle other interfaces Oleksandr Tyshchenko
2019-04-08 10:14   ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-14 17:48   ` Julien Grall
2019-04-14 17:48     ` [Xen-devel] " Julien Grall
2019-04-15 11:38     ` Oleksandr [this message]
2019-04-15 11:38       ` Oleksandr
2019-04-08 10:14 ` [PATCH V3 5/5] xen/arm: Add early printk support for SCIFA compatible UARTs Oleksandr Tyshchenko
2019-04-08 10:14   ` [Xen-devel] " Oleksandr Tyshchenko
2019-04-14 17:56   ` Julien Grall
2019-04-14 17:56     ` [Xen-devel] " Julien Grall
2019-04-15 11:43     ` Oleksandr
2019-04-15 11:43       ` [Xen-devel] " Oleksandr
2019-04-16  9:16       ` Julien Grall
2019-04-16  9:16         ` [Xen-devel] " Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ff19660-21e6-d2a6-6752-4c8a59433f72@gmail.com \
    --to=olekstysh@gmail.com \
    --cc=julien.grall@arm.com \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.