Re: [PATCH 1/4] dt-bindings: mtd: jedec,spi-nor: Add Winbond W25Q(32/64/128/256)JWM

From: Pratyush Yadav <pratyush@kernel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: robh@kernel.org,  krzk+dt@kernel.org,  conor+dt@kernel.org,
	tudor.ambarus@linaro.org,  pratyush@kernel.org,
	 mwalle@kernel.org, miquel.raynal@bootlin.com,  richard@nod.at,
	 vigneshr@ti.com, lgirdwood@gmail.com,  broonie@kernel.org,
	 matthias.bgg@gmail.com, julien.massot@collabora.com,
	 eugen.hristev@linaro.org, jiaxin.yu@mediatek.com,
	 shane.chien@mediatek.com, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	 linux-sound@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,  kernel@collabora.com
Subject: Re: [PATCH 1/4] dt-bindings: mtd: jedec,spi-nor: Add Winbond W25Q(32/64/128/256)JWM
Date: Thu, 15 Jan 2026 13:16:53 +0000	[thread overview]
Message-ID: <2vxz5x93818a.fsf@kernel.org> (raw)
In-Reply-To: <20260115125624.73598-2-angelogioacchino.delregno@collabora.com> (AngeloGioacchino Del Regno's message of "Thu, 15 Jan 2026 13:56:21 +0100")

On Thu, Jan 15 2026, AngeloGioacchino Del Regno wrote:

> Add Winbond W25Q32JWM, W25Q64JWM, W25Q128JWM, W25Q256JWM to the
> allowed compatible strings pattern.
>
> This also resolves a dtbs_check warning happening on all of the
> MediaTek MT8192 Chromebooks devicetrees (for winbond,w25q64jwm).

We normally don't allow adding any more device-specific compatibles.
This list here is only for legacy DTS. You should be using
"jedec,spi-nor" in your device trees.

>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 587af4968255..2db446c9ca9b 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -29,7 +29,7 @@ properties:
>                (sst,)?sst26wf016b|\
>                (sst,)?sst25wf(040b|080)|\
>                winbond,w25x(80|32)|\
> -              (winbond,)?w25q(16|32(w|dw)?|64(dw)?|80bl|128(fw)?|256))$"
> +              (winbond,)?w25q(16|32(w|dw)?|64(dw|jwm)?|80bl|128(fw|jwm)?|256(jwm)?))$"
>            - const: jedec,spi-nor
>        - items:
>            - enum:

-- 
Regards,
Pratyush Yadav