All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	Brian Norris
	<briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Alexandru M Stan <amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: dts: rockchip: make sure edp_24m is associated to xin24m on veyron
Date: Thu, 03 Dec 2015 16:43:02 +0100	[thread overview]
Message-ID: <3006808.mS23SN11BJ@diego> (raw)
In-Reply-To: <2767415.mEkgRbSSUB@diego>

Am Dienstag, 1. Dezember 2015, 18:14:27 schrieb Heiko Stübner:

applied all three patches to my dts32 branch for 4.5, after disabling emmc 
tuning on mickey (in a similar fashion as on minnie) for the short term.

> The edp-24m clock has two possible sources: the 24MHz oscillator as well
> as an external 27MHz input. The power-on-default is the 27MHz clock which
> is not supplied on all Rockchip boards. While on all current boards and
> also all Veyron Chromebooks the bootloader seems to adapt the muxing to
> the internal source, this doesn't seem to be the case on headless veyron
> devices like brain and mickey making the edp-24m clock an orphan.
> On the hardware side the 27m input also is not connected at all.
> 
> With the upcoming deferral of orphan-clocks this results in the power-
> domain code deferring, as it cannot request the needed clock and if the
> synchronous reset is sucessfullat all in this case is also unknown.
> 
> So fix that by making sure, the edp-24m clock is muxed to the internal
> 24MHz oscillator at all times.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> ---
> It seems I had some issues sending, sorry about the double-mails.
> 
>  arch/arm/boot/dts/rk3288-veyron.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi
> b/arch/arm/boot/dts/rk3288-veyron.dtsi index 5e61f07..9fce91f 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -340,6 +340,11 @@
>  	i2c-scl-rising-time-ns = <1000>;
>  };
> 
> +&power {
> +	assigned-clocks = <&cru SCLK_EDP_24M>;
> +	assigned-clock-parents = <&xin24m>;
> +};
> +
>  &pwm1 {
>  	status = "okay";
>  };

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: dts: rockchip: make sure edp_24m is associated to xin24m on veyron
Date: Thu, 03 Dec 2015 16:43:02 +0100	[thread overview]
Message-ID: <3006808.mS23SN11BJ@diego> (raw)
In-Reply-To: <2767415.mEkgRbSSUB@diego>

Am Dienstag, 1. Dezember 2015, 18:14:27 schrieb Heiko St?bner:

applied all three patches to my dts32 branch for 4.5, after disabling emmc 
tuning on mickey (in a similar fashion as on minnie) for the short term.

> The edp-24m clock has two possible sources: the 24MHz oscillator as well
> as an external 27MHz input. The power-on-default is the 27MHz clock which
> is not supplied on all Rockchip boards. While on all current boards and
> also all Veyron Chromebooks the bootloader seems to adapt the muxing to
> the internal source, this doesn't seem to be the case on headless veyron
> devices like brain and mickey making the edp-24m clock an orphan.
> On the hardware side the 27m input also is not connected at all.
> 
> With the upcoming deferral of orphan-clocks this results in the power-
> domain code deferring, as it cannot request the needed clock and if the
> synchronous reset is sucessfullat all in this case is also unknown.
> 
> So fix that by making sure, the edp-24m clock is muxed to the internal
> 24MHz oscillator at all times.
> 
> Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>
> ---
> It seems I had some issues sending, sorry about the double-mails.
> 
>  arch/arm/boot/dts/rk3288-veyron.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi
> b/arch/arm/boot/dts/rk3288-veyron.dtsi index 5e61f07..9fce91f 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -340,6 +340,11 @@
>  	i2c-scl-rising-time-ns = <1000>;
>  };
> 
> +&power {
> +	assigned-clocks = <&cru SCLK_EDP_24M>;
> +	assigned-clock-parents = <&xin24m>;
> +};
> +
>  &pwm1 {
>  	status = "okay";
>  };

  parent reply	other threads:[~2015-12-03 15:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-01 17:14 [PATCH 1/3] ARM: dts: rockchip: make sure edp_24m is associated to xin24m on veyron Heiko Stübner
2015-12-01 17:14 ` Heiko Stübner
2015-12-01 17:16 ` [PATCH 2/3] ARM: dts: rockchip: add veyron-brain board Heiko Stübner
2015-12-01 17:16   ` Heiko Stübner
2015-12-02 18:26   ` Brian Norris
2015-12-02 18:26     ` Brian Norris
2015-12-01 17:16 ` [PATCH 3/3] ARM: dts: rockchip: add veyron-minnie board Heiko Stübner
2015-12-01 17:16   ` Heiko Stübner
2015-12-01 17:19   ` Heiko Stübner
2015-12-01 17:19     ` Heiko Stübner
2015-12-02 18:31   ` Brian Norris
2015-12-02 18:31     ` Brian Norris
2015-12-03 10:27   ` Caesar Wang
2015-12-03 10:27     ` Caesar Wang
     [not found]     ` <5660190F.6080204-9Onoh4P/yGk@public.gmane.org>
2015-12-03 10:44       ` Heiko Stübner
2015-12-03 10:44         ` Heiko Stübner
2015-12-03 11:01         ` Caesar Wang
2015-12-03 11:01           ` Caesar Wang
     [not found]           ` <566020EC.7060606-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-12-03 14:00             ` Heiko Stübner
2015-12-03 14:00               ` Heiko Stübner
2015-12-03 15:43 ` Heiko Stübner [this message]
2015-12-03 15:43   ` [PATCH 1/3] ARM: dts: rockchip: make sure edp_24m is associated to xin24m on veyron Heiko Stübner
  -- strict thread matches above, loose matches on Subject: below --
2015-12-01 17:13 Heiko Stübner
2015-12-01 17:13 ` Heiko Stübner
2015-12-01 17:12 Heiko Stübner
2015-12-01 17:12 ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3006808.mS23SN11BJ@diego \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=amstan-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.