From: Heiko Stuebner <heiko@sntech.de>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Emil Renner Berthing <kernel@esmil.dk>,
Hal Feng <hal.feng@starfivetech.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Dominique Belhachemi <db@domibel.de>, Andy Yan <andyshrk@163.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Yakir Yang <kuankuan.y@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Michal Wilczynski <m.wilczynski@samsung.com>,
Conor Dooley <conor@kernel.org>,
William Qiu <william.qiu@starfivetech.com>,
Xingyu Wu <xingyu.wu@starfivetech.com>,
Sandy Huang <hjc@rock-chips.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Michal Wilczynski <m.wilczynski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Maud Spierings" <maud_spierings@murena.io>,
"Graham Markall" <hello@big-grey.co.uk>,
"Icenowy Zheng" <zhengxingda@iscas.ac.cn>,
"Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
"Joshua Peisach" <jpeisach@ubuntu.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Byron Stanoszek" <gandalf@winds.org>,
OOHehir <oo.hehir@gmail.com>
Subject: Re: [PATCH v6 01/18] drm/bridge: inno-hdmi: fix swapped HSYNC and VSYNC polarity
Date: Fri, 30 Oct 2026 18:38:51 +0100 [thread overview]
Message-ID: <3007313.yaVYbkx8dN@phil> (raw)
In-Reply-To: <20261029-jh7110-clean-send-v6-1-759594e43acf@samsung.com>
Am Donnerstag, 29. Oktober 2026, 08:53:35 Mitteleuropäische Normalzeit schrieb Michal Wilczynski:
> v_HSYNC_POLARITY() and v_VSYNC_POLARITY() write the wrong bits: the
> hardware puts HSYNC in bit 2 and VSYNC in bit 3, the macros do the
> opposite. Most CEA modes drive both syncs with the same polarity so it
> goes unnoticed; it only shows up on modes where the two differ.
>
> Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
> Reported-by: Maud Spierings <maud_spierings@murena.io>
> Closes: https://lore.kernel.org/all/e780ecb8-918f-4816-99c8-b69b10b25a18@murena.io/
> Reported-by: Byron Stanoszek <gandalf@winds.org>
> Closes: https://lore.kernel.org/all/b8b046ee-c574-3e16-6079-2fc415633dae@winds.org/
> Suggested-by: Dominique Belhachemi <db@domibel.de>
> Tested-by: Maud Spierings <maud_spierings@murena.io>
> Tested-by: Byron Stanoszek <gandalf@winds.org>
> Tested-by: OOHehir <oo.hehir@gmail.com>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
RK3036 TRM agrees with this assesment :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Emil Renner Berthing <kernel@esmil.dk>,
Hal Feng <hal.feng@starfivetech.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Dominique Belhachemi <db@domibel.de>, Andy Yan <andyshrk@163.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Yakir Yang <kuankuan.y@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Michal Wilczynski <m.wilczynski@samsung.com>,
Conor Dooley <conor@kernel.org>,
William Qiu <william.qiu@starfivetech.com>,
Xingyu Wu <xingyu.wu@starfivetech.com>,
Sandy Huang <hjc@rock-chips.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Michal Wilczynski <m.wilczynski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Maud Spierings" <maud_spierings@murena.io>,
"Graham Markall" <hello@big-grey.co.uk>,
"Icenowy Zheng" <zhengxingda@iscas.ac.cn>,
"Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
"Joshua Peisach" <jpeisach@ubuntu.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Byron Stanoszek" <gandalf@winds.org>,
OOHehir <oo.hehir@gmail.com>
Subject: Re: [PATCH v6 01/18] drm/bridge: inno-hdmi: fix swapped HSYNC and VSYNC polarity
Date: Fri, 30 Oct 2026 18:38:51 +0100 [thread overview]
Message-ID: <3007313.yaVYbkx8dN@phil> (raw)
In-Reply-To: <20261029-jh7110-clean-send-v6-1-759594e43acf@samsung.com>
Am Donnerstag, 29. Oktober 2026, 08:53:35 Mitteleuropäische Normalzeit schrieb Michal Wilczynski:
> v_HSYNC_POLARITY() and v_VSYNC_POLARITY() write the wrong bits: the
> hardware puts HSYNC in bit 2 and VSYNC in bit 3, the macros do the
> opposite. Most CEA modes drive both syncs with the same polarity so it
> goes unnoticed; it only shows up on modes where the two differ.
>
> Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
> Reported-by: Maud Spierings <maud_spierings@murena.io>
> Closes: https://lore.kernel.org/all/e780ecb8-918f-4816-99c8-b69b10b25a18@murena.io/
> Reported-by: Byron Stanoszek <gandalf@winds.org>
> Closes: https://lore.kernel.org/all/b8b046ee-c574-3e16-6079-2fc415633dae@winds.org/
> Suggested-by: Dominique Belhachemi <db@domibel.de>
> Tested-by: Maud Spierings <maud_spierings@murena.io>
> Tested-by: Byron Stanoszek <gandalf@winds.org>
> Tested-by: OOHehir <oo.hehir@gmail.com>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
RK3036 TRM agrees with this assesment :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Emil Renner Berthing <kernel@esmil.dk>,
Hal Feng <hal.feng@starfivetech.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Dominique Belhachemi <db@domibel.de>, Andy Yan <andyshrk@163.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Yakir Yang <kuankuan.y@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Michal Wilczynski <m.wilczynski@samsung.com>,
Conor Dooley <conor@kernel.org>,
William Qiu <william.qiu@starfivetech.com>,
Xingyu Wu <xingyu.wu@starfivetech.com>,
Sandy Huang <hjc@rock-chips.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Michal Wilczynski <m.wilczynski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Maud Spierings" <maud_spierings@murena.io>,
"Graham Markall" <hello@big-grey.co.uk>,
"Icenowy Zheng" <zhengxingda@iscas.ac.cn>,
"Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
"Joshua Peisach" <jpeisach@ubuntu.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Byron Stanoszek" <gandalf@winds.org>,
OOHehir <oo.hehir@gmail.com>
Subject: Re: [PATCH v6 01/18] drm/bridge: inno-hdmi: fix swapped HSYNC and VSYNC polarity
Date: Fri, 30 Oct 2026 18:38:51 +0100 [thread overview]
Message-ID: <3007313.yaVYbkx8dN@phil> (raw)
In-Reply-To: <20261029-jh7110-clean-send-v6-1-759594e43acf@samsung.com>
Am Donnerstag, 29. Oktober 2026, 08:53:35 Mitteleuropäische Normalzeit schrieb Michal Wilczynski:
> v_HSYNC_POLARITY() and v_VSYNC_POLARITY() write the wrong bits: the
> hardware puts HSYNC in bit 2 and VSYNC in bit 3, the macros do the
> opposite. Most CEA modes drive both syncs with the same polarity so it
> goes unnoticed; it only shows up on modes where the two differ.
>
> Fixes: 412d4ae6b7a5 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
> Reported-by: Maud Spierings <maud_spierings@murena.io>
> Closes: https://lore.kernel.org/all/e780ecb8-918f-4816-99c8-b69b10b25a18@murena.io/
> Reported-by: Byron Stanoszek <gandalf@winds.org>
> Closes: https://lore.kernel.org/all/b8b046ee-c574-3e16-6079-2fc415633dae@winds.org/
> Suggested-by: Dominique Belhachemi <db@domibel.de>
> Tested-by: Maud Spierings <maud_spierings@murena.io>
> Tested-by: Byron Stanoszek <gandalf@winds.org>
> Tested-by: OOHehir <oo.hehir@gmail.com>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
RK3036 TRM agrees with this assesment :-)
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-10-30 17:39 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20261029075352eucas1p28bb0b14e03ab247dfbbee4843e1332ba@eucas1p2.samsung.com>
2026-10-29 7:53 ` [PATCH v6 00/18] drm: starfive: jh7110: Enable display subsystem Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 01/18] drm/bridge: inno-hdmi: fix swapped HSYNC and VSYNC polarity Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-30 17:38 ` Heiko Stuebner [this message]
2026-10-30 17:38 ` Heiko Stuebner
2026-10-30 17:38 ` Heiko Stuebner
2026-10-29 7:53 ` [PATCH v6 02/18] drm/bridge: inno-hdmi: Don't dereference a NULL drm_device on hotplug Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-30 17:43 ` Heiko Stuebner
2026-10-30 17:43 ` Heiko Stuebner
2026-10-30 17:43 ` Heiko Stuebner
2026-10-30 17:44 ` Heiko Stuebner
2026-10-30 17:44 ` Heiko Stuebner
2026-10-30 17:44 ` Heiko Stuebner
2026-10-29 7:53 ` [PATCH v6 03/18] dt-bindings: display: bridge: Add starfive,jh7110-inno-hdmi-controller Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 04/18] dt-bindings: soc: starfive: Add starfive,jh7110-hdmi-subsystem Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 17:38 ` Rob Herring (Arm)
2026-10-29 17:38 ` Rob Herring (Arm)
2026-10-29 17:38 ` Rob Herring (Arm)
2026-10-29 17:53 ` Michal Wilczynski
2026-10-29 17:53 ` Michal Wilczynski
2026-10-29 17:53 ` Michal Wilczynski
2026-10-29 18:30 ` Rob Herring
2026-10-29 18:30 ` Rob Herring
2026-10-29 18:30 ` Rob Herring
2026-10-29 23:06 ` Conor Dooley
2026-10-29 23:06 ` Conor Dooley
2026-10-29 23:06 ` Conor Dooley
2026-10-29 7:53 ` [PATCH v6 05/18] dt-bindings: soc: starfive: Add starfive,jh7110-vout-syscon Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 06/18] dt-bindings: display: verisilicon: Add starfive,jh7110-dc8200 Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 07/18] dt-bindings: soc: starfive: Add starfive,jh7110-vout-subsystem Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 08/18] drm/bridge: inno-hdmi: Split probe out of bind Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 09/18] drm/bridge: inno-hdmi: Allow the register map to come from a parent Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-30 18:01 ` Heiko Stuebner
2026-10-30 18:01 ` Heiko Stuebner
2026-10-30 18:01 ` Heiko Stuebner
2026-10-29 7:53 ` [PATCH v6 10/18] drm/bridge: inno-hdmi: Add .disable platform operation Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 11/18] drm/bridge: inno-hdmi: Add .mode_valid " Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 12/18] drm/bridge: inno-hdmi: Make the PHY configuration table optional Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 13/18] drm/bridge: inno-hdmi: Make the register clock source selectable Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 14/18] soc: starfive: Add jh7110-hdmi-subsystem driver Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 15/18] soc: starfive: Add jh7110-vout-subsystem driver Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 16/18] drm/bridge: starfive: Add JH7110 HDMI controller driver Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 17/18] riscv: dts: starfive: jh7110: Update DT for display subsystem Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` [PATCH v6 18/18] MAINTAINERS: Add StarFive JH7110 display subsystem entry Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
2026-10-29 7:53 ` Michal Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3007313.yaVYbkx8dN@phil \
--to=heiko@sntech.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alex@ghiti.fr \
--cc=andrzej.hajda@intel.com \
--cc=andyshrk@163.com \
--cc=aou@eecs.berkeley.edu \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor@kernel.org \
--cc=db@domibel.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gandalf@winds.org \
--cc=hal.feng@starfivetech.com \
--cc=hello@big-grey.co.uk \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jpeisach@ubuntu.com \
--cc=kernel@esmil.dk \
--cc=krzk+dt@kernel.org \
--cc=kuankuan.y@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=m.wilczynski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=maud_spierings@murena.io \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=oo.hehir@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=william.qiu@starfivetech.com \
--cc=xingyu.wu@starfivetech.com \
--cc=zhengxingda@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.