From: Marc Zyngier <maz@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Peter Shier <pshier@google.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] selftests: KVM: aarch64: Let hypercalls use UAPI *_BIT_COUNT
Date: Sun, 15 May 2022 11:40:00 +0100 [thread overview]
Message-ID: <3015731497c79a051779ce531155e5b5@kernel.org> (raw)
In-Reply-To: <688a817f-b2e2-4620-ef4b-f3c5f73ae34d@redhat.com>
On 2022-05-05 14:32, Paolo Bonzini wrote:
> On 5/5/22 14:04, Marc Zyngier wrote:
>> diff --git a/arch/arm64/include/uapi/asm/kvm.h
>> b/arch/arm64/include/uapi/asm/kvm.h
>> index e523bb6eac67..3cde9f958eee 100644
>> --- a/arch/arm64/include/uapi/asm/kvm.h
>> +++ b/arch/arm64/include/uapi/asm/kvm.h
>> @@ -342,6 +342,10 @@ struct kvm_arm_copy_mte_tags {
>> enum {
>> KVM_REG_ARM_STD_BIT_TRNG_V1_0 = 0,
>> + /*
>> + * KVM_REG_ARM_STD_BMAP_BIT_COUNT will vary as new services
>> + * are added, and is explicitely not part of the ABI.
>> + */
>> KVM_REG_ARM_STD_BMAP_BIT_COUNT,
>> };
>
> That seems like a bad idea. Perhaps you can wrap it in #ifdef
> __KERNEL_OR_SELFTESTS__? I can't find any prior art.
Yeah. I've dropped this patch and sprinkled a bunch of
'#ifdef __KERNEL__' instead. We can revisit this later,
or hack the test to temporarily define __KERNEL__, which
is just as bad...
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Oliver Upton <oupton@google.com>,
Raghavendra Rao Ananta <rananta@google.com>,
Andrew Jones <drjones@redhat.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Peter Shier <pshier@google.com>,
Ricardo Koller <ricarkol@google.com>,
Reiji Watanabe <reijiw@google.com>,
Jing Zhang <jingzhangos@google.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: KVM: aarch64: Let hypercalls use UAPI *_BIT_COUNT
Date: Sun, 15 May 2022 11:40:00 +0100 [thread overview]
Message-ID: <3015731497c79a051779ce531155e5b5@kernel.org> (raw)
In-Reply-To: <688a817f-b2e2-4620-ef4b-f3c5f73ae34d@redhat.com>
On 2022-05-05 14:32, Paolo Bonzini wrote:
> On 5/5/22 14:04, Marc Zyngier wrote:
>> diff --git a/arch/arm64/include/uapi/asm/kvm.h
>> b/arch/arm64/include/uapi/asm/kvm.h
>> index e523bb6eac67..3cde9f958eee 100644
>> --- a/arch/arm64/include/uapi/asm/kvm.h
>> +++ b/arch/arm64/include/uapi/asm/kvm.h
>> @@ -342,6 +342,10 @@ struct kvm_arm_copy_mte_tags {
>> enum {
>> KVM_REG_ARM_STD_BIT_TRNG_V1_0 = 0,
>> + /*
>> + * KVM_REG_ARM_STD_BMAP_BIT_COUNT will vary as new services
>> + * are added, and is explicitely not part of the ABI.
>> + */
>> KVM_REG_ARM_STD_BMAP_BIT_COUNT,
>> };
>
> That seems like a bad idea. Perhaps you can wrap it in #ifdef
> __KERNEL_OR_SELFTESTS__? I can't find any prior art.
Yeah. I've dropped this patch and sprinkled a bunch of
'#ifdef __KERNEL__' instead. We can revisit this later,
or hack the test to temporarily define __KERNEL__, which
is just as bad...
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Oliver Upton <oupton@google.com>,
Raghavendra Rao Ananta <rananta@google.com>,
Andrew Jones <drjones@redhat.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Peter Shier <pshier@google.com>,
Ricardo Koller <ricarkol@google.com>,
Reiji Watanabe <reijiw@google.com>,
Jing Zhang <jingzhangos@google.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: KVM: aarch64: Let hypercalls use UAPI *_BIT_COUNT
Date: Sun, 15 May 2022 11:40:00 +0100 [thread overview]
Message-ID: <3015731497c79a051779ce531155e5b5@kernel.org> (raw)
In-Reply-To: <688a817f-b2e2-4620-ef4b-f3c5f73ae34d@redhat.com>
On 2022-05-05 14:32, Paolo Bonzini wrote:
> On 5/5/22 14:04, Marc Zyngier wrote:
>> diff --git a/arch/arm64/include/uapi/asm/kvm.h
>> b/arch/arm64/include/uapi/asm/kvm.h
>> index e523bb6eac67..3cde9f958eee 100644
>> --- a/arch/arm64/include/uapi/asm/kvm.h
>> +++ b/arch/arm64/include/uapi/asm/kvm.h
>> @@ -342,6 +342,10 @@ struct kvm_arm_copy_mte_tags {
>> enum {
>> KVM_REG_ARM_STD_BIT_TRNG_V1_0 = 0,
>> + /*
>> + * KVM_REG_ARM_STD_BMAP_BIT_COUNT will vary as new services
>> + * are added, and is explicitely not part of the ABI.
>> + */
>> KVM_REG_ARM_STD_BMAP_BIT_COUNT,
>> };
>
> That seems like a bad idea. Perhaps you can wrap it in #ifdef
> __KERNEL_OR_SELFTESTS__? I can't find any prior art.
Yeah. I've dropped this patch and sprinkled a bunch of
'#ifdef __KERNEL__' instead. We can revisit this later,
or hack the test to temporarily define __KERNEL__, which
is just as bad...
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-15 10:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 18:44 [PATCH] selftests: KVM: aarch64: Let hypercalls use UAPI *_BIT_COUNT Raghavendra Rao Ananta
2022-05-04 18:44 ` Raghavendra Rao Ananta
2022-05-04 18:44 ` Raghavendra Rao Ananta
2022-05-04 19:58 ` Oliver Upton
2022-05-04 19:58 ` Oliver Upton
2022-05-04 19:58 ` Oliver Upton
2022-05-05 12:04 ` Marc Zyngier
2022-05-05 12:04 ` Marc Zyngier
2022-05-05 12:04 ` Marc Zyngier
2022-05-05 13:32 ` Paolo Bonzini
2022-05-05 13:32 ` Paolo Bonzini
2022-05-05 13:32 ` Paolo Bonzini
2022-05-15 10:40 ` Marc Zyngier [this message]
2022-05-15 10:40 ` Marc Zyngier
2022-05-15 10:40 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3015731497c79a051779ce531155e5b5@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.