* [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers
@ 2025-03-14 7:57 Andy Yan
2025-04-03 1:49 ` Andy Yan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andy Yan @ 2025-03-14 7:57 UTC (permalink / raw)
To: lumag
Cc: cristian.ciocaltea, mripard, neil.armstrong, dri-devel,
linux-kernel, heiko, Andy Yan
From: Andy Yan <andy.yan@rock-chips.com>
It is not recommended for drivers to include UAPI header
directly.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 0890add5f707..306e09a24a1c 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -22,8 +22,8 @@
#include <media/cec-notifier.h>
-#include <uapi/linux/media-bus-format.h>
-#include <uapi/linux/videodev2.h>
+#include <linux/media-bus-format.h>
+#include <linux/videodev2.h>
#include <drm/bridge/dw_hdmi.h>
#include <drm/display/drm_hdmi_helper.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re:[PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers
2025-03-14 7:57 [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers Andy Yan
@ 2025-04-03 1:49 ` Andy Yan
2025-04-10 12:51 ` [PATCH] " Heiko Stübner
2025-04-14 7:37 ` neil.armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Andy Yan @ 2025-04-03 1:49 UTC (permalink / raw)
To: lumag
Cc: cristian.ciocaltea, mripard, neil.armstrong, dri-devel,
linux-kernel, heiko, Andy Yan, dmitry.baryshkov
Gentle ping......
At 2025-03-14 15:57:47, "Andy Yan" <andyshrk@163.com> wrote:
>From: Andy Yan <andy.yan@rock-chips.com>
>
>It is not recommended for drivers to include UAPI header
>directly.
>
>Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>---
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>index 0890add5f707..306e09a24a1c 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>@@ -22,8 +22,8 @@
>
> #include <media/cec-notifier.h>
>
>-#include <uapi/linux/media-bus-format.h>
>-#include <uapi/linux/videodev2.h>
>+#include <linux/media-bus-format.h>
>+#include <linux/videodev2.h>
>
> #include <drm/bridge/dw_hdmi.h>
> #include <drm/display/drm_hdmi_helper.h>
>--
>2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers
2025-03-14 7:57 [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers Andy Yan
2025-04-03 1:49 ` Andy Yan
@ 2025-04-10 12:51 ` Heiko Stübner
2025-04-14 7:37 ` neil.armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2025-04-10 12:51 UTC (permalink / raw)
To: lumag, Andy Yan
Cc: cristian.ciocaltea, mripard, neil.armstrong, dri-devel,
linux-kernel, Andy Yan
Hi Andy,
Am Freitag, 14. März 2025, 08:57:47 Mitteleuropäische Sommerzeit schrieb Andy Yan:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> It is not recommended for drivers to include UAPI header
> directly.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
But looking at
scripts/get_maintainer.pl -f drivers/gpu/drm/bridge
it seems like your cc-list is missing bridge people:
Andrzej Hajda <andrzej.hajda@intel.com> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Neil Armstrong <neil.armstrong@linaro.org> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Robert Foss <rfoss@kernel.org> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Laurent Pinchart <Laurent.pinchart@ideasonboard.com> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
Jonas Karlman <jonas@kwiboo.se> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
Jernej Skrabec <jernej.skrabec@gmail.com> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
> ---
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 0890add5f707..306e09a24a1c 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -22,8 +22,8 @@
>
> #include <media/cec-notifier.h>
>
> -#include <uapi/linux/media-bus-format.h>
> -#include <uapi/linux/videodev2.h>
> +#include <linux/media-bus-format.h>
> +#include <linux/videodev2.h>
>
> #include <drm/bridge/dw_hdmi.h>
> #include <drm/display/drm_hdmi_helper.h>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers
2025-03-14 7:57 [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers Andy Yan
2025-04-03 1:49 ` Andy Yan
2025-04-10 12:51 ` [PATCH] " Heiko Stübner
@ 2025-04-14 7:37 ` neil.armstrong
2 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2025-04-14 7:37 UTC (permalink / raw)
To: Andy Yan, lumag
Cc: cristian.ciocaltea, mripard, dri-devel, linux-kernel, heiko,
Andy Yan
On 14/03/2025 08:57, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
>
> It is not recommended for drivers to include UAPI header
> directly.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 0890add5f707..306e09a24a1c 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -22,8 +22,8 @@
>
> #include <media/cec-notifier.h>
>
> -#include <uapi/linux/media-bus-format.h>
> -#include <uapi/linux/videodev2.h>
> +#include <linux/media-bus-format.h>
> +#include <linux/videodev2.h>
>
> #include <drm/bridge/dw_hdmi.h>
> #include <drm/display/drm_hdmi_helper.h>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-14 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 7:57 [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers Andy Yan
2025-04-03 1:49 ` Andy Yan
2025-04-10 12:51 ` [PATCH] " Heiko Stübner
2025-04-14 7:37 ` neil.armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.