Re: make check as superuser leaves empty directories in /-directory

[Thomas Schmitt via Grub-devel <grub-devel@gnu.org>]

Hi,

with the freshly submitted patch applied, i see as superuser:

  # make check TESTS=grub_cmd_cryptomount
  ...
  PASS: grub_cmd_cryptomount
  ...
  # echo $?
  0
  #

No new directories appeared in the root directory. During the "make check"
run i could spot single files /tmp/*LUKS* which did not exist any more
soon after.

By help of Greg Wooledge on debian-user mailing i was able to find the
description of ${TMPDIR=/tmp} in man bash and man dash.
"=" sets the variable to /tmp only if TMPDIR is not set.
":=" sets also if it is set to empty text.

The use of TMPDIR in tests/ is mainly made safe by ${TMPDIR:-/tmp}, not
by ${TMPDIR-/tmp}. So i deem ${TMPDIR:=/tmp} the right thing to do,
if not every expansion of $TMPDIR shall be made safe individually.

If the gnulib tests are run by "make check", then one should review
the use of ${TMPDIR=/tmp} in
  ./gnulib/tests/test-copy-acl.sh
  ./gnulib/tests/test-file-has-acl.sh
  ./gnulib/tests/test-set-mode-acl.sh
  ./gnulib/tests/test-copy-file.sh
  ./gnulib/tests/test-parse-duration.sh


Have a nice day :)

Thomas


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel