Re: make check as superuser leaves empty directories in /-directory

[Thomas Schmitt via Grub-devel <grub-devel@gnu.org>]

Hi,

i believe to have found out what's wrong with TMPDIR in
  tests/grub_cmd_cryptomount.in

It does not get assigned a default value and is used without such a
value. Many other tests have the following gesture before using $TMPDIR:

  : "${TMPDIR=/tmp}"

But grub_cmd_cryptomount.in has not and uses ${TMPDIR:-/tmp} only at a
single occasion when running mktemp. The mkdir step is without such a
safety net:

  mkdir -p "$TMPDIR"


I fail to find this special expansion ${X=Y} in man bash, but experiments
show that it works like {X:=Y} with the difference that a defined empty X
is not filled with "Y".

(I do not think that this respecting of empty set variables is desirable
in GRUB tests. Empty TMPDIR is bad regardless of being set or unset.)


Have a nice day :)

Thomas


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel