Re: [PATCH 05/11] mmc: tmio: Fix DMA source address

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Morimoto-san,

Thank you for the review.

On Tuesday 15 July 2014 18:39:04 Kuninori Morimoto wrote:
> Hi Laurent
> 
> > DMA reads from the data buffer register must be offset by 0x2000
> > according to the hardware documentation.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  drivers/mmc/host/tmio_mmc_dma.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mmc/host/tmio_mmc_dma.c
> > b/drivers/mmc/host/tmio_mmc_dma.c index eb8f1d5..4da7be1 100644
> > --- a/drivers/mmc/host/tmio_mmc_dma.c
> > +++ b/drivers/mmc/host/tmio_mmc_dma.c
> > @@ -312,7 +312,7 @@ void tmio_mmc_request_dma(struct tmio_mmc_host *host,
> > struct tmio_mmc_data *pdat> 
> >  		if (pdata->dma->chan_priv_rx)
> >  		
> >  			cfg.slave_id = pdata->dma->slave_id_rx;
> >  		
> >  		cfg.direction = DMA_DEV_TO_MEM;
> > 
> > -		cfg.src_addr = cfg.dst_addr;
> > +		cfg.src_addr = cfg.dst_addr + 0x2000;
> > 
> >  		cfg.src_addr_width = DMA_SLAVE_BUSWIDTH_2_BYTES;
> >  		cfg.dst_addr = 0;
> >  		ret = dmaengine_slave_config(host->chan_rx, &cfg);
> 
> Unfortunately, this patch breaks compatibility.
> This "+ 0x2000" is required only from Renesas R-Car.
> I alreay sent this fixup patch before (not accepted yet, and I will re-send
> v2 patch soon)
> 
> https://www.mail-archive.com/linux-mmc@vger.kernel.org/msg26776.html

I've applied your patch locally, thank you. You can add my Acked-by line to 
v2. When do you plan to push it to mainline ?

-- 
Regards,

Laurent Pinchart