Re: [PATCH 1/1] omap3isp: Handle omap3isp_csi2_reset() errors

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thanks for the patch.

On Friday 02 March 2012 18:03:01 Sakari Ailus wrote:
> Handle errors from omap3isp_csi2_reset() in omap3isp_csiphy_acquire().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Applied to my tree with fuzz fixed (as the patch is based on top of your 
SMIA++ patches).

> ---
>  drivers/media/video/omap3isp/ispcsiphy.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/omap3isp/ispcsiphy.c
> b/drivers/media/video/omap3isp/ispcsiphy.c index 902477d..a53f457 100644
> --- a/drivers/media/video/omap3isp/ispcsiphy.c
> +++ b/drivers/media/video/omap3isp/ispcsiphy.c
> @@ -213,7 +213,9 @@ int omap3isp_csiphy_acquire(struct isp_csiphy *phy)
>  	if (rval < 0)
>  		goto done;
> 
> -	omap3isp_csi2_reset(phy->csi2);
> +	rval = omap3isp_csi2_reset(phy->csi2);
> +	if (rval < 0)
> +		goto done;
> 
>  	rval = omap3isp_csiphy_config(phy);
>  	if (rval < 0)

-- 
Regards,

Laurent Pinchart