* [PATCH 1/1] omap3isp: Handle omap3isp_csi2_reset() errors
@ 2012-03-02 16:03 Sakari Ailus
2012-03-02 18:14 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2012-03-02 16:03 UTC (permalink / raw)
To: linux-media; +Cc: laurent.pinchart
Handle errors from omap3isp_csi2_reset() in omap3isp_csiphy_acquire().
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
---
drivers/media/video/omap3isp/ispcsiphy.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/omap3isp/ispcsiphy.c b/drivers/media/video/omap3isp/ispcsiphy.c
index 902477d..a53f457 100644
--- a/drivers/media/video/omap3isp/ispcsiphy.c
+++ b/drivers/media/video/omap3isp/ispcsiphy.c
@@ -213,7 +213,9 @@ int omap3isp_csiphy_acquire(struct isp_csiphy *phy)
if (rval < 0)
goto done;
- omap3isp_csi2_reset(phy->csi2);
+ rval = omap3isp_csi2_reset(phy->csi2);
+ if (rval < 0)
+ goto done;
rval = omap3isp_csiphy_config(phy);
if (rval < 0)
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] omap3isp: Handle omap3isp_csi2_reset() errors
2012-03-02 16:03 [PATCH 1/1] omap3isp: Handle omap3isp_csi2_reset() errors Sakari Ailus
@ 2012-03-02 18:14 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2012-03-02 18:14 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media
Hi Sakari,
Thanks for the patch.
On Friday 02 March 2012 18:03:01 Sakari Ailus wrote:
> Handle errors from omap3isp_csi2_reset() in omap3isp_csiphy_acquire().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Applied to my tree with fuzz fixed (as the patch is based on top of your
SMIA++ patches).
> ---
> drivers/media/video/omap3isp/ispcsiphy.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/omap3isp/ispcsiphy.c
> b/drivers/media/video/omap3isp/ispcsiphy.c index 902477d..a53f457 100644
> --- a/drivers/media/video/omap3isp/ispcsiphy.c
> +++ b/drivers/media/video/omap3isp/ispcsiphy.c
> @@ -213,7 +213,9 @@ int omap3isp_csiphy_acquire(struct isp_csiphy *phy)
> if (rval < 0)
> goto done;
>
> - omap3isp_csi2_reset(phy->csi2);
> + rval = omap3isp_csi2_reset(phy->csi2);
> + if (rval < 0)
> + goto done;
>
> rval = omap3isp_csiphy_config(phy);
> if (rval < 0)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-02 18:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 16:03 [PATCH 1/1] omap3isp: Handle omap3isp_csi2_reset() errors Sakari Ailus
2012-03-02 18:14 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.