From: "Rémi Denis-Courmont" <remi@remlab.net>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
suzuki.poulose@arm.com, linux-kernel@vger.kernel.org,
james.morse@arm.com, maz@kernel.org, will@kernel.org,
julien.thierry.kdev@gmail.com
Subject: Re: [PATCH] arm64: move kimage_vaddr to .rodata
Date: Mon, 16 Mar 2020 12:32:30 +0200 [thread overview]
Message-ID: <3096066.EsygCdbVZz@basile.remlab.net> (raw)
In-Reply-To: <20200312164035.GA21120@lakrids.cambridge.arm.com>
Le torstaina 12. maaliskuuta 2020, 18.40.36 EET Mark Rutland a écrit :
> On Thu, Mar 12, 2020 at 11:40:02AM +0200, Rémi Denis-Courmont wrote:
> > From: Remi Denis-Courmont <remi.denis.courmont@huawei.com>
> >
> > This datum is not referenced from .idmap.text: it does not need to be
> > mapped in idmap. Lets move it to .rodata as it is never written to after
> > early boot of the primary CPU.
> > (Maybe .data.ro_after_init would be cleaner though?)
>
> Can we move this into arch/arm64/mm/mmu.c, where we already have
>
> kimage_voffset:
> | u64 kimage_voffset __ro_after_init;
> | EXPORT_SYMBOL(kimage_voffset);
>
> ... or is it not possible to initialize kimage_vaddr correctly in C?
Currently TEXT_OFFSET is defined by the Makefile only for assembler sources and
the linker script. So that would need to be exposed to CPPFLAGS as well.
--
Реми Дёни-Курмон
http://www.remlab.net/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Rémi Denis-Courmont" <remi@remlab.net>
To: linux-arm-kernel@lists.infradead.org
Cc: Mark Rutland <mark.rutland@arm.com>,
suzuki.poulose@arm.com, catalin.marinas@arm.com,
ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org,
james.morse@arm.com, julien.thierry.kdev@gmail.com,
maz@kernel.org, will@kernel.org
Subject: Re: [PATCH] arm64: move kimage_vaddr to .rodata
Date: Mon, 16 Mar 2020 12:32:30 +0200 [thread overview]
Message-ID: <3096066.EsygCdbVZz@basile.remlab.net> (raw)
In-Reply-To: <20200312164035.GA21120@lakrids.cambridge.arm.com>
Le torstaina 12. maaliskuuta 2020, 18.40.36 EET Mark Rutland a écrit :
> On Thu, Mar 12, 2020 at 11:40:02AM +0200, Rémi Denis-Courmont wrote:
> > From: Remi Denis-Courmont <remi.denis.courmont@huawei.com>
> >
> > This datum is not referenced from .idmap.text: it does not need to be
> > mapped in idmap. Lets move it to .rodata as it is never written to after
> > early boot of the primary CPU.
> > (Maybe .data.ro_after_init would be cleaner though?)
>
> Can we move this into arch/arm64/mm/mmu.c, where we already have
>
> kimage_voffset:
> | u64 kimage_voffset __ro_after_init;
> | EXPORT_SYMBOL(kimage_voffset);
>
> ... or is it not possible to initialize kimage_vaddr correctly in C?
Currently TEXT_OFFSET is defined by the Makefile only for assembler sources and
the linker script. So that would need to be exposed to CPPFLAGS as well.
--
Реми Дёни-Курмон
http://www.remlab.net/
next prev parent reply other threads:[~2020-03-16 10:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 9:40 [PATCH] arm64: move kimage_vaddr to .rodata Rémi Denis-Courmont
2020-03-12 9:40 ` Rémi Denis-Courmont
2020-03-12 9:40 ` Rémi Denis-Courmont
2020-03-12 16:40 ` Mark Rutland
2020-03-12 16:40 ` Mark Rutland
2020-03-12 16:40 ` Mark Rutland
2020-03-12 16:42 ` Remi Denis-Courmont
2020-03-12 16:42 ` Remi Denis-Courmont
2020-03-12 16:42 ` Remi Denis-Courmont
2020-03-16 10:32 ` Rémi Denis-Courmont [this message]
2020-03-16 10:32 ` Rémi Denis-Courmont
2020-03-17 22:26 ` Will Deacon
2020-03-17 22:26 ` Will Deacon
2020-03-17 22:26 ` Will Deacon
2020-03-20 18:24 ` Catalin Marinas
2020-03-20 18:24 ` Catalin Marinas
2020-03-20 18:24 ` Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2020-03-12 9:38 Rémi Denis-Courmont
2020-03-12 9:38 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3096066.EsygCdbVZz@basile.remlab.net \
--to=remi@remlab.net \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.