From: Peter Wu <peter@lekensteyn.nl>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] slirp/smbd: disable printer in smb config
Date: Mon, 03 Nov 2014 18:59:21 +0100 [thread overview]
Message-ID: <3098080.6ftE1k1ya5@al> (raw)
In-Reply-To: <54578DFC.3070807@msgid.tls.msk.ru>
On Monday 03 November 2014 17:15:24 Michael Tokarev wrote:
> BTW, I'm not sure `socket address' paraameter is relevant in this context
> at all, -- smbd should not use it in inetd mode. It'd be interesting to
> know why this option is here to start with, and whenever we really need
> the new interfaces/bind-interfacs-only replacement.
The socket option is unused when QEMU invokes the command directly. The
only (weak) reason why it is still there is to ease testing, such that
you can simply use:
smbd -s smb.conf -p 1337
Without the socket option, I am afraid that you will accidentally expose
the very permissive share to the network.
So either append a comment explaining the above or just remove it. I am
fine with removing the interfaces option from this patch (or in a future
patch if you prefer that).
--
Kind regards,
Peter
https://lekensteyn.nl
WARNING: multiple messages have this Message-ID (diff)
From: Peter Wu <peter@lekensteyn.nl>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Jan Kiszka <jan.kiszka@siemens.com>,
Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp/smbd: disable printer in smb config
Date: Mon, 03 Nov 2014 18:59:21 +0100 [thread overview]
Message-ID: <3098080.6ftE1k1ya5@al> (raw)
In-Reply-To: <54578DFC.3070807@msgid.tls.msk.ru>
On Monday 03 November 2014 17:15:24 Michael Tokarev wrote:
> BTW, I'm not sure `socket address' paraameter is relevant in this context
> at all, -- smbd should not use it in inetd mode. It'd be interesting to
> know why this option is here to start with, and whenever we really need
> the new interfaces/bind-interfacs-only replacement.
The socket option is unused when QEMU invokes the command directly. The
only (weak) reason why it is still there is to ease testing, such that
you can simply use:
smbd -s smb.conf -p 1337
Without the socket option, I am afraid that you will accidentally expose
the very permissive share to the network.
So either append a comment explaining the above or just remove it. I am
fine with removing the interfaces option from this patch (or in a future
patch if you prefer that).
--
Kind regards,
Peter
https://lekensteyn.nl
next prev parent reply other threads:[~2014-11-03 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 10:52 [Qemu-trivial] [PATCH] slirp/smbd: disable printer in smb config Peter Wu
2014-11-03 10:52 ` [Qemu-devel] " Peter Wu
2014-11-03 14:15 ` [Qemu-trivial] " Michael Tokarev
2014-11-03 14:15 ` [Qemu-devel] " Michael Tokarev
2014-11-03 14:19 ` Michael Tokarev
2014-11-03 14:19 ` [Qemu-devel] " Michael Tokarev
2014-11-03 17:59 ` Peter Wu [this message]
2014-11-03 17:59 ` Peter Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3098080.6ftE1k1ya5@al \
--to=peter@lekensteyn.nl \
--cc=jan.kiszka@siemens.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.