From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Mark Brown" <broonie@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>
Cc: kernel@collabora.com, Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s
Date: Mon, 31 Oct 2022 13:56:57 +0100 [thread overview]
Message-ID: <30e04ec6-3702-0b56-d475-365974fa04a6@collabora.com> (raw)
In-Reply-To: <20221028205540.3197304-9-nfraprado@collabora.com>
Il 28/10/22 22:55, Nícolas F. R. A. Prado ha scritto:
> These devicetrees override a rt5682 node to use the rt5682s compatible,
> however, unlike rt5682, rt5682s doesn't have a VBAT supply. Remove the
> inexistent supply in the rt5682s nodes.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>
> arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi | 1 +
> .../dts/qcom/sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dts | 1 +
> .../dts/qcom/sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dts | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
> index 74f0e07ea5cf..e0fb83a9a0b1 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dtsi
> @@ -11,6 +11,7 @@
>
> &alc5682 {
> compatible = "realtek,rt5682s";
> + /delete-property/ VBAT-supply;
I really dislike seeing /delete-property/ but I don't know if changing all of the
non-kingoftown and non-wormdingler devicetrees is worth the noise...
Any strong opinions on that?
Regards,
Angelo
prev parent reply other threads:[~2022-10-31 12:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: " Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek, rt5682s: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: " Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` [PATCH 5/8] ASoC: rt5682s: Support " Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 6/8] ASoC: rt5682: " Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 13:09 ` Mark Brown
2022-10-31 13:09 ` Mark Brown
2022-10-31 13:41 ` AngeloGioacchino Del Regno
2022-10-31 13:41 ` AngeloGioacchino Del Regno
2022-10-31 16:31 ` Nícolas F. R. A. Prado
2022-10-31 16:31 ` Nícolas F. R. A. Prado
2022-10-31 19:09 ` Rob Herring
2022-10-31 19:09 ` Rob Herring
2022-10-31 19:38 ` Nícolas F. R. A. Prado
2022-10-31 19:38 ` Nícolas F. R. A. Prado
2022-10-31 21:54 ` Mark Brown
2022-10-31 21:54 ` Mark Brown
2022-10-28 20:55 ` [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Nícolas F. R. A. Prado
2022-10-31 12:54 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Nícolas F. R. A. Prado
2022-10-31 12:56 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30e04ec6-3702-0b56-d475-365974fa04a6@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.