From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Mark Brown <broonie@kernel.org>, Bjorn Andersson <andersson@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
kernel@collabora.com,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies
Date: Fri, 28 Oct 2022 16:55:35 -0400 [thread overview]
Message-ID: <20221028205540.3197304-4-nfraprado@collabora.com> (raw)
In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com>
The rt5682 codec has three supplies - AVDD, MICVDD and VBAT - which are
already used by sc7180-trogdor.dtsi. Document them in the binding.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Commit adapted from [1], changes:
- Made supplies required
- Improved supplies descriptions
[1] https://lore.kernel.org/all/20221024220015.1759428-5-nfraprado@collabora.com
Documentation/devicetree/bindings/sound/rt5682.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index 6b87db68337c..89e6245b870e 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -8,6 +8,15 @@ Required properties:
- reg : The I2C address of the device.
+- AVDD-supply: phandle to the regulator supplying analog power through the
+ AVDD pin
+
+- MICVDD-supply: phandle to the regulator supplying power for the microphone
+ bias through the MICVDD pin. Either MICVDD or VBAT should be present.
+
+- VBAT-supply: phandle to the regulator supplying battery power through the
+ VBAT pin. Either MICVDD or VBAT should be present.
+
Optional properties:
- interrupts : The CODEC's interrupt output.
@@ -75,4 +84,7 @@ rt5682 {
clocks = <&osc>;
clock-names = "mclk";
+
+ AVDD-supply = <&avdd_reg>;
+ MICVDD-supply = <&micvdd_reg>;
};
--
2.38.1
WARNING: multiple messages have this Message-ID (diff)
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Mark Brown <broonie@kernel.org>, Bjorn Andersson <andersson@kernel.org>
Cc: kernel@collabora.com,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies
Date: Fri, 28 Oct 2022 16:55:35 -0400 [thread overview]
Message-ID: <20221028205540.3197304-4-nfraprado@collabora.com> (raw)
In-Reply-To: <20221028205540.3197304-1-nfraprado@collabora.com>
The rt5682 codec has three supplies - AVDD, MICVDD and VBAT - which are
already used by sc7180-trogdor.dtsi. Document them in the binding.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Commit adapted from [1], changes:
- Made supplies required
- Improved supplies descriptions
[1] https://lore.kernel.org/all/20221024220015.1759428-5-nfraprado@collabora.com
Documentation/devicetree/bindings/sound/rt5682.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index 6b87db68337c..89e6245b870e 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -8,6 +8,15 @@ Required properties:
- reg : The I2C address of the device.
+- AVDD-supply: phandle to the regulator supplying analog power through the
+ AVDD pin
+
+- MICVDD-supply: phandle to the regulator supplying power for the microphone
+ bias through the MICVDD pin. Either MICVDD or VBAT should be present.
+
+- VBAT-supply: phandle to the regulator supplying battery power through the
+ VBAT pin. Either MICVDD or VBAT should be present.
+
Optional properties:
- interrupts : The CODEC's interrupt output.
@@ -75,4 +84,7 @@ rt5682 {
clocks = <&osc>;
clock-names = "mclk";
+
+ AVDD-supply = <&avdd_reg>;
+ MICVDD-supply = <&micvdd_reg>;
};
--
2.38.1
next prev parent reply other threads:[~2022-10-28 20:57 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:55 [PATCH 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 1/8] ASoC: dt-bindings: realtek,rt5682s: " Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek, rt5682s: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 2/8] ASoC: dt-bindings: realtek,rt5682s: " Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` Nícolas F. R. A. Prado [this message]
2022-10-28 20:55 ` [PATCH 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` [PATCH 4/8] ASoC: dt-bindings: rt5682: Add dbvdd and ldo1-in supplies Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-11-03 22:26 ` Krzysztof Kozlowski
2022-10-28 20:55 ` [PATCH 5/8] ASoC: rt5682s: Support " Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 6/8] ASoC: rt5682: " Nícolas F. R. A. Prado
2022-10-28 20:55 ` Nícolas F. R. A. Prado
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 12:53 ` AngeloGioacchino Del Regno
2022-10-31 13:09 ` Mark Brown
2022-10-31 13:09 ` Mark Brown
2022-10-31 13:41 ` AngeloGioacchino Del Regno
2022-10-31 13:41 ` AngeloGioacchino Del Regno
2022-10-31 16:31 ` Nícolas F. R. A. Prado
2022-10-31 16:31 ` Nícolas F. R. A. Prado
2022-10-31 19:09 ` Rob Herring
2022-10-31 19:09 ` Rob Herring
2022-10-31 19:38 ` Nícolas F. R. A. Prado
2022-10-31 19:38 ` Nícolas F. R. A. Prado
2022-10-31 21:54 ` Mark Brown
2022-10-31 21:54 ` Mark Brown
2022-10-28 20:55 ` [PATCH 7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682 Nícolas F. R. A. Prado
2022-10-31 12:54 ` AngeloGioacchino Del Regno
2022-10-28 20:55 ` [PATCH 8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s Nícolas F. R. A. Prado
2022-10-31 12:56 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028205540.3197304-4-nfraprado@collabora.com \
--to=nfraprado@collabora.com \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.