All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	catalin.marinas@arm.com, will@kernel.org
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
	songmuchun@bytedance.com, willy@infradead.org,
	christophe.leroy@csgroup.eu,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page
Date: Sat, 14 May 2022 09:42:06 +0800	[thread overview]
Message-ID: <30e805ba-cf4d-c13c-8d34-e1b2d9e77dae@linux.alibaba.com> (raw)
In-Reply-To: <88e02de3-c87e-2728-d980-da0e70a58102@arm.com>



On 5/13/2022 6:50 PM, Anshuman Khandual wrote:
> 
> 
> On 5/13/22 09:07, Baolin Wang wrote:
>> The original huge_ptep_get() on ARM64 is just a wrapper of ptep_get(),
> 
> Right, as arm64 does not enable __HAVE_ARCH_HUGE_PTEP_GET.
> 
>> which will not take into account any contig-PTEs dirty and access bits.
> 
> As expected being operating on a single table entry.
> 
>> Meanwhile we will implement a new ARM64-specific huge_ptep_get()
>> interface in following patch, which will take into account any contig-PTEs
>> dirty and access bits. To keep the same efficient logics to get the pte
> 
> s/logics/logic

Will fix.

> 
>> value, change to use ptep_get() as a preparation.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> 
> LGTM
> 
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

Thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
	catalin.marinas@arm.com, will@kernel.org
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
	songmuchun@bytedance.com, willy@infradead.org,
	christophe.leroy@csgroup.eu,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page
Date: Sat, 14 May 2022 09:42:06 +0800	[thread overview]
Message-ID: <30e805ba-cf4d-c13c-8d34-e1b2d9e77dae@linux.alibaba.com> (raw)
In-Reply-To: <88e02de3-c87e-2728-d980-da0e70a58102@arm.com>



On 5/13/2022 6:50 PM, Anshuman Khandual wrote:
> 
> 
> On 5/13/22 09:07, Baolin Wang wrote:
>> The original huge_ptep_get() on ARM64 is just a wrapper of ptep_get(),
> 
> Right, as arm64 does not enable __HAVE_ARCH_HUGE_PTEP_GET.
> 
>> which will not take into account any contig-PTEs dirty and access bits.
> 
> As expected being operating on a single table entry.
> 
>> Meanwhile we will implement a new ARM64-specific huge_ptep_get()
>> interface in following patch, which will take into account any contig-PTEs
>> dirty and access bits. To keep the same efficient logics to get the pte
> 
> s/logics/logic

Will fix.

> 
>> value, change to use ptep_get() as a preparation.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> 
> LGTM
> 
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>

Thanks.


  reply	other threads:[~2022-05-14  1:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13  3:37 [PATCH v2 0/2] Implement arm64 specific huge_ptep_get() Baolin Wang
2022-05-13  3:37 ` Baolin Wang
2022-05-13  3:37 ` [PATCH v2 1/2] arm64/hugetlb: Use ptep_get() to get the pte value of a huge page Baolin Wang
2022-05-13  3:37   ` Baolin Wang
2022-05-13 10:50   ` Anshuman Khandual
2022-05-13 10:50     ` Anshuman Khandual
2022-05-14  1:42     ` Baolin Wang [this message]
2022-05-14  1:42       ` Baolin Wang
2022-05-13  3:37 ` [PATCH v2 2/2] arm64/hugetlb: Implement arm64 specific huge_ptep_get() Baolin Wang
2022-05-13  3:37   ` Baolin Wang
2022-05-13 11:03   ` Anshuman Khandual
2022-05-13 11:03     ` Anshuman Khandual
2022-05-14  1:43     ` Baolin Wang
2022-05-14  1:43       ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30e805ba-cf4d-c13c-8d34-e1b2d9e77dae@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=songmuchun@bytedance.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.