All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 2/2] xen/arm: Misc improvements to do_common_cpu_on()
Date: Wed, 8 May 2019 16:46:30 +0100	[thread overview]
Message-ID: <30ff3cb3-7d1f-2838-06dc-3b94de3bfebc@arm.com> (raw)
In-Reply-To: <1556129458-11418-3-git-send-email-andrew.cooper3@citrix.com>

Hi Andrew,

On 24/04/2019 19:10, Andrew Cooper wrote:
>   * Use domain_vcpu() rather than opencoding the lookup.  Amongst other things,
>     domain_vcpu() is spectre-v1-safe.
>   * Unlock the domain immediately after arch_set_info_guest() completes.  There
>     is no need for free_vcpu_guest_context() to be within the critical region,
>     and moving the call simplifies the error case.
> 
> No practical change in functionaltiy.

s/functionaltiy/functionality/

> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Julien Grall <julien.grall@arm.com>

I will fix up the typo and queue it in my next-4.13 branch.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/2] xen/arm: Misc improvements to do_common_cpu_on()
Date: Wed, 8 May 2019 16:46:30 +0100	[thread overview]
Message-ID: <30ff3cb3-7d1f-2838-06dc-3b94de3bfebc@arm.com> (raw)
Message-ID: <20190508154630.J1-iA_IzAXo_qlrshwreQYE10c8cxZmEj7qA75tfjqA@z> (raw)
In-Reply-To: <1556129458-11418-3-git-send-email-andrew.cooper3@citrix.com>

Hi Andrew,

On 24/04/2019 19:10, Andrew Cooper wrote:
>   * Use domain_vcpu() rather than opencoding the lookup.  Amongst other things,
>     domain_vcpu() is spectre-v1-safe.
>   * Unlock the domain immediately after arch_set_info_guest() completes.  There
>     is no need for free_vcpu_guest_context() to be within the critical region,
>     and moving the call simplifies the error case.
> 
> No practical change in functionaltiy.

s/functionaltiy/functionality/

> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Julien Grall <julien.grall@arm.com>

I will fix up the typo and queue it in my next-4.13 branch.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-08 15:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 18:10 [PATCH 0/2] Misc vcpu_op() adjustments Andrew Cooper
2019-04-24 18:10 ` [Xen-devel] " Andrew Cooper
2019-04-24 18:10 ` [PATCH 1/2] xen/domain: Block more speculative out-of-bound accesses Andrew Cooper
2019-04-24 18:10   ` [Xen-devel] " Andrew Cooper
2019-04-25  8:04   ` Norbert Manthey
2019-04-25  8:04     ` [Xen-devel] " Norbert Manthey
2019-04-25 13:22   ` Jan Beulich
2019-04-25 13:22     ` [Xen-devel] " Jan Beulich
2019-04-24 18:10 ` [PATCH 2/2] xen/arm: Misc improvements to do_common_cpu_on() Andrew Cooper
2019-04-24 18:10   ` [Xen-devel] " Andrew Cooper
2019-05-08 15:46   ` Julien Grall [this message]
2019-05-08 15:46     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30ff3cb3-7d1f-2838-06dc-3b94de3bfebc@arm.com \
    --to=julien.grall@arm.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.