All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: kernel test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Vipin Sharma <vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org
Cc: kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	mkoutny-IBi9RG/b67k@public.gmane.org,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	dmatlack-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	jiangshanlai-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3] KVM: Move VM's worker kthreads back to the original cgroup before exiting.
Date: Thu, 17 Feb 2022 17:05:45 +0100	[thread overview]
Message-ID: <3113f00a-e910-2dfb-479f-268566445630@redhat.com> (raw)
In-Reply-To: <202202172046.GuW8pHQc-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

On 2/17/22 13:34, kernel test robot wrote:
>> 5859		reattach_err = cgroup_attach_task_all(current->real_parent, current);

This needs to be within rcu_dereference().

Paolo

>    5860		if (reattach_err) {
>    5861			kvm_err("%s: cgroup_attach_task_all failed on reattach with err %d\n",
>    5862				__func__, reattach_err);
>    5863		}
>    5864		return err;
>    5865	}
>    5866	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org
> 


WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: kernel test robot <lkp@intel.com>,
	Vipin Sharma <vipinsh@google.com>,
	seanjc@google.com
Cc: kbuild-all@lists.01.org, mkoutny@suse.com, tj@kernel.org,
	lizefan.x@bytedance.com, hannes@cmpxchg.org, dmatlack@google.com,
	jiangshanlai@gmail.com, kvm@vger.kernel.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] KVM: Move VM's worker kthreads back to the original cgroup before exiting.
Date: Thu, 17 Feb 2022 17:05:45 +0100	[thread overview]
Message-ID: <3113f00a-e910-2dfb-479f-268566445630@redhat.com> (raw)
In-Reply-To: <202202172046.GuW8pHQc-lkp@intel.com>

On 2/17/22 13:34, kernel test robot wrote:
>> 5859		reattach_err = cgroup_attach_task_all(current->real_parent, current);

This needs to be within rcu_dereference().

Paolo

>    5860		if (reattach_err) {
>    5861			kvm_err("%s: cgroup_attach_task_all failed on reattach with err %d\n",
>    5862				__func__, reattach_err);
>    5863		}
>    5864		return err;
>    5865	}
>    5866	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 


WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3] KVM: Move VM's worker kthreads back to the original cgroup before exiting.
Date: Thu, 17 Feb 2022 17:05:45 +0100	[thread overview]
Message-ID: <3113f00a-e910-2dfb-479f-268566445630@redhat.com> (raw)
In-Reply-To: <202202172046.GuW8pHQc-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

On 2/17/22 13:34, kernel test robot wrote:
>> 5859		reattach_err = cgroup_attach_task_all(current->real_parent, current);

This needs to be within rcu_dereference().

Paolo

>    5860		if (reattach_err) {
>    5861			kvm_err("%s: cgroup_attach_task_all failed on reattach with err %d\n",
>    5862				__func__, reattach_err);
>    5863		}
>    5864		return err;
>    5865	}
>    5866	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> 

  parent reply	other threads:[~2022-02-17 16:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17  6:16 [PATCH v3] KVM: Move VM's worker kthreads back to the original cgroup before exiting Vipin Sharma
2022-02-17  6:16 ` Vipin Sharma
     [not found] ` <20220217061616.3303271-1-vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2022-02-17 12:34   ` kernel test robot
2022-02-17 12:34     ` kernel test robot
2022-02-17 12:34     ` kernel test robot
     [not found]     ` <202202172046.GuW8pHQc-lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2022-02-17 16:05       ` Paolo Bonzini [this message]
2022-02-17 16:05         ` Paolo Bonzini
2022-02-17 16:05         ` Paolo Bonzini
     [not found]         ` <3113f00a-e910-2dfb-479f-268566445630-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2022-02-19  0:30           ` Sean Christopherson
2022-02-19  0:30             ` Sean Christopherson
2022-02-19  0:30             ` Sean Christopherson
2022-02-19  7:55             ` Paolo Bonzini
2022-02-19  7:55               ` Paolo Bonzini
2022-02-17 19:47   ` kernel test robot
2022-02-17 19:47     ` kernel test robot
2022-02-17 19:47     ` kernel test robot
2022-02-17 23:22   ` kernel test robot
2022-02-17 23:22     ` kernel test robot
2022-02-17 23:22     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3113f00a-e910-2dfb-479f-268566445630@redhat.com \
    --to=pbonzini-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dmatlack-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=jiangshanlai-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kbuild-all-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
    --cc=lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=mkoutny-IBi9RG/b67k@public.gmane.org \
    --cc=seanjc-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=vipinsh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.